* [PATCH v2] staging: bcm2835-audio: fix trailing statements
@ 2017-02-10 18:52 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-10 18:52 UTC (permalink / raw)
To: gregkh
Cc: Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Stephen Warren, Lee Jones, Eric Anholt,
Michael Zoran, Dan Carpenter, Seraphime Kirkovski, Arnd Bergmann,
Colin Ian King, Michael Rupprecht, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 6578246..fc9f153 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
LOG_ERR("Couldn't set the controls for stream %d\n", i);
ret = -1;
- } else LOG_DBG(" Controls set for stream %d\n", i);
+ } else {
+ LOG_DBG(" Controls set for stream %d\n", i);
+ }
}
}
LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] staging: bcm2835-audio: fix trailing statements
@ 2017-02-10 18:52 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-10 18:52 UTC (permalink / raw)
To: linux-arm-kernel
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 6578246..fc9f153 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
LOG_ERR("Couldn't set the controls for stream %d\n", i);
ret = -1;
- } else LOG_DBG(" Controls set for stream %d\n", i);
+ } else {
+ LOG_DBG(" Controls set for stream %d\n", i);
+ }
}
}
LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] staging: bcm2835-audio: fix trailing statements
@ 2017-02-10 18:50 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-10 18:50 UTC (permalink / raw)
To: gregkh
Cc: Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Stephen Warren, Lee Jones, Eric Anholt,
Michael Zoran, Dan Carpenter, Seraphime Kirkovski, Arnd Bergmann,
Michael Rupprecht, devel, linux-rpi-kernel, linux-arm-kernel,
linux-kernel
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 6578246..fc9f153 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
LOG_ERR("Couldn't set the controls for stream %d\n", i);
ret = -1;
- } else LOG_DBG(" Controls set for stream %d\n", i);
+ } else {
+ LOG_DBG(" Controls set for stream %d\n", i);
+ }
}
}
LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] staging: bcm2835-audio: fix trailing statements
@ 2017-02-10 18:50 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-10 18:50 UTC (permalink / raw)
To: linux-arm-kernel
Trailing statements should be on next line.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2:braces {} should be used on all arms of this statement
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 6578246..fc9f153 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
LOG_ERR("Couldn't set the controls for stream %d\n", i);
ret = -1;
- } else LOG_DBG(" Controls set for stream %d\n", i);
+ } else {
+ LOG_DBG(" Controls set for stream %d\n", i);
+ }
}
}
LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-10 18:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 18:52 [PATCH v2] staging: bcm2835-audio: fix trailing statements AbdAllah-MEZITI
2017-02-10 18:52 ` AbdAllah-MEZITI
-- strict thread matches above, loose matches on Subject: below --
2017-02-10 18:50 AbdAllah-MEZITI
2017-02-10 18:50 ` AbdAllah-MEZITI
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.