[Buildroot] [PATCH] util-linux: enable AUTORECONF

[Buildroot] [PATCH] util-linux: enable AUTORECONF

[Rahul Bedarkar]

Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
added two patches that touch configure.ac and Makemodule.am. But forgot
to enable AUTORECONF.

When AUTORECONF is disabled and configure.ac is patched, it looks like
make will detect change in timestamps and trigger reconfig. But it
later fails because of missing dependencies. To fix this, explicitly
enable AUTORECONF.

Fixes:
  http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

Fixes: 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Cc: Carlos Santos <casantos@datacom.ind.br>
---
 package/util-linux/util-linux.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
index 84c4f0e..441c252 100644
--- a/package/util-linux/util-linux.mk
+++ b/package/util-linux/util-linux.mk
@@ -8,6 +8,9 @@ UTIL_LINUX_VERSION_MAJOR = 2.29
 UTIL_LINUX_VERSION = $(UTIL_LINUX_VERSION_MAJOR).1
 UTIL_LINUX_SOURCE = util-linux-$(UTIL_LINUX_VERSION).tar.xz
 UTIL_LINUX_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/util-linux/v$(UTIL_LINUX_VERSION_MAJOR)
+# For 0001-build-sys-use-lm-for-scriptreplay-if-necessary.patch and
+# 0002-build-sys-improve-detection-of-the-isnan-function-in.patch
+UTIL_LINUX_AUTORECONF = YES
 
 # README.licensing claims that some files are GPLv2-only, but this is not true.
 # Some files are GPLv3+ but only in tests.
-- 
2.6.2

[Buildroot] [PATCH] util-linux: enable AUTORECONF

[Carlos Santos]

> From: "Rahul Bedarkar" <rahul.bedarkar@imgtec.com>
> To: buildroot at buildroot.org
> Cc: "Rahul Bedarkar" <rahul.bedarkar@imgtec.com>, "Carlos Santos" <casantos@datacom.ind.br>
> Sent: Friday, February 10, 2017 12:01:40 PM
> Subject: [PATCH] util-linux: enable AUTORECONF

> Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
> added two patches that touch configure.ac and Makemodule.am. But forgot
> to enable AUTORECONF.
> 
> When AUTORECONF is disabled and configure.ac is patched, it looks like
> make will detect change in timestamps and trigger reconfig. But it
> later fails because of missing dependencies. To fix this, explicitly
> enable AUTORECONF.
> 
> Fixes:
>  http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495
> 
> Fixes: 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> Cc: Carlos Santos <casantos@datacom.ind.br>
> ---
> package/util-linux/util-linux.mk | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 84c4f0e..441c252 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -8,6 +8,9 @@ UTIL_LINUX_VERSION_MAJOR = 2.29
> UTIL_LINUX_VERSION = $(UTIL_LINUX_VERSION_MAJOR).1
> UTIL_LINUX_SOURCE = util-linux-$(UTIL_LINUX_VERSION).tar.xz
> UTIL_LINUX_SITE =
> $(BR2_KERNEL_MIRROR)/linux/utils/util-linux/v$(UTIL_LINUX_VERSION_MAJOR)
> +# For 0001-build-sys-use-lm-for-scriptreplay-if-necessary.patch and
> +# 0002-build-sys-improve-detection-of-the-isnan-function-in.patch
> +UTIL_LINUX_AUTORECONF = YES
> 
> # README.licensing claims that some files are GPLv2-only, but this is not true.
> # Some files are GPLv3+ but only in tests.
> --
> 2.6.2

I'd prefer to avoid autoreconf but looks like it is required, so,

Acked-by: Carlos Santos <casantos@datacom.ind.br>

I was unable to reproduce 544e8da290d40424ea3d1bffad7e0b8a566de495 on my
machine (Fedora release 24). It can be related to the build environment.

In principle autoreconf is harmless but it adds around 10 seconds of build
time and 10 seconds more for host tools (host-{libtool,autoconf,automake}).

Carlos Santos (Casantos) - DATACOM, P&D
?Something must be done. This is something. Therefore we must do it.?
(from the BBC series ?Yes, Prime Minister?, ?Power to the people?)

[Buildroot] [PATCH] util-linux: enable AUTORECONF

[Carlos Santos]

> From: "Carlos Santos" <casantos@datacom.ind.br>
> To: "Rahul Bedarkar" <rahul.bedarkar@imgtec.com>
> Cc: buildroot at buildroot.org
> Sent: Friday, February 10, 2017 1:16:08 PM
> Subject: Re: [Buildroot] [PATCH] util-linux: enable AUTORECONF

>> From: "Rahul Bedarkar" <rahul.bedarkar@imgtec.com>
>> To: buildroot at buildroot.org
>> Cc: "Rahul Bedarkar" <rahul.bedarkar@imgtec.com>, "Carlos Santos"
>> <casantos@datacom.ind.br>
>> Sent: Friday, February 10, 2017 12:01:40 PM
>> Subject: [PATCH] util-linux: enable AUTORECONF
> 
>> Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
>> added two patches that touch configure.ac and Makemodule.am. But forgot
>> to enable AUTORECONF.
>> 
>> When AUTORECONF is disabled and configure.ac is patched, it looks like
>> make will detect change in timestamps and trigger reconfig. But it
>> later fails because of missing dependencies. To fix this, explicitly
>> enable AUTORECONF.
>> 
>> Fixes:
>>  http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

[...]

> 
> I'd prefer to avoid autoreconf but looks like it is required, so,
> 
> Acked-by: Carlos Santos <casantos@datacom.ind.br>
> 
> I was unable to reproduce 544e8da290d40424ea3d1bffad7e0b8a566de495 on my
> machine (Fedora release 24). It can be related to the build environment.

Mystery solved: automake is installed on my machine, so /usr/bin/aclocal-1.15
is used when host-automake is not built.

Carlos Santos (Casantos) - DATACOM, P&D
?Something must be done. This is something. Therefore we must do it.?
(from the BBC series ?Yes, Prime Minister?, ?Power to the people?)

[Buildroot] [PATCH] util-linux: enable AUTORECONF

[Thomas Petazzoni]

Hello,

On Fri, 10 Feb 2017 19:31:40 +0530, Rahul Bedarkar wrote:
> Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
> added two patches that touch configure.ac and Makemodule.am. But forgot
> to enable AUTORECONF.
> 
> When AUTORECONF is disabled and configure.ac is patched, it looks like
> make will detect change in timestamps and trigger reconfig. But it
> later fails because of missing dependencies. To fix this, explicitly
> enable AUTORECONF.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495
> 
> Fixes: 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> Cc: Carlos Santos <casantos@datacom.ind.br>
> ---
>  package/util-linux/util-linux.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com