[PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Konrad Rzeszutek Wilk]

Hey!

This patch lets me compile this emulator under Xen 4.7.

It probably can be done better (#ifdef magic?) but for right
now this gets me past the compile errors.

BTW, are there any other outstanding patches against this tree?


 demu.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Konrad Rzeszutek Wilk (1):
      Make it compiler under Xen 4.7.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH] Make it compiler under Xen 4.7.

[Konrad Rzeszutek Wilk]

With b7f76a699dcfadc0a52ab45b33cc72dbf3a69e7b
Author: Ian Campbell <ian.campbell@citrix.com>
Date:   Mon Jun 1 16:20:09 2015 +0100

    tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.

commit 32486916793fd78a41fc25e53d2b53a5aa0b1bd5
Author: Ian Campbell <ian.campbell@citrix.com>
Date:   Thu Jun 18 16:30:19 2015 +0100

    tools: Refactor foreign memory mapping into libxenforeignmemory

We need to use the compat layer.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

---
CC: paul.durrant@citrix.com

v1: First version
---
 demu.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/demu.c b/demu.c
index 2933efb..7d73a69 100644
--- a/demu.c
+++ b/demu.c
@@ -56,7 +56,12 @@
 
 #include <locale.h>
 
+#define XC_WANT_COMPAT_MAP_FOREIGN_API 1
+#define XC_WANT_COMPAT_EVTCHN_API 1
+
 #include <xenctrl.h>
+#include <xenctrl_compat.h>
+
 #include <xen/hvm/ioreq.h>
 
 #include "debug.h"
@@ -126,7 +131,7 @@ typedef enum {
 typedef struct demu_state {
     demu_seq_t          seq;
     xc_interface        *xch;
-    xc_interface        *xceh;
+    xc_evtchn          *xceh;
     domid_t             domid;
     unsigned int        vcpus;
     ioservid_t          ioservid;
-- 
2.9.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] Make it compiler under Xen 4.7.

[Paul Durrant]

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: 10 February 2017 21:52
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Subject: [PATCH] Make it compiler under Xen 4.7.
> 
> With b7f76a699dcfadc0a52ab45b33cc72dbf3a69e7b
> Author: Ian Campbell <ian.campbell@citrix.com>
> Date:   Mon Jun 1 16:20:09 2015 +0100
> 
>     tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.
> 
> commit 32486916793fd78a41fc25e53d2b53a5aa0b1bd5
> Author: Ian Campbell <ian.campbell@citrix.com>
> Date:   Thu Jun 18 16:30:19 2015 +0100
> 
>     tools: Refactor foreign memory mapping into libxenforeignmemory
> 
> We need to use the compat layer.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thanks for taking the time to send this. I'll incorporate this a.s.a.p.

Acked-by: Paul Durrant <paul.durrant@citrix.com>

> 
> ---
> CC: paul.durrant@citrix.com
> 
> v1: First version
> ---
>  demu.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/demu.c b/demu.c
> index 2933efb..7d73a69 100644
> --- a/demu.c
> +++ b/demu.c
> @@ -56,7 +56,12 @@
> 
>  #include <locale.h>
> 
> +#define XC_WANT_COMPAT_MAP_FOREIGN_API 1
> +#define XC_WANT_COMPAT_EVTCHN_API 1
> +
>  #include <xenctrl.h>
> +#include <xenctrl_compat.h>
> +
>  #include <xen/hvm/ioreq.h>
> 
>  #include "debug.h"
> @@ -126,7 +131,7 @@ typedef enum {
>  typedef struct demu_state {
>      demu_seq_t          seq;
>      xc_interface        *xch;
> -    xc_interface        *xceh;
> +    xc_evtchn          *xceh;
>      domid_t             domid;
>      unsigned int        vcpus;
>      ioservid_t          ioservid;
> --
> 2.9.3


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Paul Durrant]

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: 10 February 2017 21:52
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> 
> Hey!
> 
> This patch lets me compile this emulator under Xen 4.7.
> 
> It probably can be done better (#ifdef magic?) but for right
> now this gets me past the compile errors.
> 
> BTW, are there any other outstanding patches against this tree?
> 

This is still my private project, although if it's generally useful then maybe it can be adopted as part of the Xen project?

For the benefit of the list, there are two branches in http://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git

- The 'master' branch is a very basic standalone device emulator. It serves as boilerplate for emulation of a single PCI device.

- The 'console' branch is a (PS/2) Keyboard-VGA-Mouse emulator using libVNCServer which can potentially be used with an HVM guest with PV network and storage drivers, thus removing the need to use QEMU. demu is a small and constrained piece of code and thus presents a much smaller attack surface. The original intention was also to run it in a 'console service domain' to further contain damage it was successfully attacked.

It's likely that I will patch the code further once my current work on libxendevicemodel is done (following acceptance of my recent privcmd patches).

  Cheers,

    Paul

> 
>  demu.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Konrad Rzeszutek Wilk (1):
>       Make it compiler under Xen 4.7.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] Make it compiler under Xen 4.7.

[Konrad Rzeszutek Wilk]

On Mon, Feb 13, 2017 at 08:46:29AM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > Sent: 10 February 2017 21:52
> > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Subject: [PATCH] Make it compiler under Xen 4.7.
> > 
> > With b7f76a699dcfadc0a52ab45b33cc72dbf3a69e7b
> > Author: Ian Campbell <ian.campbell@citrix.com>
> > Date:   Mon Jun 1 16:20:09 2015 +0100
> > 
> >     tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.
> > 
> > commit 32486916793fd78a41fc25e53d2b53a5aa0b1bd5
> > Author: Ian Campbell <ian.campbell@citrix.com>
> > Date:   Thu Jun 18 16:30:19 2015 +0100
> > 
> >     tools: Refactor foreign memory mapping into libxenforeignmemory
> > 
> > We need to use the compat layer.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Thanks for taking the time to send this. I'll incorporate this a.s.a.p.

Thank you. Keep in mind that it will likely break against
older Xen versions (Xen 4.4?) as there is no xenctrl_compat.h

[Oh wait, Xen 4.4 didn't have ioreq either, so perhaps Xen 4.5?]

But I wasn't sure how you wanted to deal with this being compiled
against say Xen 4.6?

Or maybe the README file should just say what version of Xen
is required? (I can send an patch for that too if you would like).

> 
> Acked-by: Paul Durrant <paul.durrant@citrix.com>
> 
> > 
> > ---
> > CC: paul.durrant@citrix.com
> > 
> > v1: First version
> > ---
> >  demu.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/demu.c b/demu.c
> > index 2933efb..7d73a69 100644
> > --- a/demu.c
> > +++ b/demu.c
> > @@ -56,7 +56,12 @@
> > 
> >  #include <locale.h>
> > 
> > +#define XC_WANT_COMPAT_MAP_FOREIGN_API 1
> > +#define XC_WANT_COMPAT_EVTCHN_API 1
> > +
> >  #include <xenctrl.h>
> > +#include <xenctrl_compat.h>
> > +
> >  #include <xen/hvm/ioreq.h>
> > 
> >  #include "debug.h"
> > @@ -126,7 +131,7 @@ typedef enum {
> >  typedef struct demu_state {
> >      demu_seq_t          seq;
> >      xc_interface        *xch;
> > -    xc_interface        *xceh;
> > +    xc_evtchn          *xceh;
> >      domid_t             domid;
> >      unsigned int        vcpus;
> >      ioservid_t          ioservid;
> > --
> > 2.9.3
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Konrad Rzeszutek Wilk]

On Mon, Feb 13, 2017 at 08:58:42AM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > Sent: 10 February 2017 21:52
> > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> > Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> > 
> > Hey!
> > 
> > This patch lets me compile this emulator under Xen 4.7.
> > 
> > It probably can be done better (#ifdef magic?) but for right
> > now this gets me past the compile errors.
> > 
> > BTW, are there any other outstanding patches against this tree?
> > 
> 
> This is still my private project, although if it's generally useful then maybe it can be adopted as part of the Xen project?

It is a nice project!

By 'adopted' you mean being built as part of xen.git (like minios.git?) - and
all of those requirements?

> 
> For the benefit of the list, there are two branches in http://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git
> 
> - The 'master' branch is a very basic standalone device emulator. It serves as boilerplate for emulation of a single PCI device.
> 
> - The 'console' branch is a (PS/2) Keyboard-VGA-Mouse emulator using libVNCServer which can potentially be used with an HVM guest with PV network and storage drivers, thus removing the need to use QEMU. demu is a small and constrained piece of code and thus presents a much smaller attack surface. The original intention was also to run it in a 'console service domain' to further contain damage it was successfully attacked.
> 
> It's likely that I will patch the code further once my current work on libxendevicemodel is done (following acceptance of my recent privcmd patches).

<nods>
> 
>   Cheers,
> 
>     Paul
> 
> > 
> >  demu.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > Konrad Rzeszutek Wilk (1):
> >       Make it compiler under Xen 4.7.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] Make it compiler under Xen 4.7.

[Paul Durrant]

> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of
> Konrad Rzeszutek Wilk
> Sent: 14 February 2017 15:15
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [Xen-devel] [PATCH] Make it compiler under Xen 4.7.
> 
> On Mon, Feb 13, 2017 at 08:46:29AM +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > Sent: 10 February 2017 21:52
> > > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-
> devel@lists.xenproject.org
> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > Subject: [PATCH] Make it compiler under Xen 4.7.
> > >
> > > With b7f76a699dcfadc0a52ab45b33cc72dbf3a69e7b
> > > Author: Ian Campbell <ian.campbell@citrix.com>
> > > Date:   Mon Jun 1 16:20:09 2015 +0100
> > >
> > >     tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.
> > >
> > > commit 32486916793fd78a41fc25e53d2b53a5aa0b1bd5
> > > Author: Ian Campbell <ian.campbell@citrix.com>
> > > Date:   Thu Jun 18 16:30:19 2015 +0100
> > >
> > >     tools: Refactor foreign memory mapping into libxenforeignmemory
> > >
> > > We need to use the compat layer.
> > >
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > Thanks for taking the time to send this. I'll incorporate this a.s.a.p.
> 
> Thank you. Keep in mind that it will likely break against
> older Xen versions (Xen 4.4?) as there is no xenctrl_compat.h

I'm not sure you actually need to include that directly. I was going to try just adding the 'want compat' defines and seeing if I could make it work. I think it *should* work since all we do for upstream QEMU is add those defines into the configure cmd line IIRC.

> 
> [Oh wait, Xen 4.4 didn't have ioreq either, so perhaps Xen 4.5?]
> 
> But I wasn't sure how you wanted to deal with this being compiled
> against say Xen 4.6?
> 
> Or maybe the README file should just say what version of Xen
> is required? (I can send an patch for that too if you would like).
> 

That's ok. I can do a little experimentation and add a README.

  Paul

> >
> > Acked-by: Paul Durrant <paul.durrant@citrix.com>
> >
> > >
> > > ---
> > > CC: paul.durrant@citrix.com
> > >
> > > v1: First version
> > > ---
> > >  demu.c | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/demu.c b/demu.c
> > > index 2933efb..7d73a69 100644
> > > --- a/demu.c
> > > +++ b/demu.c
> > > @@ -56,7 +56,12 @@
> > >
> > >  #include <locale.h>
> > >
> > > +#define XC_WANT_COMPAT_MAP_FOREIGN_API 1
> > > +#define XC_WANT_COMPAT_EVTCHN_API 1
> > > +
> > >  #include <xenctrl.h>
> > > +#include <xenctrl_compat.h>
> > > +
> > >  #include <xen/hvm/ioreq.h>
> > >
> > >  #include "debug.h"
> > > @@ -126,7 +131,7 @@ typedef enum {
> > >  typedef struct demu_state {
> > >      demu_seq_t          seq;
> > >      xc_interface        *xch;
> > > -    xc_interface        *xceh;
> > > +    xc_evtchn          *xceh;
> > >      domid_t             domid;
> > >      unsigned int        vcpus;
> > >      ioservid_t          ioservid;
> > > --
> > > 2.9.3
> >
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Paul Durrant]

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: 14 February 2017 15:16
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> 
> On Mon, Feb 13, 2017 at 08:58:42AM +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > Sent: 10 February 2017 21:52
> > > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-
> devel@lists.xenproject.org
> > > Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> > >
> > > Hey!
> > >
> > > This patch lets me compile this emulator under Xen 4.7.
> > >
> > > It probably can be done better (#ifdef magic?) but for right
> > > now this gets me past the compile errors.
> > >
> > > BTW, are there any other outstanding patches against this tree?
> > >
> >
> > This is still my private project, although if it's generally useful then maybe it
> can be adopted as part of the Xen project?
> 
> It is a nice project!
> 

Glad you find it useful :-)

> By 'adopted' you mean being built as part of xen.git (like minios.git?) - and
> all of those requirements?
> 

Something like that, then it can be incorporated as an option into the xen build and we can make sure any dependency issues like this are caught in future.

I guess I'd probably make the 'console' branch master in a more official repo... I could even look at adding the necessary tooling into libxl to kick it off too :-)

  Paul

> >
> > For the benefit of the list, there are two branches in
> http://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git
> >
> > - The 'master' branch is a very basic standalone device emulator. It serves
> as boilerplate for emulation of a single PCI device.
> >
> > - The 'console' branch is a (PS/2) Keyboard-VGA-Mouse emulator using
> libVNCServer which can potentially be used with an HVM guest with PV
> network and storage drivers, thus removing the need to use QEMU. demu is
> a small and constrained piece of code and thus presents a much smaller
> attack surface. The original intention was also to run it in a 'console service
> domain' to further contain damage it was successfully attacked.
> >
> > It's likely that I will patch the code further once my current work on
> libxendevicemodel is done (following acceptance of my recent privcmd
> patches).
> 
> <nods>
> >
> >   Cheers,
> >
> >     Paul
> >
> > >
> > >  demu.c | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > Konrad Rzeszutek Wilk (1):
> > >       Make it compiler under Xen 4.7.
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Konrad Rzeszutek Wilk]

On Tue, Feb 14, 2017 at 03:26:34PM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > Sent: 14 February 2017 15:16
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> > 
> > On Mon, Feb 13, 2017 at 08:58:42AM +0000, Paul Durrant wrote:
> > > > -----Original Message-----
> > > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > > Sent: 10 February 2017 21:52
> > > > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-
> > devel@lists.xenproject.org
> > > > Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> > > >
> > > > Hey!
> > > >
> > > > This patch lets me compile this emulator under Xen 4.7.
> > > >
> > > > It probably can be done better (#ifdef magic?) but for right
> > > > now this gets me past the compile errors.
> > > >
> > > > BTW, are there any other outstanding patches against this tree?
> > > >
> > >
> > > This is still my private project, although if it's generally useful then maybe it
> > can be adopted as part of the Xen project?
> > 
> > It is a nice project!
> > 
> 
> Glad you find it useful :-)
> 
> > By 'adopted' you mean being built as part of xen.git (like minios.git?) - and
> > all of those requirements?
> > 
> 
> Something like that, then it can be incorporated as an option into the xen build and we can make sure any dependency issues like this are caught in future.
> 
> I guess I'd probably make the 'console' branch master in a more official repo... I could even look at adding the necessary tooling into libxl to kick it off too :-)

Oooh, and what kind of bribe^H^H^H^H incentive should I send your way?

> 
>   Paul
> 
> > >
> > > For the benefit of the list, there are two branches in
> > http://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git
> > >
> > > - The 'master' branch is a very basic standalone device emulator. It serves
> > as boilerplate for emulation of a single PCI device.
> > >
> > > - The 'console' branch is a (PS/2) Keyboard-VGA-Mouse emulator using
> > libVNCServer which can potentially be used with an HVM guest with PV
> > network and storage drivers, thus removing the need to use QEMU. demu is
> > a small and constrained piece of code and thus presents a much smaller
> > attack surface. The original intention was also to run it in a 'console service
> > domain' to further contain damage it was successfully attacked.
> > >
> > > It's likely that I will patch the code further once my current work on
> > libxendevicemodel is done (following acceptance of my recent privcmd
> > patches).
> > 
> > <nods>
> > >
> > >   Cheers,
> > >
> > >     Paul
> > >
> > > >
> > > >  demu.c | 7 ++++++-
> > > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > >
> > > > Konrad Rzeszutek Wilk (1):
> > > >       Make it compiler under Xen 4.7.
> > >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Paul Durrant]

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: 14 February 2017 15:32
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> 
> On Tue, Feb 14, 2017 at 03:26:34PM +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > Sent: 14 February 2017 15:16
> > > To: Paul Durrant <Paul.Durrant@citrix.com>
> > > Cc: xen-devel@lists.xenproject.org
> > > Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and
> later)
> > >
> > > On Mon, Feb 13, 2017 at 08:58:42AM +0000, Paul Durrant wrote:
> > > > > -----Original Message-----
> > > > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > > > Sent: 10 February 2017 21:52
> > > > > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-
> > > devel@lists.xenproject.org
> > > > > Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and
> later)
> > > > >
> > > > > Hey!
> > > > >
> > > > > This patch lets me compile this emulator under Xen 4.7.
> > > > >
> > > > > It probably can be done better (#ifdef magic?) but for right
> > > > > now this gets me past the compile errors.
> > > > >
> > > > > BTW, are there any other outstanding patches against this tree?
> > > > >
> > > >
> > > > This is still my private project, although if it's generally useful then
> maybe it
> > > can be adopted as part of the Xen project?
> > >
> > > It is a nice project!
> > >
> >
> > Glad you find it useful :-)
> >
> > > By 'adopted' you mean being built as part of xen.git (like minios.git?) -
> and
> > > all of those requirements?
> > >
> >
> > Something like that, then it can be incorporated as an option into the xen
> build and we can make sure any dependency issues like this are caught in
> future.
> >
> > I guess I'd probably make the 'console' branch master in a more official
> repo... I could even look at adding the necessary tooling into libxl to kick it off
> too :-)
> 
> Oooh, and what kind of bribe^H^H^H^H incentive should I send your way?
> 

A time machine? :-)

  Paul

> >
> >   Paul
> >
> > > >
> > > > For the benefit of the list, there are two branches in
> > > http://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git
> > > >
> > > > - The 'master' branch is a very basic standalone device emulator. It
> serves
> > > as boilerplate for emulation of a single PCI device.
> > > >
> > > > - The 'console' branch is a (PS/2) Keyboard-VGA-Mouse emulator using
> > > libVNCServer which can potentially be used with an HVM guest with PV
> > > network and storage drivers, thus removing the need to use QEMU.
> demu is
> > > a small and constrained piece of code and thus presents a much smaller
> > > attack surface. The original intention was also to run it in a 'console
> service
> > > domain' to further contain damage it was successfully attacked.
> > > >
> > > > It's likely that I will patch the code further once my current work on
> > > libxendevicemodel is done (following acceptance of my recent privcmd
> > > patches).
> > >
> > > <nods>
> > > >
> > > >   Cheers,
> > > >
> > > >     Paul
> > > >
> > > > >
> > > > >  demu.c | 7 ++++++-
> > > > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > > >
> > > > > Konrad Rzeszutek Wilk (1):
> > > > >       Make it compiler under Xen 4.7.
> > > >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)

[Konrad Rzeszutek Wilk]

On Tue, Feb 14, 2017 at 03:39:00PM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > Sent: 14 February 2017 15:32
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and later)
> > 
> > On Tue, Feb 14, 2017 at 03:26:34PM +0000, Paul Durrant wrote:
> > > > -----Original Message-----
> > > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > > Sent: 14 February 2017 15:16
> > > > To: Paul Durrant <Paul.Durrant@citrix.com>
> > > > Cc: xen-devel@lists.xenproject.org
> > > > Subject: Re: [PATCH v1] Make demu.git compiler under Xen 4.7 (and
> > later)
> > > >
> > > > On Mon, Feb 13, 2017 at 08:58:42AM +0000, Paul Durrant wrote:
> > > > > > -----Original Message-----
> > > > > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > > > > Sent: 10 February 2017 21:52
> > > > > > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-
> > > > devel@lists.xenproject.org
> > > > > > Subject: [PATCH v1] Make demu.git compiler under Xen 4.7 (and
> > later)
> > > > > >
> > > > > > Hey!
> > > > > >
> > > > > > This patch lets me compile this emulator under Xen 4.7.
> > > > > >
> > > > > > It probably can be done better (#ifdef magic?) but for right
> > > > > > now this gets me past the compile errors.
> > > > > >
> > > > > > BTW, are there any other outstanding patches against this tree?
> > > > > >
> > > > >
> > > > > This is still my private project, although if it's generally useful then
> > maybe it
> > > > can be adopted as part of the Xen project?
> > > >
> > > > It is a nice project!
> > > >
> > >
> > > Glad you find it useful :-)
> > >
> > > > By 'adopted' you mean being built as part of xen.git (like minios.git?) -
> > and
> > > > all of those requirements?
> > > >
> > >
> > > Something like that, then it can be incorporated as an option into the xen
> > build and we can make sure any dependency issues like this are caught in
> > future.
> > >
> > > I guess I'd probably make the 'console' branch master in a more official
> > repo... I could even look at adding the necessary tooling into libxl to kick it off
> > too :-)
> > 
> > Oooh, and what kind of bribe^H^H^H^H incentive should I send your way?
> > 
> 
> A time machine? :-)

Analog or digital? Amazon.co.uk does have a nice list of 'Timex' ones :-)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] Make it compiler under Xen 4.7.

[Paul Durrant]

> -----Original Message-----
[snip]
> > Thank you. Keep in mind that it will likely break against
> > older Xen versions (Xen 4.4?) as there is no xenctrl_compat.h
> 
> I'm not sure you actually need to include that directly. I was going to try just
> adding the 'want compat' defines and seeing if I could make it work. I think it
> *should* work since all we do for upstream QEMU is add those defines into
> the configure cmd line IIRC.

I pushed modified patches into the master and console branches. Hopefully it should now build ok for you.

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel