From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/4] PTP attribute handling cleanup
Date: Tue, 14 Feb 2017 10:23:30 -0800 [thread overview]
Message-ID: <20170214182334.23296-1-dmitry.torokhov@gmail.com> (raw)
PTP core was creating some attributes, such as "period" and "fifo", and the
entire "pins" attribute group, after creating class deevice, which creates
a race for userspace: uevent may arrive before all attributes are created.
This series of patches switches PTP to use is_visible() to control
visibility of attributes in a group, and device_create_with_groups() to
ensure that attributes are created before we notify userspace of a new
device.
v2:
- added Richard's acked-by to patch #1
- removed use of kmalloc_array in favor of kcalloc in patch #2 at
Richard's request
- added a cover letter
v1:
- initial patch set
Dmitry Torokhov (4):
ptp: do not explicitly set drvdata in ptp_clock_register()
ptp: use kcalloc when allocating arrays
ptp: use is_visible method to hide unused attributes
ptp: create "pins" together with the rest of attributes
drivers/ptp/ptp_clock.c | 22 +++---
drivers/ptp/ptp_private.h | 7 +-
drivers/ptp/ptp_sysfs.c | 167 ++++++++++++++++++----------------------------
3 files changed, 80 insertions(+), 116 deletions(-)
Thanks.
--
Dmitry
next reply other threads:[~2017-02-14 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 18:23 Dmitry Torokhov [this message]
2017-02-14 18:23 ` [PATCH v2 1/4] ptp: do not explicitly set drvdata in ptp_clock_register() Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 2/4] ptp: use kcalloc when allocating arrays Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 4/4] ptp: create "pins" together with the rest of attributes Dmitry Torokhov
2017-02-15 17:22 ` [PATCH v2 0/4] PTP attribute handling cleanup David Miller
2017-02-16 10:30 ` Richard Cochran
2017-02-16 20:19 ` Richard Cochran
2017-02-17 16:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214182334.23296-1-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.