From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] ptp: do not explicitly set drvdata in ptp_clock_register()
Date: Tue, 14 Feb 2017 10:23:31 -0800 [thread overview]
Message-ID: <20170214182334.23296-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170214182334.23296-1-dmitry.torokhov@gmail.com>
We do not need explicitly call dev_set_drvdata(), as it is done for us by
device_create().
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/ptp/ptp_clock.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 9c13381b6966..b4e5e8022c29 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -227,8 +227,6 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
if (IS_ERR(ptp->dev))
goto no_device;
- dev_set_drvdata(ptp->dev, ptp);
-
err = ptp_populate_sysfs(ptp);
if (err)
goto no_sysfs;
--
2.11.0.483.g087da7b7c-goog
next prev parent reply other threads:[~2017-02-14 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 18:23 [PATCH v2 0/4] PTP attribute handling cleanup Dmitry Torokhov
2017-02-14 18:23 ` Dmitry Torokhov [this message]
2017-02-14 18:23 ` [PATCH v2 2/4] ptp: use kcalloc when allocating arrays Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 4/4] ptp: create "pins" together with the rest of attributes Dmitry Torokhov
2017-02-15 17:22 ` [PATCH v2 0/4] PTP attribute handling cleanup David Miller
2017-02-16 10:30 ` Richard Cochran
2017-02-16 20:19 ` Richard Cochran
2017-02-17 16:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214182334.23296-2-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.