All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (hch@lst.de)
Subject: [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request.
Date: Wed, 15 Feb 2017 17:15:23 +0100	[thread overview]
Message-ID: <20170215161523.GA27837@lst.de> (raw)
In-Reply-To: <fbe16be7-ed21-d231-471e-cdffe346264b@grimberg.me>

On Wed, Feb 15, 2017@10:58:32AM +0200, Sagi Grimberg wrote:
> Yep, forgot that the sq/cq are referenced from the rsp which is
> per-queue.
>
> Christoph, James, can I get an ack from you guys?

I really hate the nvmet_req_fabric_ops_init and
nvmet_req_link_to_nvme_queues helpers, just use direct assignments
instead of trivial helpers with crazy long names.

I need to look at it a bit more for the a real review.

  reply	other threads:[~2017-02-15 16:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 22:37 [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request Parav Pandit
2017-02-08 10:13 ` Sagi Grimberg
2017-02-08 18:06   ` Parav Pandit
2017-02-08 18:18     ` Sagi Grimberg
2017-02-08 20:02       ` Parav Pandit
2017-02-13 16:11       ` Parav Pandit
2017-02-15  8:58         ` Sagi Grimberg
2017-02-15 16:15           ` hch [this message]
2017-02-15 16:28             ` Sagi Grimberg
2017-02-15 16:31               ` Parav Pandit
2017-02-15 16:34                 ` hch
2017-02-15 16:54                   ` Parav Pandit
2017-02-13 16:12       ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215161523.GA27837@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.