All of lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request.
Date: Wed, 15 Feb 2017 10:58:32 +0200	[thread overview]
Message-ID: <fbe16be7-ed21-d231-471e-cdffe346264b@grimberg.me> (raw)
In-Reply-To: <VI1PR0502MB3008753C22DDAD6B5C20FC57D1590@VI1PR0502MB3008.eurprd05.prod.outlook.com>


> Hi Sagi,

Hi Parav,

>> Sorry, I am still not getting it.
>> nvmet_rdma_rsp structure contains nvmet_req.
>> nvmet_rdma_rsp (and so nvmet_req) are per QP allocations.
>> cq and sq pointers are initialized inside nvmet_req.
>>
>> nvmet_rdma_cmd is per RQ/SRQ allocation.
>> When we do recv_done(), we bind rsp structure to cmd (cmd can be from RQ
>> or SRQ).
>> So I believe this is still good.
>> If we have cq and sq pointer inside the nvmet_rdma_cmd than I can
>> understand that it can break.
>>
>> On a side note: I tested the patch with use_srq flag (but didn't publish its
>> performance numbers as they awaiting your per core SRQ fixes to match
>> regular RQ numbers :-) ).

Yep, forgot that the sq/cq are referenced from the rsp which is
per-queue.

Christoph, James, can I get an ack from you guys?

  reply	other threads:[~2017-02-15  8:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 22:37 [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request Parav Pandit
2017-02-08 10:13 ` Sagi Grimberg
2017-02-08 18:06   ` Parav Pandit
2017-02-08 18:18     ` Sagi Grimberg
2017-02-08 20:02       ` Parav Pandit
2017-02-13 16:11       ` Parav Pandit
2017-02-15  8:58         ` Sagi Grimberg [this message]
2017-02-15 16:15           ` hch
2017-02-15 16:28             ` Sagi Grimberg
2017-02-15 16:31               ` Parav Pandit
2017-02-15 16:34                 ` hch
2017-02-15 16:54                   ` Parav Pandit
2017-02-13 16:12       ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbe16be7-ed21-d231-471e-cdffe346264b@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.