All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: <linux-arm-kernel@lists.infradead.org>, <mp-cs@actions-semi.com>,
	<info@ucrobotics.com>, <support@lemaker.org>,
	<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	<devicetree@vger.kernel.org>, <nd@arm.com>
Subject: Re: [PATCH 08/11] ARM: dts: Prepare Actions Semi S500 and LeMaker Guitar
Date: Wed, 15 Feb 2017 17:36:11 +0000	[thread overview]
Message-ID: <20170215173610.GJ31733@leverpostej> (raw)
In-Reply-To: <9dbb7749-a58b-9e18-33c9-fd004a713ed1@suse.de>

On Wed, Feb 15, 2017 at 06:28:31PM +0100, Andreas Färber wrote:
> Hi Mark,
> 
> Am 15.02.2017 um 18:07 schrieb Mark Rutland:
> > On Wed, Feb 15, 2017 at 05:55:25PM +0100, Andreas Färber wrote:
> >> +	arm-pmu {
> >> +		compatible = "arm,cortex-a9-pmu";
> >> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> +        };
> > 
> > Please add an interrupt-affinity property, as described in
> > Documentation/devicetree/bindings/arm/pmu.txt
> 
> That's not in the vendor tree... My guess is it would be like this then?
> 
> diff --git a/arch/arm/boot/dts/s500.dtsi b/arch/arm/boot/dts/s500.dtsi
> index ee93984..959c6e3 100644
> --- a/arch/arm/boot/dts/s500.dtsi
> +++ b/arch/arm/boot/dts/s500.dtsi
> @@ -82,7 +82,8 @@
>                              <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> -        };
> +               interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> +       };

Assuming that's how they're wired up, yes.

You should be able to test this by using perf record in per-cpu mode,
on an application with its affintiy fixed to a particular CPU, and
verifying that overflow interrupts are recevied on the same CPU.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	mp-cs-/sSyCTpAT0ql5r2w9Jh5Rg@public.gmane.org,
	info-Ty1hIZOCd2XuufBYgWm87A@public.gmane.org,
	support-8Vy/tIz7429AfugRpC6u6w@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	nd-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH 08/11] ARM: dts: Prepare Actions Semi S500 and LeMaker Guitar
Date: Wed, 15 Feb 2017 17:36:11 +0000	[thread overview]
Message-ID: <20170215173610.GJ31733@leverpostej> (raw)
In-Reply-To: <9dbb7749-a58b-9e18-33c9-fd004a713ed1-l3A5Bk7waGM@public.gmane.org>

On Wed, Feb 15, 2017 at 06:28:31PM +0100, Andreas Färber wrote:
> Hi Mark,
> 
> Am 15.02.2017 um 18:07 schrieb Mark Rutland:
> > On Wed, Feb 15, 2017 at 05:55:25PM +0100, Andreas Färber wrote:
> >> +	arm-pmu {
> >> +		compatible = "arm,cortex-a9-pmu";
> >> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> +        };
> > 
> > Please add an interrupt-affinity property, as described in
> > Documentation/devicetree/bindings/arm/pmu.txt
> 
> That's not in the vendor tree... My guess is it would be like this then?
> 
> diff --git a/arch/arm/boot/dts/s500.dtsi b/arch/arm/boot/dts/s500.dtsi
> index ee93984..959c6e3 100644
> --- a/arch/arm/boot/dts/s500.dtsi
> +++ b/arch/arm/boot/dts/s500.dtsi
> @@ -82,7 +82,8 @@
>                              <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> -        };
> +               interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> +       };

Assuming that's how they're wired up, yes.

You should be able to test this by using perf record in per-cpu mode,
on an application with its affintiy fixed to a particular CPU, and
verifying that overflow interrupts are recevied on the same CPU.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] ARM: dts: Prepare Actions Semi S500 and LeMaker Guitar
Date: Wed, 15 Feb 2017 17:36:11 +0000	[thread overview]
Message-ID: <20170215173610.GJ31733@leverpostej> (raw)
In-Reply-To: <9dbb7749-a58b-9e18-33c9-fd004a713ed1@suse.de>

On Wed, Feb 15, 2017 at 06:28:31PM +0100, Andreas F?rber wrote:
> Hi Mark,
> 
> Am 15.02.2017 um 18:07 schrieb Mark Rutland:
> > On Wed, Feb 15, 2017 at 05:55:25PM +0100, Andreas F?rber wrote:
> >> +	arm-pmu {
> >> +		compatible = "arm,cortex-a9-pmu";
> >> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> >> +		             <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> +        };
> > 
> > Please add an interrupt-affinity property, as described in
> > Documentation/devicetree/bindings/arm/pmu.txt
> 
> That's not in the vendor tree... My guess is it would be like this then?
> 
> diff --git a/arch/arm/boot/dts/s500.dtsi b/arch/arm/boot/dts/s500.dtsi
> index ee93984..959c6e3 100644
> --- a/arch/arm/boot/dts/s500.dtsi
> +++ b/arch/arm/boot/dts/s500.dtsi
> @@ -82,7 +82,8 @@
>                              <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
>                              <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> -        };
> +               interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> +       };

Assuming that's how they're wired up, yes.

You should be able to test this by using perf record in per-cpu mode,
on an application with its affintiy fixed to a particular CPU, and
verifying that overflow interrupts are recevied on the same CPU.

Thanks,
Mark.

  reply	other threads:[~2017-02-15 17:36 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 16:55 [PATCH 00/11] ARM: Initial Actions Semi S500 and S900 enablement Andreas Färber
2017-02-15 16:55 ` Andreas Färber
2017-02-15 16:55 ` [PATCH 01/11] Documentation: devicetree: Add vendor prefix for Actions Semi Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 02/11] Documentation: devicetree: arm: Document Actions Semi S500 Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 03/11] ARM: Prepare " Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 04/11] ARM64: Prepare Actions Semi S900 Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-16 13:43   ` Arnd Bergmann
2017-02-16 13:43     ` Arnd Bergmann
2017-02-17  0:34     ` Andreas Färber
2017-02-17  0:34       ` Andreas Färber
2017-02-17 11:32       ` Arnd Bergmann
2017-02-17 11:32         ` Arnd Bergmann
2017-02-15 16:55 ` [PATCH 05/11] Documentation: devicetree: serial: Document Actions Semi Owl UARTs Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 06/11] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-16 13:41   ` Arnd Bergmann
2017-02-16 13:41     ` Arnd Bergmann
2017-02-16 13:41     ` Arnd Bergmann
2017-02-20 13:40     ` Andreas Färber
2017-02-20 13:40       ` Andreas Färber
2017-02-20 15:17       ` Arnd Bergmann
2017-02-20 15:17         ` Arnd Bergmann
2017-02-15 16:55 ` [PATCH 07/11] Documentation: kernel-parameters: Document owl earlycon Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 08/11] ARM: dts: Prepare Actions Semi S500 and LeMaker Guitar Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 17:07   ` Mark Rutland
2017-02-15 17:07     ` Mark Rutland
2017-02-15 17:07     ` Mark Rutland
2017-02-15 17:28     ` Andreas Färber
2017-02-15 17:28       ` Andreas Färber
2017-02-15 17:28       ` Andreas Färber
2017-02-15 17:36       ` Mark Rutland [this message]
2017-02-15 17:36         ` Mark Rutland
2017-02-15 17:36         ` Mark Rutland
2017-02-24  0:59   ` Andreas Färber
2017-02-24  0:59     ` Andreas Färber
2017-02-15 16:55 ` [PATCH 09/11] Documentation: devicetree: Add vendor prefix for uCRobotics Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55 ` [PATCH 10/11] Documentation: devicetree: arm: Document Actions Semi S900 Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-27 14:26   ` Rob Herring
2017-02-27 14:26     ` Rob Herring
2017-02-27 14:26     ` Rob Herring
2017-02-15 16:55 ` [PATCH 11/11] ARM64: dts: Prepare Actions Semi S900 and Bubblegum-96 Andreas Färber
2017-02-15 16:55   ` Andreas Färber
2017-02-15 17:12   ` Mark Rutland
2017-02-15 17:12     ` Mark Rutland
2017-02-15 17:12     ` Mark Rutland
2017-02-15 18:14     ` Andreas Färber
2017-02-15 18:14       ` Andreas Färber
2017-02-15 18:23       ` Mark Rutland
2017-02-15 18:23         ` Mark Rutland
2017-02-15 18:23         ` Mark Rutland
2017-02-16 13:46 ` [PATCH 00/11] ARM: Initial Actions Semi S500 and S900 enablement Arnd Bergmann
2017-02-16 13:46   ` Arnd Bergmann
2017-02-16 13:46   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215173610.GJ31733@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=afaerber@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=info@ucrobotics.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mp-cs@actions-semi.com \
    --cc=nd@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=support@lemaker.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.