From: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-pci@vger.kernel.org, yurovsky@gmail.com,
Lucas Stach <l.stach@pengutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Lee Jones <lee.jones@linaro.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D
Date: Wed, 15 Feb 2017 15:26:24 -0600 [thread overview]
Message-ID: <20170215212624.btdhfn4xvuppv6hq@rob-hp-laptop> (raw)
In-Reply-To: <20170215173850.GH19040@bhelgaas-glaptop.roam.corp.google.com>
On Wed, Feb 15, 2017 at 11:38:50AM -0600, Bjorn Helgaas wrote:
> On Wed, Feb 15, 2017 at 11:17:00AM -0600, Rob Herring wrote:
> > On Tue, Feb 07, 2017 at 07:50:27AM -0800, Andrey Smirnov wrote:
> > > Add various bits of code needed to support i.MX7D variant of the IP.
> >
> > [...]
> >
> > > @@ -251,6 +261,10 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
> > > u32 val, gpr1, gpr12;
> > >
> > > switch (imx6_pcie->variant) {
> > > + case IMX7D:
> > > + reset_control_assert(imx6_pcie->pciephy_reset);
> > > + reset_control_assert(imx6_pcie->apps_reset);
> > > + break;
> > > case IMX6SX:
> > > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > > IMX6SX_GPR12_PCIE_TEST_POWERDOWN,
> >
> > So the difference with i.MX7D is not really that it has a reset or not,
> > but some platforms use a reset driver and some do not. The latter should
> > be fixed.
>
> I have this patch queued for v4.11. Are these things that should be
> fixed first? If so, I can drop this.
Well, depends if you trust things will get fixed later and if the PHY
in fact should be separate as that affects the binding. It would affect
how the driver changes are done as instead of "if (IMX7D) ...", you'd
have "if (imx6_pcie->apps_reset) ..." for example. That part depends on
how much churn you want there.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Andrey Smirnov
<andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yurovsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D
Date: Wed, 15 Feb 2017 15:26:24 -0600 [thread overview]
Message-ID: <20170215212624.btdhfn4xvuppv6hq@rob-hp-laptop> (raw)
In-Reply-To: <20170215173850.GH19040-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
On Wed, Feb 15, 2017 at 11:38:50AM -0600, Bjorn Helgaas wrote:
> On Wed, Feb 15, 2017 at 11:17:00AM -0600, Rob Herring wrote:
> > On Tue, Feb 07, 2017 at 07:50:27AM -0800, Andrey Smirnov wrote:
> > > Add various bits of code needed to support i.MX7D variant of the IP.
> >
> > [...]
> >
> > > @@ -251,6 +261,10 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
> > > u32 val, gpr1, gpr12;
> > >
> > > switch (imx6_pcie->variant) {
> > > + case IMX7D:
> > > + reset_control_assert(imx6_pcie->pciephy_reset);
> > > + reset_control_assert(imx6_pcie->apps_reset);
> > > + break;
> > > case IMX6SX:
> > > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > > IMX6SX_GPR12_PCIE_TEST_POWERDOWN,
> >
> > So the difference with i.MX7D is not really that it has a reset or not,
> > but some platforms use a reset driver and some do not. The latter should
> > be fixed.
>
> I have this patch queued for v4.11. Are these things that should be
> fixed first? If so, I can drop this.
Well, depends if you trust things will get fixed later and if the PHY
in fact should be separate as that affects the binding. It would affect
how the driver changes are done as instead of "if (IMX7D) ...", you'd
have "if (imx6_pcie->apps_reset) ..." for example. That part depends on
how much churn you want there.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D
Date: Wed, 15 Feb 2017 15:26:24 -0600 [thread overview]
Message-ID: <20170215212624.btdhfn4xvuppv6hq@rob-hp-laptop> (raw)
In-Reply-To: <20170215173850.GH19040@bhelgaas-glaptop.roam.corp.google.com>
On Wed, Feb 15, 2017 at 11:38:50AM -0600, Bjorn Helgaas wrote:
> On Wed, Feb 15, 2017 at 11:17:00AM -0600, Rob Herring wrote:
> > On Tue, Feb 07, 2017 at 07:50:27AM -0800, Andrey Smirnov wrote:
> > > Add various bits of code needed to support i.MX7D variant of the IP.
> >
> > [...]
> >
> > > @@ -251,6 +261,10 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
> > > u32 val, gpr1, gpr12;
> > >
> > > switch (imx6_pcie->variant) {
> > > + case IMX7D:
> > > + reset_control_assert(imx6_pcie->pciephy_reset);
> > > + reset_control_assert(imx6_pcie->apps_reset);
> > > + break;
> > > case IMX6SX:
> > > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > > IMX6SX_GPR12_PCIE_TEST_POWERDOWN,
> >
> > So the difference with i.MX7D is not really that it has a reset or not,
> > but some platforms use a reset driver and some do not. The latter should
> > be fixed.
>
> I have this patch queued for v4.11. Are these things that should be
> fixed first? If so, I can drop this.
Well, depends if you trust things will get fixed later and if the PHY
in fact should be separate as that affects the binding. It would affect
how the driver changes are done as instead of "if (IMX7D) ...", you'd
have "if (imx6_pcie->apps_reset) ..." for example. That part depends on
how much churn you want there.
Rob
next prev parent reply other threads:[~2017-02-15 21:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 15:50 [PATCH v4 0/3] i.MX7 PCI support Andrey Smirnov
2017-02-07 15:50 ` Andrey Smirnov
2017-02-07 15:50 ` [PATCH v4 1/3] PCI: imx6: Fix a typo in error message Andrey Smirnov
2017-02-07 15:50 ` Andrey Smirnov
2017-02-07 15:50 ` Andrey Smirnov
2017-02-07 15:50 ` [PATCH v4 2/3] PCI: imx6: Allow probe deferal by reset GPIO Andrey Smirnov
2017-02-07 15:50 ` Andrey Smirnov
2017-02-08 0:12 ` kbuild test robot
2017-02-08 0:12 ` kbuild test robot
2017-02-08 0:12 ` kbuild test robot
2017-02-07 15:50 ` [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D Andrey Smirnov
2017-02-07 15:50 ` Andrey Smirnov
2017-02-07 16:04 ` Lucas Stach
2017-02-07 16:04 ` Lucas Stach
2017-02-07 16:04 ` Lucas Stach
2017-02-07 16:04 ` Lucas Stach
2017-02-08 12:21 ` Lee Jones
2017-02-08 12:21 ` Lee Jones
2017-02-15 17:17 ` Rob Herring
2017-02-15 17:17 ` Rob Herring
2017-02-15 17:17 ` Rob Herring
2017-02-15 17:38 ` Bjorn Helgaas
2017-02-15 17:38 ` Bjorn Helgaas
2017-02-15 17:38 ` Bjorn Helgaas
2017-02-15 21:26 ` Rob Herring [this message]
2017-02-15 21:26 ` Rob Herring
2017-02-15 21:26 ` Rob Herring
2017-02-15 21:57 ` Bjorn Helgaas
2017-02-15 21:57 ` Bjorn Helgaas
2017-02-15 21:57 ` Bjorn Helgaas
2017-02-15 21:57 ` Bjorn Helgaas
2017-02-16 9:18 ` Lucas Stach
2017-02-16 9:18 ` Lucas Stach
2017-02-16 9:18 ` Lucas Stach
2017-02-16 6:07 ` Andrey Smirnov
2017-02-16 6:07 ` Andrey Smirnov
2017-02-16 6:07 ` Andrey Smirnov
2017-02-16 6:07 ` Andrey Smirnov
2017-02-16 9:12 ` Lucas Stach
2017-02-16 9:12 ` Lucas Stach
2017-02-16 9:12 ` Lucas Stach
2017-02-16 9:12 ` Lucas Stach
2017-02-21 16:38 ` Rob Herring
2017-02-21 16:38 ` Rob Herring
2017-02-21 16:38 ` Rob Herring
2017-02-21 16:38 ` Rob Herring
2017-02-21 16:44 ` Lucas Stach
2017-02-21 16:44 ` Lucas Stach
2017-02-21 16:44 ` Lucas Stach
2017-02-10 21:40 ` [PATCH v4 0/3] i.MX7 PCI support Bjorn Helgaas
2017-02-10 21:40 ` Bjorn Helgaas
2017-02-10 21:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215212624.btdhfn4xvuppv6hq@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=helgaas@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=yurovsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.