All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
@ 2017-02-13 18:56 Vipin K Parashar
  2017-02-14  6:24   ` Vipin K Parashar
  2017-02-14  6:20 ` Vipin K Parashar
  0 siblings, 2 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-13 18:56 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Vipin K Parashar

kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log once such fails occur in short time period. Ratelimit this
error to avoid flooding kernel logs upon copy data failures.

Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
---
 arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
 arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
index a2eb6d3..ca8f960 100644
--- a/arch/powerpc/kvm/book3s_32_mmu.c
+++ b/arch/powerpc/kvm/book3s_32_mmu.c
@@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
 	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
 
 	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
 		goto no_page_found;
 	}
 
diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index b9131aa..b420aca 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -265,7 +265,8 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
 		goto no_page_found;
 
 	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
 		goto no_page_found;
 	}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
  2017-02-13 18:56 [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages Vipin K Parashar
@ 2017-02-14  6:24   ` Vipin K Parashar
  2017-02-14  6:20 ` Vipin K Parashar
  1 sibling, 0 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-14  6:12 UTC (permalink / raw)
  To: kvm-ppc; +Cc: kvm

kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log once such fails occur in short time period. Ratelimit this
error to avoid flooding kernel logs upon copy data failures.

Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
---
  arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
  arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
  2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
index a2eb6d3..ca8f960 100644
--- a/arch/powerpc/kvm/book3s_32_mmu.c
+++ b/arch/powerpc/kvm/book3s_32_mmu.c
@@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
  	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);

  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
  		goto no_page_found;
  	}

diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index b9131aa..b420aca 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -265,7 +265,8 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
  		goto no_page_found;

  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
  		goto no_page_found;
  	}

-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
  2017-02-13 18:56 [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages Vipin K Parashar
  2017-02-14  6:24   ` Vipin K Parashar
@ 2017-02-14  6:20 ` Vipin K Parashar
  2017-02-23  9:11   ` Vipin K Parashar
  1 sibling, 1 reply; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-14  6:20 UTC (permalink / raw)
  To: linuxppc-dev

Forwarded same patch to kvm@vger.kernel.org

and kvm-ppc@vger.kernel.org too.


On Tuesday 14 February 2017 12:26 AM, Vipin K Parashar wrote:
> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
> upon failing to copy user data to kernel space. This floods kernel
> log once such fails occur in short time period. Ratelimit this
> error to avoid flooding kernel logs upon copy data failures.
>
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
> ---
>   arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>   arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> index a2eb6d3..ca8f960 100644
> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>   	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
>
>   	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
> -		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
> +		if (printk_ratelimit())
> +			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
>   		goto no_page_found;
>   	}
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index b9131aa..b420aca 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -265,7 +265,8 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
>   		goto no_page_found;
>
>   	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
> -		printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
> +		if (printk_ratelimit())
> +			printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
>   		goto no_page_found;
>   	}
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
@ 2017-02-14  6:24   ` Vipin K Parashar
  0 siblings, 0 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-14  6:24 UTC (permalink / raw)
  To: kvm-ppc; +Cc: kvm

kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log once such fails occur in short time period. Ratelimit this
error to avoid flooding kernel logs upon copy data failures.

Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
---
  arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
  arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
  2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
index a2eb6d3..ca8f960 100644
--- a/arch/powerpc/kvm/book3s_32_mmu.c
+++ b/arch/powerpc/kvm/book3s_32_mmu.c
@@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
  	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);

  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
  		goto no_page_found;
  	}

diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index b9131aa..b420aca 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -265,7 +265,8 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
  		goto no_page_found;

  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
-		printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
+		if (printk_ratelimit())
+			printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
  		goto no_page_found;
  	}

-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
  2017-02-14  6:24   ` Vipin K Parashar
@ 2017-02-16  5:31     ` Paul Mackerras
  -1 siblings, 0 replies; 9+ messages in thread
From: Paul Mackerras @ 2017-02-16  5:31 UTC (permalink / raw)
  To: Vipin K Parashar; +Cc: kvm-ppc, kvm

On Tue, Feb 14, 2017 at 11:42:21AM +0530, Vipin K Parashar wrote:
> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
> upon failing to copy user data to kernel space. This floods kernel
> log once such fails occur in short time period. Ratelimit this
> error to avoid flooding kernel logs upon copy data failures.
> 
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>  arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> index a2eb6d3..ca8f960 100644
> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>  	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
> 
>  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
> -		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
> +		if (printk_ratelimit())
> +			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);

I found this in include/linux/printk.h:

/*
 * Please don't use printk_ratelimit(), because it shares ratelimiting state
 * with all other unrelated printk_ratelimit() callsites.  Instead use
 * printk_ratelimited() or plain old __ratelimit().
 */

It does seem that using printk_ratelimited(KERN_ERR ...) or the
equivalent pr_err_ratelimited(...) would be a better option.

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
@ 2017-02-16  5:31     ` Paul Mackerras
  0 siblings, 0 replies; 9+ messages in thread
From: Paul Mackerras @ 2017-02-16  5:31 UTC (permalink / raw)
  To: Vipin K Parashar; +Cc: kvm-ppc, kvm

On Tue, Feb 14, 2017 at 11:42:21AM +0530, Vipin K Parashar wrote:
> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
> upon failing to copy user data to kernel space. This floods kernel
> log once such fails occur in short time period. Ratelimit this
> error to avoid flooding kernel logs upon copy data failures.
> 
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>  arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> index a2eb6d3..ca8f960 100644
> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>  	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
> 
>  	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
> -		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
> +		if (printk_ratelimit())
> +			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);

I found this in include/linux/printk.h:

/*
 * Please don't use printk_ratelimit(), because it shares ratelimiting state
 * with all other unrelated printk_ratelimit() callsites.  Instead use
 * printk_ratelimited() or plain old __ratelimit().
 */

It does seem that using printk_ratelimited(KERN_ERR ...) or the
equivalent pr_err_ratelimited(...) would be a better option.

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
  2017-02-16  5:31     ` Paul Mackerras
@ 2017-02-16 10:45       ` Vipin K Parashar
  -1 siblings, 0 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-16 10:33 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: kvm-ppc, kvm



On Thursday 16 February 2017 11:01 AM, Paul Mackerras wrote:
> On Tue, Feb 14, 2017 at 11:42:21AM +0530, Vipin K Parashar wrote:
>> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
>> upon failing to copy user data to kernel space. This floods kernel
>> log once such fails occur in short time period. Ratelimit this
>> error to avoid flooding kernel logs upon copy data failures.
>>
>> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
>> ---
>>   arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>>   arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
>> index a2eb6d3..ca8f960 100644
>> --- a/arch/powerpc/kvm/book3s_32_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
>> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>>   	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
>>
>>   	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
>> -		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
>> +		if (printk_ratelimit())
>> +			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
> I found this in include/linux/printk.h:
>
> /*
>   * Please don't use printk_ratelimit(), because it shares ratelimiting state
>   * with all other unrelated printk_ratelimit() callsites.  Instead use
>   * printk_ratelimited() or plain old __ratelimit().
>   */
>
> It does seem that using printk_ratelimited(KERN_ERR ...) or the
> equivalent pr_err_ratelimited(...) would be a better option.

Thanks!! Paul.
Will send out v2 with above changes.

> Paul.
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
@ 2017-02-16 10:45       ` Vipin K Parashar
  0 siblings, 0 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-16 10:45 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: kvm-ppc, kvm



On Thursday 16 February 2017 11:01 AM, Paul Mackerras wrote:
> On Tue, Feb 14, 2017 at 11:42:21AM +0530, Vipin K Parashar wrote:
>> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
>> upon failing to copy user data to kernel space. This floods kernel
>> log once such fails occur in short time period. Ratelimit this
>> error to avoid flooding kernel logs upon copy data failures.
>>
>> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
>> ---
>>   arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>>   arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
>> index a2eb6d3..ca8f960 100644
>> --- a/arch/powerpc/kvm/book3s_32_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
>> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>>   	ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
>>
>>   	if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
>> -		printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
>> +		if (printk_ratelimit())
>> +			printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
> I found this in include/linux/printk.h:
>
> /*
>   * Please don't use printk_ratelimit(), because it shares ratelimiting state
>   * with all other unrelated printk_ratelimit() callsites.  Instead use
>   * printk_ratelimited() or plain old __ratelimit().
>   */
>
> It does seem that using printk_ratelimited(KERN_ERR ...) or the
> equivalent pr_err_ratelimited(...) would be a better option.

Thanks!! Paul.
Will send out v2 with above changes.

> Paul.
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages
  2017-02-14  6:20 ` Vipin K Parashar
@ 2017-02-23  9:11   ` Vipin K Parashar
  0 siblings, 0 replies; 9+ messages in thread
From: Vipin K Parashar @ 2017-02-23  9:11 UTC (permalink / raw)
  To: linuxppc-dev

v2 for this patch with 'printk_ratelimit' replaced with

'printk_ratelimited' is available at mailing list.


https://patchwork.ozlabs.org/patch/728831/



On Tuesday 14 February 2017 11:50 AM, Vipin K Parashar wrote:
> Forwarded same patch to kvm@vger.kernel.org
>
> and kvm-ppc@vger.kernel.org too.
>
>
> On Tuesday 14 February 2017 12:26 AM, Vipin K Parashar wrote:
>> kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
>> upon failing to copy user data to kernel space. This floods kernel
>> log once such fails occur in short time period. Ratelimit this
>> error to avoid flooding kernel logs upon copy data failures.
>>
>> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
>> ---
>>   arch/powerpc/kvm/book3s_32_mmu.c | 3 ++-
>>   arch/powerpc/kvm/book3s_64_mmu.c | 3 ++-
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c 
>> b/arch/powerpc/kvm/book3s_32_mmu.c
>> index a2eb6d3..ca8f960 100644
>> --- a/arch/powerpc/kvm/book3s_32_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
>> @@ -224,7 +224,8 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct 
>> kvm_vcpu *vcpu, gva_t eaddr,
>>       ptem = kvmppc_mmu_book3s_32_get_ptem(sre, eaddr, primary);
>>
>>       if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
>> -        printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", ptegp);
>> +        if (printk_ratelimit())
>> +            printk(KERN_ERR "KVM: Can't copy data from 0x%lx!\n", 
>> ptegp);
>>           goto no_page_found;
>>       }
>>
>> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c 
>> b/arch/powerpc/kvm/book3s_64_mmu.c
>> index b9131aa..b420aca 100644
>> --- a/arch/powerpc/kvm/book3s_64_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
>> @@ -265,7 +265,8 @@ static int kvmppc_mmu_book3s_64_xlate(struct 
>> kvm_vcpu *vcpu, gva_t eaddr,
>>           goto no_page_found;
>>
>>       if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
>> -        printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
>> +        if (printk_ratelimit())
>> +            printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", 
>> ptegp);
>>           goto no_page_found;
>>       }
>>
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-02-23  9:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-13 18:56 [PATCH] KVM: PPC: Book3S: Ratelimit copy data failure error messages Vipin K Parashar
2017-02-14  6:12 ` Vipin K Parashar
2017-02-14  6:24   ` Vipin K Parashar
2017-02-16  5:31   ` Paul Mackerras
2017-02-16  5:31     ` Paul Mackerras
2017-02-16 10:33     ` Vipin K Parashar
2017-02-16 10:45       ` Vipin K Parashar
2017-02-14  6:20 ` Vipin K Parashar
2017-02-23  9:11   ` Vipin K Parashar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.