[PATCH] build: add --with-rundir option to configure

[PATCH] build: add --with-rundir option to configure

[Juergen Gross]

There have been reports that Fedora 25 uses /run instead of /var/run.

Add a --with-rundir option ito configure to be able to specify that
directory. Default is still /var/run.

A re-run of autogen.sh is required.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
Backport candidate (at least 4.8)
---
 configure       | 16 ++++++++++++++--
 docs/configure  | 16 ++++++++++++++--
 m4/paths.m4     | 10 ++++++++--
 tools/configure | 16 ++++++++++++++--
 4 files changed, 50 insertions(+), 8 deletions(-)

diff --git a/configure b/configure
index d293af8..46fa04b 100755
--- a/configure
+++ b/configure
@@ -667,6 +667,7 @@ with_initddir
 with_sysconfig_leaf_dir
 with_libexec_leaf_dir
 with_xen_dumpdir
+with_rundir
 enable_githttp
 enable_xen
 enable_tools
@@ -1313,6 +1314,8 @@ Optional Packages:
                           Name of subdirectory in libexecdir to use.
   --with-xen-dumpdir=DIR  Path to directory for domU crash dumps.
                           [LOCALSTATEDIR/lib/xen/dump]
+  --with-rundir=DIR       Path to directory for runtime data.
+                          [LOCALSTATEDIR/run]
 
 Report bugs to <xen-devel@lists.xen.org>.
 Xen Hypervisor home page: <http://www.xen.org/>.
@@ -1953,6 +1956,15 @@ else
 fi
 
 
+
+# Check whether --with-rundir was given.
+if test "${with_rundir+set}" = set; then :
+  withval=$with_rundir; rundir_path=$withval
+else
+  rundir_path=$localstatedir/run
+fi
+
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -1973,7 +1985,7 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
-XEN_RUN_DIR=$localstatedir/run/xen
+XEN_RUN_DIR=$rundir_path/xen
 
 
 XEN_LOG_DIR=$localstatedir/log/xen
@@ -1982,7 +1994,7 @@ XEN_LOG_DIR=$localstatedir/log/xen
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
-XEN_RUN_STORED=$localstatedir/run/xenstored
+XEN_RUN_STORED=$rundir_path/xenstored
 
 
 XEN_LIB_DIR=$localstatedir/lib/xen
diff --git a/docs/configure b/docs/configure
index a497d1f..d05b9a8 100755
--- a/docs/configure
+++ b/docs/configure
@@ -658,6 +658,7 @@ with_initddir
 with_sysconfig_leaf_dir
 with_libexec_leaf_dir
 with_xen_dumpdir
+with_rundir
 '
       ac_precious_vars='build_alias
 host_alias
@@ -1288,6 +1289,8 @@ Optional Packages:
                           Name of subdirectory in libexecdir to use.
   --with-xen-dumpdir=DIR  Path to directory for domU crash dumps.
                           [LOCALSTATEDIR/lib/xen/dump]
+  --with-rundir=DIR       Path to directory for runtime data.
+                          [LOCALSTATEDIR/run]
 
 Some influential environment variables:
   FIG2DEV     Path to fig2dev tool
@@ -1859,6 +1862,15 @@ else
 fi
 
 
+
+# Check whether --with-rundir was given.
+if test "${with_rundir+set}" = set; then :
+  withval=$with_rundir; rundir_path=$withval
+else
+  rundir_path=$localstatedir/run
+fi
+
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -1879,7 +1891,7 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
-XEN_RUN_DIR=$localstatedir/run/xen
+XEN_RUN_DIR=$rundir_path/xen
 
 
 XEN_LOG_DIR=$localstatedir/log/xen
@@ -1888,7 +1900,7 @@ XEN_LOG_DIR=$localstatedir/log/xen
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
-XEN_RUN_STORED=$localstatedir/run/xenstored
+XEN_RUN_STORED=$rundir_path/xenstored
 
 
 XEN_LIB_DIR=$localstatedir/lib/xen
diff --git a/m4/paths.m4 b/m4/paths.m4
index 722a8aa..93ce89a 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -76,6 +76,12 @@ AC_ARG_WITH([xen-dumpdir],
     [xen_dumpdir_path=$withval],
     [xen_dumpdir_path=$localstatedir/lib/xen/dump])
 
+AC_ARG_WITH([rundir],
+    AS_HELP_STRING([--with-rundir=DIR],
+    [Path to directory for runtime data. [LOCALSTATEDIR/run]]),
+    [rundir_path=$withval],
+    [rundir_path=$localstatedir/run])
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -98,7 +104,7 @@ AC_SUBST(LIBEXEC_INC)
 XENFIRMWAREDIR=${LIBEXEC}/boot
 AC_SUBST(XENFIRMWAREDIR)
 
-XEN_RUN_DIR=$localstatedir/run/xen
+XEN_RUN_DIR=$rundir_path/xen
 AC_SUBST(XEN_RUN_DIR)
 
 XEN_LOG_DIR=$localstatedir/log/xen
@@ -107,7 +113,7 @@ AC_SUBST(XEN_LOG_DIR)
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 AC_SUBST(XEN_LIB_STORED)
 
-XEN_RUN_STORED=$localstatedir/run/xenstored
+XEN_RUN_STORED=$rundir_path/xenstored
 AC_SUBST(XEN_RUN_STORED)
 
 XEN_LIB_DIR=$localstatedir/lib/xen
diff --git a/tools/configure b/tools/configure
index ae96f6b..851e0f0 100755
--- a/tools/configure
+++ b/tools/configure
@@ -794,6 +794,7 @@ with_initddir
 with_sysconfig_leaf_dir
 with_libexec_leaf_dir
 with_xen_dumpdir
+with_rundir
 enable_rpath
 enable_githttp
 enable_monitors
@@ -1498,6 +1499,8 @@ Optional Packages:
                           Name of subdirectory in libexecdir to use.
   --with-xen-dumpdir=DIR  Path to directory for domU crash dumps.
                           [LOCALSTATEDIR/lib/xen/dump]
+  --with-rundir=DIR       Path to directory for runtime data.
+                          [LOCALSTATEDIR/run]
   --with-linux-backend-modules="mod1 mod2"
                           List of Linux backend module or modalias names to be
                           autoloaded on startup.
@@ -3910,6 +3913,15 @@ else
 fi
 
 
+
+# Check whether --with-rundir was given.
+if test "${with_rundir+set}" = set; then :
+  withval=$with_rundir; rundir_path=$withval
+else
+  rundir_path=$localstatedir/run
+fi
+
+
 if test "$libexecdir" = '${exec_prefix}/libexec' ; then
     case "$host_os" in
          *netbsd*) ;;
@@ -3930,7 +3942,7 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
-XEN_RUN_DIR=$localstatedir/run/xen
+XEN_RUN_DIR=$rundir_path/xen
 
 
 XEN_LOG_DIR=$localstatedir/log/xen
@@ -3939,7 +3951,7 @@ XEN_LOG_DIR=$localstatedir/log/xen
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
-XEN_RUN_STORED=$localstatedir/run/xenstored
+XEN_RUN_STORED=$rundir_path/xenstored
 
 
 XEN_LIB_DIR=$localstatedir/lib/xen
-- 
2.10.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Boris Ostrovsky]

On 02/16/2017 02:47 AM, Juergen Gross wrote:
> There have been reports that Fedora 25 uses /run instead of /var/run.
>
> Add a --with-rundir option ito configure to be able to specify that
> directory. Default is still /var/run.

As discussed on the other thread, why not make default be the location 
of directory on build system?

Or even have it determined at boot time?


-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Andrew Cooper]

On 16/02/17 13:52, Boris Ostrovsky wrote:
>
>
> On 02/16/2017 02:47 AM, Juergen Gross wrote:
>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>
>> Add a --with-rundir option ito configure to be able to specify that
>> directory. Default is still /var/run.
>
> As discussed on the other thread, why not make default be the location
> of directory on build system?

Because the build system is not the running system.  It doesn't even
have to be the same distro as the intended running system.  (If you are
getting adventurous, you can actually build RPMs on Windows 10, and
install them into a CentOS system...)

>
> Or even have it determined at boot time?

Where does this list stop?  Should we manually search for the
appropriate /lib, /lib64, /usr/lib, etc to find shared objects?

This is exactly the kind of issue autoconf is intended to solve.

It appears that newer versions of autoconf use --runstatedir for this. 
https://lists.gnu.org/archive/html/bug-autoconf/2013-09/msg00002.html 
It might be worth following that for forwards compatibility.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 16/02/17 14:52, Boris Ostrovsky wrote:
> 
> 
> On 02/16/2017 02:47 AM, Juergen Gross wrote:
>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>
>> Add a --with-rundir option ito configure to be able to specify that
>> directory. Default is still /var/run.
> 
> As discussed on the other thread, why not make default be the location
> of directory on build system?

The default when calling ./configure or when building xen? What is the
default for a tree on a nfs share used by both types of systems?

I don't think this solution is a sane one.

> Or even have it determined at boot time?

How would you do that? Test the existence of the directories? What do
you do if both are existing? What do you do if one is created later in
the boot process and the test is being repeated? You'd need to store
the information which directory to use somewhere. This will make all
components using the information more fragile as they need to read the
file instead of just using the configured setting. And at last: why
should we suddenly start to introduce such a behavior while all other
directories are configured statically?


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 16/02/17 15:12, Andrew Cooper wrote:
> On 16/02/17 13:52, Boris Ostrovsky wrote:
>>
>>
>> On 02/16/2017 02:47 AM, Juergen Gross wrote:
>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>
>>> Add a --with-rundir option ito configure to be able to specify that
>>> directory. Default is still /var/run.
>>
>> As discussed on the other thread, why not make default be the location
>> of directory on build system?
> 
> Because the build system is not the running system.  It doesn't even
> have to be the same distro as the intended running system.  (If you are
> getting adventurous, you can actually build RPMs on Windows 10, and
> install them into a CentOS system...)
> 
>>
>> Or even have it determined at boot time?
> 
> Where does this list stop?  Should we manually search for the
> appropriate /lib, /lib64, /usr/lib, etc to find shared objects?
> 
> This is exactly the kind of issue autoconf is intended to solve.
> 
> It appears that newer versions of autoconf use --runstatedir for this. 
> https://lists.gnu.org/archive/html/bug-autoconf/2013-09/msg00002.html 

Yeah. From autoconf 2.70 on. Which isn't released yet.

> It might be worth following that for forwards compatibility.

I'm no autoconf expert. I could deduce how to use --with-*, but I'm
lost with support of --runstatedir (repeating the patch you referenced
would probably break using autoconf 2.70 in future...).


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Konrad Rzeszutek Wilk]

On Thu, Feb 16, 2017 at 08:52:51AM -0500, Boris Ostrovsky wrote:
> 
> 
> On 02/16/2017 02:47 AM, Juergen Gross wrote:
> > There have been reports that Fedora 25 uses /run instead of /var/run.
> > 
> > Add a --with-rundir option ito configure to be able to specify that
> > directory. Default is still /var/run.
> 
> As discussed on the other thread, why not make default be the location of
> directory on build system?
> 
> Or even have it determined at boot time?

How would that work with ./install.sh doing the creation of the /run/xen and
/run/xenstored ?

Are you thinking that the systemd and init scripts should do this? I am not
sure if systemd can even.


> 
> 
> -boris
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Boris Ostrovsky]

On 02/17/2017 11:41 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Feb 16, 2017 at 08:52:51AM -0500, Boris Ostrovsky wrote:
>>
>>
>> On 02/16/2017 02:47 AM, Juergen Gross wrote:
>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>
>>> Add a --with-rundir option ito configure to be able to specify that
>>> directory. Default is still /var/run.
>>
>> As discussed on the other thread, why not make default be the location of
>> directory on build system?
>>
>> Or even have it determined at boot time?
>
> How would that work with ./install.sh doing the creation of the /run/xen and
> /run/xenstored ?
>
> Are you thinking that the systemd and init scripts should do this? I am not
> sure if systemd can even.

Yes, that's what I thought. I don't see why system can't do that. It 
does much worse things ;-)

But I don't think anyone liked that idea.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Wei Liu]

On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
> There have been reports that Fedora 25 uses /run instead of /var/run.
> 
> Add a --with-rundir option ito configure to be able to specify that

I've read this thread but I'm not sure if I need to take any action or
all the comments addressed -- especially the part about autoconf.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 20/02/17 15:31, Wei Liu wrote:
> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>
>> Add a --with-rundir option ito configure to be able to specify that
> 
> I've read this thread but I'm not sure if I need to take any action or
> all the comments addressed -- especially the part about autoconf.

Andrew, are you fine with my answer regarding autoconf? Or do you have
some information regarding --runstatedir which could help?


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Andrew Cooper]

On 20/02/17 14:43, Juergen Gross wrote:
> On 20/02/17 15:31, Wei Liu wrote:
>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>
>>> Add a --with-rundir option ito configure to be able to specify that
>> I've read this thread but I'm not sure if I need to take any action or
>> all the comments addressed -- especially the part about autoconf.
> Andrew, are you fine with my answer regarding autoconf? Or do you have
> some information regarding --runstatedir which could help?

Oh sorry.  Didn't realise I was blocking here.  I have no specific
information, other than the quick search I did.

Can't the future problem be worked around just with if autoconf version
< 2.70 ?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 20/02/17 16:19, Andrew Cooper wrote:
> On 20/02/17 14:43, Juergen Gross wrote:
>> On 20/02/17 15:31, Wei Liu wrote:
>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>
>>>> Add a --with-rundir option ito configure to be able to specify that
>>> I've read this thread but I'm not sure if I need to take any action or
>>> all the comments addressed -- especially the part about autoconf.
>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>> some information regarding --runstatedir which could help?
> 
> Oh sorry.  Didn't realise I was blocking here.  I have no specific
> information, other than the quick search I did.
> 
> Can't the future problem be worked around just with if autoconf version
> < 2.70 ?

I don't think it is possible to add configure options other than
--disable-*, --enable-*, --with-* or --without-* by other means than
patching general.m4 of autoconf. I don't think we want to do that.

So the possibilities are:

1. don't support /run instead of /var/run via configure
2. patch autoconf to support --runstatedir
3. take this patch adding support via --with-rundir and possibly
   switch over to --runstatedir when a new autoconf version is
   available

I'm in favor of (3.).


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Andrew Cooper]

On 22/02/17 07:53, Juergen Gross wrote:
> On 20/02/17 16:19, Andrew Cooper wrote:
>> On 20/02/17 14:43, Juergen Gross wrote:
>>> On 20/02/17 15:31, Wei Liu wrote:
>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>
>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>> I've read this thread but I'm not sure if I need to take any action or
>>>> all the comments addressed -- especially the part about autoconf.
>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>> some information regarding --runstatedir which could help?
>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>> information, other than the quick search I did.
>>
>> Can't the future problem be worked around just with if autoconf version
>> < 2.70 ?
> I don't think it is possible to add configure options other than
> --disable-*, --enable-*, --with-* or --without-* by other means than
> patching general.m4 of autoconf. I don't think we want to do that.

Ok.  In which case lets go with 3).

~Andrew

>
> So the possibilities are:
>
> 1. don't support /run instead of /var/run via configure
> 2. patch autoconf to support --runstatedir
> 3. take this patch adding support via --with-rundir and possibly
>    switch over to --runstatedir when a new autoconf version is
>    available
>
> I'm in favor of (3.).
>
>
> Juergen
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Wei Liu]

On Wed, Feb 22, 2017 at 08:53:24AM +0100, Juergen Gross wrote:
> On 20/02/17 16:19, Andrew Cooper wrote:
> > On 20/02/17 14:43, Juergen Gross wrote:
> >> On 20/02/17 15:31, Wei Liu wrote:
> >>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
> >>>> There have been reports that Fedora 25 uses /run instead of /var/run.
> >>>>
> >>>> Add a --with-rundir option ito configure to be able to specify that
> >>> I've read this thread but I'm not sure if I need to take any action or
> >>> all the comments addressed -- especially the part about autoconf.
> >> Andrew, are you fine with my answer regarding autoconf? Or do you have
> >> some information regarding --runstatedir which could help?
> > 
> > Oh sorry.  Didn't realise I was blocking here.  I have no specific
> > information, other than the quick search I did.
> > 
> > Can't the future problem be worked around just with if autoconf version
> > < 2.70 ?
> 
> I don't think it is possible to add configure options other than
> --disable-*, --enable-*, --with-* or --without-* by other means than
> patching general.m4 of autoconf. I don't think we want to do that.
> 
> So the possibilities are:
> 
> 1. don't support /run instead of /var/run via configure
> 2. patch autoconf to support --runstatedir
> 3. take this patch adding support via --with-rundir and possibly
>    switch over to --runstatedir when a new autoconf version is
>    available

Option 3 but we need to have that for eternity. :-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Wei Liu]

On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
> There have been reports that Fedora 25 uses /run instead of /var/run.
> 
> Add a --with-rundir option ito configure to be able to specify that
> directory. Default is still /var/run.
> 
> A re-run of autogen.sh is required.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

I think we've come to the conclusion that this patch should be taken:

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 1852 bytes --]

On 2/22/17 5:37 AM, Wei Liu wrote:
> On Wed, Feb 22, 2017 at 08:53:24AM +0100, Juergen Gross wrote:
>> On 20/02/17 16:19, Andrew Cooper wrote:
>>> On 20/02/17 14:43, Juergen Gross wrote:
>>>> On 20/02/17 15:31, Wei Liu wrote:
>>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>>
>>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>>> I've read this thread but I'm not sure if I need to take any action or
>>>>> all the comments addressed -- especially the part about autoconf.
>>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>>> some information regarding --runstatedir which could help?
>>>
>>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>>> information, other than the quick search I did.
>>>
>>> Can't the future problem be worked around just with if autoconf version
>>> < 2.70 ?
>>
>> I don't think it is possible to add configure options other than
>> --disable-*, --enable-*, --with-* or --without-* by other means than
>> patching general.m4 of autoconf. I don't think we want to do that.
>>
>> So the possibilities are:
>>
>> 1. don't support /run instead of /var/run via configure
>> 2. patch autoconf to support --runstatedir
>> 3. take this patch adding support via --with-rundir and possibly
>>    switch over to --runstatedir when a new autoconf version is
>>    available
> 
> Option 3 but we need to have that for eternity. :-)
> 
> Wei.

Cause --runstatedir will never rear its head.... I believe I proposed
--runstatedir 3+ years ago (I can't recall how long ago) and the
maintainers said go idea we'll do a quick release with that on top of
2.69 and then work on the upcoming big release.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 1763 bytes --]

On 2/22/17 1:53 AM, Juergen Gross wrote:
> On 20/02/17 16:19, Andrew Cooper wrote:
>> On 20/02/17 14:43, Juergen Gross wrote:
>>> On 20/02/17 15:31, Wei Liu wrote:
>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>
>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>> I've read this thread but I'm not sure if I need to take any action or
>>>> all the comments addressed -- especially the part about autoconf.
>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>> some information regarding --runstatedir which could help?
>>
>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>> information, other than the quick search I did.
>>
>> Can't the future problem be worked around just with if autoconf version
>> < 2.70 ?
> 
> I don't think it is possible to add configure options other than
> --disable-*, --enable-*, --with-* or --without-* by other means than
> patching general.m4 of autoconf. I don't think we want to do that.
> 
> So the possibilities are:
> 
> 1. don't support /run instead of /var/run via configure
> 2. patch autoconf to support --runstatedir
> 3. take this patch adding support via --with-rundir and possibly
>    switch over to --runstatedir when a new autoconf version is
>    available
> 
> I'm in favor of (3.).
> 
> 
> Juergen

FWIW, many distros have already pulled the patch into their autoconf so
its available so you wouldn't really have to do anything.

Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759647
Ubuntu: 16.04 and newer have it
Gentoo: no link handy but I know its there

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 24/02/17 17:06, Doug Goldstein wrote:
> On 2/22/17 1:53 AM, Juergen Gross wrote:
>> On 20/02/17 16:19, Andrew Cooper wrote:
>>> On 20/02/17 14:43, Juergen Gross wrote:
>>>> On 20/02/17 15:31, Wei Liu wrote:
>>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>>
>>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>>> I've read this thread but I'm not sure if I need to take any action or
>>>>> all the comments addressed -- especially the part about autoconf.
>>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>>> some information regarding --runstatedir which could help?
>>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>>> information, other than the quick search I did.
>>>
>>> Can't the future problem be worked around just with if autoconf version
>>> < 2.70 ?
>> I don't think it is possible to add configure options other than
>> --disable-*, --enable-*, --with-* or --without-* by other means than
>> patching general.m4 of autoconf. I don't think we want to do that.
>>
>> So the possibilities are:
>>
>> 1. don't support /run instead of /var/run via configure
>> 2. patch autoconf to support --runstatedir
>> 3. take this patch adding support via --with-rundir and possibly
>>    switch over to --runstatedir when a new autoconf version is
>>    available
>>
>> I'm in favor of (3.).
>>
>>
>> Juergen
> FWIW, many distros have already pulled the patch into their autoconf so
> its available so you wouldn't really have to do anything.
> 
> Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759647
> Ubuntu: 16.04 and newer have it
> Gentoo: no link handy but I know its there

openSUSE: not available

I don't think its a good idea to rely on _all_ relevant distributions
having done the backport.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 2496 bytes --]

On 2/24/17 10:14 AM, Juergen Gross wrote:
> On 24/02/17 17:06, Doug Goldstein wrote:
>> On 2/22/17 1:53 AM, Juergen Gross wrote:
>>> On 20/02/17 16:19, Andrew Cooper wrote:
>>>> On 20/02/17 14:43, Juergen Gross wrote:
>>>>> On 20/02/17 15:31, Wei Liu wrote:
>>>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>>>
>>>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>>>> I've read this thread but I'm not sure if I need to take any action or
>>>>>> all the comments addressed -- especially the part about autoconf.
>>>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>>>> some information regarding --runstatedir which could help?
>>>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>>>> information, other than the quick search I did.
>>>>
>>>> Can't the future problem be worked around just with if autoconf version
>>>> < 2.70 ?
>>> I don't think it is possible to add configure options other than
>>> --disable-*, --enable-*, --with-* or --without-* by other means than
>>> patching general.m4 of autoconf. I don't think we want to do that.
>>>
>>> So the possibilities are:
>>>
>>> 1. don't support /run instead of /var/run via configure
>>> 2. patch autoconf to support --runstatedir
>>> 3. take this patch adding support via --with-rundir and possibly
>>>    switch over to --runstatedir when a new autoconf version is
>>>    available
>>>
>>> I'm in favor of (3.).
>>>
>>>
>>> Juergen
>> FWIW, many distros have already pulled the patch into their autoconf so
>> its available so you wouldn't really have to do anything.
>>
>> Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759647
>> Ubuntu: 16.04 and newer have it
>> Gentoo: no link handy but I know its there
> 
> openSUSE: not available
> 
> I don't think its a good idea to rely on _all_ relevant distributions
> having done the backport.
> 
> 
> Juergen
> 

I was under the impression that patches against the configure script are
just to the .ac file and the committer is responsible to regenerate the
configure script that's committed and its suppose to happen on a Debian
machine.

But that being said I would suggest that openSUSE pull in the patch as well.

And I'm also not trying to convince people to not go with option 3. Feel
free to ignore me as noise.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] build: add --with-rundir option to configure

[Juergen Gross]

On 24/02/17 17:49, Doug Goldstein wrote:
> On 2/24/17 10:14 AM, Juergen Gross wrote:
>> On 24/02/17 17:06, Doug Goldstein wrote:
>>> On 2/22/17 1:53 AM, Juergen Gross wrote:
>>>> On 20/02/17 16:19, Andrew Cooper wrote:
>>>>> On 20/02/17 14:43, Juergen Gross wrote:
>>>>>> On 20/02/17 15:31, Wei Liu wrote:
>>>>>>> On Thu, Feb 16, 2017 at 08:47:07AM +0100, Juergen Gross wrote:
>>>>>>>> There have been reports that Fedora 25 uses /run instead of /var/run.
>>>>>>>>
>>>>>>>> Add a --with-rundir option ito configure to be able to specify that
>>>>>>> I've read this thread but I'm not sure if I need to take any action or
>>>>>>> all the comments addressed -- especially the part about autoconf.
>>>>>> Andrew, are you fine with my answer regarding autoconf? Or do you have
>>>>>> some information regarding --runstatedir which could help?
>>>>> Oh sorry.  Didn't realise I was blocking here.  I have no specific
>>>>> information, other than the quick search I did.
>>>>>
>>>>> Can't the future problem be worked around just with if autoconf version
>>>>> < 2.70 ?
>>>> I don't think it is possible to add configure options other than
>>>> --disable-*, --enable-*, --with-* or --without-* by other means than
>>>> patching general.m4 of autoconf. I don't think we want to do that.
>>>>
>>>> So the possibilities are:
>>>>
>>>> 1. don't support /run instead of /var/run via configure
>>>> 2. patch autoconf to support --runstatedir
>>>> 3. take this patch adding support via --with-rundir and possibly
>>>>    switch over to --runstatedir when a new autoconf version is
>>>>    available
>>>>
>>>> I'm in favor of (3.).
>>>>
>>>>
>>>> Juergen
>>> FWIW, many distros have already pulled the patch into their autoconf so
>>> its available so you wouldn't really have to do anything.
>>>
>>> Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759647
>>> Ubuntu: 16.04 and newer have it
>>> Gentoo: no link handy but I know its there
>> openSUSE: not available
>>
>> I don't think its a good idea to rely on _all_ relevant distributions
>> having done the backport.
>>
>>
>> Juergen
>>
> I was under the impression that patches against the configure script are
> just to the .ac file and the committer is responsible to regenerate the
> configure script that's committed and its suppose to happen on a Debian
> machine.

The main problem is (as I already wrote) the parsing of the related
options: there is generic support for --disable-*, --enable-*, --with-*
or --without-* only.

> But that being said I would suggest that openSUSE pull in the patch as well.

And SLE (back to which version?) and ...

> And I'm also not trying to convince people to not go with option 3. Feel
> free to ignore me as noise.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel