* [PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h
@ 2017-02-16 8:42 Edward O'Callaghan
[not found] ` <20170216084256.14790-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Edward O'Callaghan @ 2017-02-16 8:42 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
We should properly prefix which kernel module this spewed
from in dmesg for consistency to the user.
Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>
---
drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
index bfdbec1..e4fad15 100644
--- a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
@@ -28,12 +28,12 @@
#include <linux/kernel.h>
#include <linux/slab.h>
-#define PP_ASSERT_WITH_CODE(cond, msg, code) \
- do { \
- if (!(cond)) { \
- printk("%s\n", msg); \
- code; \
- } \
+#define PP_ASSERT_WITH_CODE(cond, msg, code) \
+ do { \
+ if (!(cond)) { \
+ pr_error("amdgpu: %s\n", msg); \
+ code; \
+ } \
} while (0)
--
2.9.3
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h
[not found] ` <20170216084256.14790-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
@ 2017-02-18 4:38 ` Edward O'Callaghan
0 siblings, 0 replies; 2+ messages in thread
From: Edward O'Callaghan @ 2017-02-18 4:38 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
disregard this, sorry for the noise.
On 02/16/2017 07:42 PM, Edward O'Callaghan wrote:
> We should properly prefix which kernel module this spewed
> from in dmesg for consistency to the user.
>
> Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>
> ---
> drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> index bfdbec1..e4fad15 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> @@ -28,12 +28,12 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
>
> -#define PP_ASSERT_WITH_CODE(cond, msg, code) \
> - do { \
> - if (!(cond)) { \
> - printk("%s\n", msg); \
> - code; \
> - } \
> +#define PP_ASSERT_WITH_CODE(cond, msg, code) \
> + do { \
> + if (!(cond)) { \
> + pr_error("amdgpu: %s\n", msg); \
> + code; \
> + } \
> } while (0)
>
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-18 4:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 8:42 [PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h Edward O'Callaghan
[not found] ` <20170216084256.14790-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
2017-02-18 4:38 ` Edward O'Callaghan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.