* [PATCH] net: ethoc: Use eth_hw_addr_random()
@ 2017-02-16 12:54 Tobias Klauser
2017-02-17 17:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2017-02-16 12:54 UTC (permalink / raw)
To: netdev; +Cc: f.fainelli, thierry.reding, colin.king
Use eth_hw_addr_random() to set a random dev_addr and update
addr_assign_type instead of open-coding it.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethernet/ethoc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index f18aba05f1c2..23d82748f52b 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1031,7 +1031,6 @@ static int ethoc_probe(struct platform_device *pdev)
struct ethoc *priv = NULL;
int num_bd;
int ret = 0;
- bool random_mac = false;
struct ethoc_platform_data *pdata = dev_get_platdata(&pdev->dev);
u32 eth_clkfreq = pdata ? pdata->eth_clkfreq : 0;
@@ -1169,16 +1168,11 @@ static int ethoc_probe(struct platform_device *pdev)
/* Check the MAC again for validity, if it still isn't choose and
* program a random one.
*/
- if (!is_valid_ether_addr(netdev->dev_addr)) {
- eth_random_addr(netdev->dev_addr);
- random_mac = true;
- }
+ if (!is_valid_ether_addr(netdev->dev_addr))
+ eth_hw_addr_random(netdev);
ethoc_do_set_mac_address(netdev);
- if (random_mac)
- netdev->addr_assign_type = NET_ADDR_RANDOM;
-
/* Allow the platform setup code to adjust MII management bus clock. */
if (!eth_clkfreq) {
struct clk *clk = devm_clk_get(&pdev->dev, NULL);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethoc: Use eth_hw_addr_random()
2017-02-16 12:54 [PATCH] net: ethoc: Use eth_hw_addr_random() Tobias Klauser
@ 2017-02-17 17:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-17 17:42 UTC (permalink / raw)
To: tklauser; +Cc: netdev, f.fainelli, thierry.reding, colin.king
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 16 Feb 2017 13:54:32 +0100
> Use eth_hw_addr_random() to set a random dev_addr and update
> addr_assign_type instead of open-coding it.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-17 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 12:54 [PATCH] net: ethoc: Use eth_hw_addr_random() Tobias Klauser
2017-02-17 17:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.