[PATCH v2] libxl: correct xenstore entry for empty cdrom

[PATCH v2] libxl: correct xenstore entry for empty cdrom

[Juergen Gross]

Specifying an empty cdrom device will result in a Xenstore entry

params = aio:(null)

as the physical device path isn't existing. This lets a domain booted
via OVMF hang as OVMF is checking for "aio:" only in order to detect
the empty cdrom case.

Use an empty string for the physical device path in this case. As a
cdrom device for HVM is always backed by qdisk we only need to cover this
backend.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
This is a backport candidate.

V2: rebase to staging
---
 tools/libxl/libxl_disk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_disk.c b/tools/libxl/libxl_disk.c
index ac49df2..63de75c 100644
--- a/tools/libxl/libxl_disk.c
+++ b/tools/libxl/libxl_disk.c
@@ -359,7 +359,8 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid,
             case LIBXL_DISK_BACKEND_QDISK:
                 flexarray_append(back, "params");
                 flexarray_append(back, GCSPRINTF("%s:%s",
-                              libxl__device_disk_string_of_format(disk->format), disk->pdev_path));
+                              libxl__device_disk_string_of_format(disk->format),
+                              disk->pdev_path ? : ""));
                 if (libxl_defbool_val(disk->colo_enable)) {
                     flexarray_append(back, "colo-host");
                     flexarray_append(back, libxl__sprintf(gc, "%s", disk->colo_host));
-- 
2.10.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v2] libxl: correct xenstore entry for empty cdrom

[Wei Liu]

On Wed, Feb 15, 2017 at 12:11:12PM +0100, Juergen Gross wrote:
> Specifying an empty cdrom device will result in a Xenstore entry
> 
> params = aio:(null)
> 
> as the physical device path isn't existing. This lets a domain booted
> via OVMF hang as OVMF is checking for "aio:" only in order to detect
> the empty cdrom case.
> 
> Use an empty string for the physical device path in this case. As a
> cdrom device for HVM is always backed by qdisk we only need to cover this
> backend.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---

Acked + applied

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel