mtd: spi-nor: hisi-sfc compatibility report

mtd: spi-nor: hisi-sfc compatibility report

[Marty Plummer]

Greetings.

Just wanted to report that the hisi-sfc spi nor driver is compatible
with the Hi3521av100 SoC from Hisilicon. Odd that no hisilicon or huawei
emails are listed as a maintainer for it.

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marek Vasut]

On 02/15/2017 05:06 AM, Marty Plummer wrote:
> Greetings.
> 
> Just wanted to report that the hisi-sfc spi nor driver is compatible
> with the Hi3521av100 SoC from Hisilicon. Odd that no hisilicon or huawei
> emails are listed as a maintainer for it.
> 

What does scripts/get-maintainer.pl show ?

-- 
Best regards,
Marek Vasut

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marty Plummer]

On Wed, Feb 15, 2017 at 10:05:33PM +0100, Marek Vasut wrote:
> On 02/15/2017 05:06 AM, Marty Plummer wrote:
> > Greetings.
> > 
> > Just wanted to report that the hisi-sfc spi nor driver is compatible
> > with the Hi3521av100 SoC from Hisilicon. Odd that no hisilicon or huawei
> > emails are listed as a maintainer for it.
> > 
> 
> What does scripts/get-maintainer.pl show ?
> 
> -- 
> Best regards,
> Marek Vasut

Cyrille Pitchen <cyrille.pitchen@atmel.com> (maintainer:SPI NOR SUBSYSTEM)
Marek Vasut <marek.vasut@gmail.com> (maintainer:SPI NOR SUBSYSTEM)
David Woodhouse <dwmw2@infradead.org> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
Brian Norris <computersforpeace@gmail.com> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
Boris Brezillon <boris.brezillon@free-electrons.com> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
Richard Weinberger <richard@nod.at> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
linux-mtd@lists.infradead.org (open list:SPI NOR SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

^ exactly this.

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marek Vasut]

On 02/16/2017 05:28 PM, Marty Plummer wrote:
> On Wed, Feb 15, 2017 at 10:05:33PM +0100, Marek Vasut wrote:
>> On 02/15/2017 05:06 AM, Marty Plummer wrote:
>>> Greetings.
>>>
>>> Just wanted to report that the hisi-sfc spi nor driver is compatible
>>> with the Hi3521av100 SoC from Hisilicon. Odd that no hisilicon or huawei
>>> emails are listed as a maintainer for it.
>>>
>>
>> What does scripts/get-maintainer.pl show ?
>>
>> -- 
>> Best regards,
>> Marek Vasut
> 
> Cyrille Pitchen <cyrille.pitchen@atmel.com> (maintainer:SPI NOR SUBSYSTEM)
> Marek Vasut <marek.vasut@gmail.com> (maintainer:SPI NOR SUBSYSTEM)
> David Woodhouse <dwmw2@infradead.org> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
> Brian Norris <computersforpeace@gmail.com> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
> Boris Brezillon <boris.brezillon@free-electrons.com> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
> Richard Weinberger <richard@nod.at> (maintainer:MEMORY TECHNOLOGY DEVICES (MTD))
> linux-mtd@lists.infradead.org (open list:SPI NOR SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> 
> ^ exactly this.

Crap ... that's kinda surprising. I would've expected to see the two
hisilicon contributors I see in the git log to pop up there . Can you
add them and send a patch please ?

-- 
Best regards,
Marek Vasut

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marty Plummer]

On Fri, Feb 17, 2017 at 10:28:07PM +0100, Marek Vasut wrote:
> Crap ... that's kinda surprising. I would've expected to see the two
> hisilicon contributors I see in the git log to pop up there . Can you
> add them and send a patch please ?
> 
> -- 
> Best regards,
> Marek Vasut

To Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt,
then? Actual code needs no changes I can see, and works out of box.

In fact, as far as I can see, it doesn't even check for
"hisilicon,hi3519-spi-nor" at all.

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marek Vasut]

On 02/19/2017 01:48 AM, Marty Plummer wrote:
> On Fri, Feb 17, 2017 at 10:28:07PM +0100, Marek Vasut wrote:
>> Crap ... that's kinda surprising. I would've expected to see the two
>> hisilicon contributors I see in the git log to pop up there . Can you
>> add them and send a patch please ?
>>
>> -- 
>> Best regards,
>> Marek Vasut
> 
> To Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt,
> then? Actual code needs no changes I can see, and works out of box.

To MAINTAINERS , right ? Or maybe I don't quite get what your complaint
is all about.

> In fact, as far as I can see, it doesn't even check for
> "hisilicon,hi3519-spi-nor" at all.

It could be it's using DT compatible with some older SoC , but yes, if
this SoC is compatible and it is not listed in the binding document, it
should be added.

-- 
Best regards,
Marek Vasut

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marty Plummer]

On Sun, Feb 19, 2017 at 03:31:13AM +0100, Marek Vasut wrote:
> On 02/19/2017 01:48 AM, Marty Plummer wrote:
> > On Fri, Feb 17, 2017 at 10:28:07PM +0100, Marek Vasut wrote:
> >> Crap ... that's kinda surprising. I would've expected to see the two
> >> hisilicon contributors I see in the git log to pop up there . Can you
> >> add them and send a patch please ?
> >>
> >> -- 
> >> Best regards,
> >> Marek Vasut
> > 
> > To Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt,
> > then? Actual code needs no changes I can see, and works out of box.
> 
> To MAINTAINERS , right ? Or maybe I don't quite get what your complaint
> is all about.
> 
> > In fact, as far as I can see, it doesn't even check for
> > "hisilicon,hi3519-spi-nor" at all.
> 
> It could be it's using DT compatible with some older SoC , but yes, if
> this SoC is compatible and it is not listed in the binding document, it
> should be added.
> 
> -- 
> Best regards,
> Marek Vasut

Ok, got it. Will send a patch in the near future, and add whoever
get_maintainer.pl shows for arch/arm/mach-hisi

Re: mtd: spi-nor: hisi-sfc compatibility report

[Marek Vasut]

On 02/19/2017 03:51 AM, Marty Plummer wrote:
> On Sun, Feb 19, 2017 at 03:31:13AM +0100, Marek Vasut wrote:
>> On 02/19/2017 01:48 AM, Marty Plummer wrote:
>>> On Fri, Feb 17, 2017 at 10:28:07PM +0100, Marek Vasut wrote:
>>>> Crap ... that's kinda surprising. I would've expected to see the two
>>>> hisilicon contributors I see in the git log to pop up there . Can you
>>>> add them and send a patch please ?
>>>>
>>>> -- 
>>>> Best regards,
>>>> Marek Vasut
>>>
>>> To Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt,
>>> then? Actual code needs no changes I can see, and works out of box.
>>
>> To MAINTAINERS , right ? Or maybe I don't quite get what your complaint
>> is all about.
>>
>>> In fact, as far as I can see, it doesn't even check for
>>> "hisilicon,hi3519-spi-nor" at all.
>>
>> It could be it's using DT compatible with some older SoC , but yes, if
>> this SoC is compatible and it is not listed in the binding document, it
>> should be added.
>>
>> -- 
>> Best regards,
>> Marek Vasut
> 
> Ok, got it. Will send a patch in the near future, and add whoever
> get_maintainer.pl shows for arch/arm/mach-hisi

I think it'd be more sane to add the maintainers based on the git commit
log of the HISI SPI NOR driver . I think if you send a version
of the patch and CC them, you'll get some feedback on who the maintainer
of that really is :)

-- 
Best regards,
Marek Vasut