From: Mark Brown <broonie@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: oder_chiou@realtek.com, bardliao@realtek.com,
alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode
Date: Thu, 16 Feb 2017 19:13:33 +0000 [thread overview]
Message-ID: <20170216191333.ks5nvd2qk5ho6m7c@sirena.org.uk> (raw)
In-Reply-To: <CAAd53p57jLT5=uvPDm7jqvQQuuDGDhHjf=GRkPfphKg1K82HQA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]
On Thu, Feb 16, 2017 at 05:10:06AM +0000, Kai-Heng Feng wrote:
> Ping.
> Can anyone help reviewing this?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-02-16 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 5:35 [PATCH] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode Kai-Heng Feng
2017-02-16 5:10 ` Kai-Heng Feng
2017-02-16 19:13 ` Mark Brown [this message]
2017-02-16 6:53 ` Bard Liao
2017-02-16 7:15 ` Kai-Heng Feng
2017-02-16 19:22 ` Mark Brown
2017-03-13 8:41 ` Kai-Heng Feng
2017-03-13 13:30 ` Mark Brown
2017-04-18 0:02 Garrett Thornburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216191333.ks5nvd2qk5ho6m7c@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.