From: Mark Brown <broonie@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: oder_chiou@realtek.com, bardliao@realtek.com,
alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode
Date: Thu, 16 Feb 2017 19:22:30 +0000 [thread overview]
Message-ID: <20170216192230.mg6htsgqbu756e6y@sirena.org.uk> (raw)
In-Reply-To: <20170123053514.6193-1-kai.heng.feng@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]
On Mon, Jan 23, 2017 at 01:35:14PM +0800, Kai-Heng Feng wrote:
> +static void dell_dino_mute_hpo(struct snd_soc_codec *codec)
> +{
> + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE);
> +}
> +
How does this ever get unmuted, should it be an _AUTODISABLE control
instead?
> @@ -1204,6 +1261,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c,
> mdelay(10);
>
> regmap_write(rt286->regmap, RT286_MISC_CTRL1, 0x0000);
> +
> /* Power down LDO, VREF */
> regmap_update_bits(rt286->regmap, RT286_POWER_CTRL2, 0xc, 0x0);
> regmap_update_bits(rt286->regmap, RT286_POWER_CTRL1, 0x1001, 0x1001);
Random whitespace change.
> @@ -1222,6 +1280,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c,
> RT286_SET_GPIO_DATA, 0x40, 0x40);
> regmap_update_bits(rt286->regmap,
> RT286_GPIO_CTRL, 0xc, 0x8);
> + rt286->mute_hpo_func = dell_dino_mute_hpo;
> }
Why would we only do this on some machines, does this break others?
This change does appear to be two different changes merged into one,
there's the GPIO setup and this automute thing and they don't seem to
overlap AFAICT - they should be split into separate patches unless
there's some reason why they overlap but I'm not seeing that.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-02-16 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 5:35 [PATCH] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode Kai-Heng Feng
2017-02-16 5:10 ` Kai-Heng Feng
2017-02-16 19:13 ` Mark Brown
2017-02-16 6:53 ` Bard Liao
2017-02-16 7:15 ` Kai-Heng Feng
2017-02-16 19:22 ` Mark Brown [this message]
2017-03-13 8:41 ` Kai-Heng Feng
2017-03-13 13:30 ` Mark Brown
2017-04-18 0:02 Garrett Thornburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216192230.mg6htsgqbu756e6y@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.