* [PATCH] net: mvneta: make mvneta_eth_tool_ops static
@ 2017-02-16 9:07 Jisheng Zhang
2017-02-16 9:37 ` Thomas Petazzoni
2017-02-17 17:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2017-02-16 9:07 UTC (permalink / raw)
To: thomas.petazzoni, davem; +Cc: netdev, linux-kernel, Jisheng Zhang
The mvneta_eth_tool_ops is only used internally in mvneta driver, so
make it static.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index fdf71720e707..61dd4462411c 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3959,7 +3959,7 @@ static const struct net_device_ops mvneta_netdev_ops = {
.ndo_do_ioctl = mvneta_ioctl,
};
-const struct ethtool_ops mvneta_eth_tool_ops = {
+static const struct ethtool_ops mvneta_eth_tool_ops = {
.nway_reset = phy_ethtool_nway_reset,
.get_link = ethtool_op_get_link,
.set_coalesce = mvneta_ethtool_set_coalesce,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: mvneta: make mvneta_eth_tool_ops static
2017-02-16 9:07 [PATCH] net: mvneta: make mvneta_eth_tool_ops static Jisheng Zhang
@ 2017-02-16 9:37 ` Thomas Petazzoni
2017-02-17 17:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-02-16 9:37 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: davem, netdev, linux-kernel
Hello,
On Thu, 16 Feb 2017 17:07:39 +0800, Jisheng Zhang wrote:
> The mvneta_eth_tool_ops is only used internally in mvneta driver, so
> make it static.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: mvneta: make mvneta_eth_tool_ops static
2017-02-16 9:07 [PATCH] net: mvneta: make mvneta_eth_tool_ops static Jisheng Zhang
2017-02-16 9:37 ` Thomas Petazzoni
@ 2017-02-17 17:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-17 17:16 UTC (permalink / raw)
To: jszhang; +Cc: thomas.petazzoni, netdev, linux-kernel
From: Jisheng Zhang <jszhang@marvell.com>
Date: Thu, 16 Feb 2017 17:07:39 +0800
> The mvneta_eth_tool_ops is only used internally in mvneta driver, so
> make it static.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 9:07 [PATCH] net: mvneta: make mvneta_eth_tool_ops static Jisheng Zhang
2017-02-16 9:37 ` Thomas Petazzoni
2017-02-17 17:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.