All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 5/5] nvme/pci: Complete all stuck requests
Date: Fri, 17 Feb 2017 09:25:21 +0100	[thread overview]
Message-ID: <20170217082521.GB18090@lst.de> (raw)
In-Reply-To: <20170216225142.GA2227@localhost.localdomain>

On Thu, Feb 16, 2017@05:51:42PM -0500, Keith Busch wrote:
> On Thu, Feb 16, 2017@11:12:53AM +0200, Sagi Grimberg wrote:
> > 
> > I have no doubt this patch is useful, I'm just wandering if we can
> > place the functionality in a more generic location so that more
> > drivers can enjoy it.
> 
> What this is doing is too driver specific to make generically.
> 
> I think we actually want the ability to back out a request and renter
> a different hardware context, but that's too hard. :)

I don't think it's all that bad.  But I'll need to take another look
at your patch - I'd really like to see the issue fixed.  But it's just
been too complicated to easily understand so it'll take some time.

  reply	other threads:[~2017-02-17  8:25 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 23:15 [PATCH 0/5] NVMe pci fixes, for-4.11 Keith Busch
2017-02-10 23:15 ` [PATCH 1/5] nvme/pci: Disable on removal when disconnected Keith Busch
2017-02-13 10:18   ` Johannes Thumshirn
2017-02-13 13:51   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 2/5] nvme/pci: Cancel work after watchdog disabled Keith Busch
2017-02-13 10:25   ` Johannes Thumshirn
2017-02-13 13:51   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 3/5] nvme/core: Fix race kicking freed request_queue Keith Busch
2017-02-13 10:33   ` Johannes Thumshirn
2017-02-13 13:53   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 4/5] nvme/pci: No special case for queue busy on IO Keith Busch
2017-02-13 13:53   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 5/5] nvme/pci: Complete all stuck requests Keith Busch
2017-02-15  9:50   ` Sagi Grimberg
2017-02-15 15:46     ` Keith Busch
2017-02-15 16:04       ` Marc MERLIN
2017-02-15 17:36         ` J Freyensee
2017-02-16  9:12         ` Sagi Grimberg
2017-02-16 22:51           ` Keith Busch
2017-02-17  8:25             ` Christoph Hellwig [this message]
2017-02-15 18:14   ` Marc MERLIN
2017-12-14  3:36     ` Marc MERLIN
2018-02-28  2:22       ` Marc MERLIN
2017-02-17 15:27   ` Christoph Hellwig
2017-02-17 16:33     ` Keith Busch
2017-02-20 10:05       ` Christoph Hellwig
2017-02-21 15:57         ` Keith Busch
2017-02-22  7:17           ` Christoph Hellwig
2017-02-22 14:45             ` Keith Busch
2017-02-23 15:06               ` Christoph Hellwig
2017-02-23 15:21                 ` Keith Busch
2017-02-23 15:16                   ` Christoph Hellwig
2017-02-21 21:55       ` Sagi Grimberg
2017-02-21 23:26         ` Keith Busch
2017-02-15  9:40 ` [PATCH 0/5] NVMe pci fixes, for-4.11 Sagi Grimberg
     [not found] <20170313153319.fmy6ww72fjtx74xq@merlins.org>
     [not found] ` <20170313143649.GC6994@localhost.localdomain>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170217082521.GB18090@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.