From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 2/5] nvme/pci: Cancel work after watchdog disabled
Date: Mon, 13 Feb 2017 11:25:31 +0100 [thread overview]
Message-ID: <b9b0706c-a1f4-fcc3-034d-7f03bd1f90cb@suse.de> (raw)
In-Reply-To: <1486768553-13738-3-git-send-email-keith.busch@intel.com>
On 02/11/2017 12:15 AM, Keith Busch wrote:
> The driver had been flushing the work prior to uninitializing the
> controller, hoping the work would not get restarted. If controller
> failure or IO time occurs when tearing down the request queues, the
> watchdog timer may queue another reset.
>
> We want to make sure that reset work is not running to prevent use after
> free errors accessing the device being torn down, so this patch cancels
> the reset work only after we know it can never be started again.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-02-13 10:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 23:15 [PATCH 0/5] NVMe pci fixes, for-4.11 Keith Busch
2017-02-10 23:15 ` [PATCH 1/5] nvme/pci: Disable on removal when disconnected Keith Busch
2017-02-13 10:18 ` Johannes Thumshirn
2017-02-13 13:51 ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 2/5] nvme/pci: Cancel work after watchdog disabled Keith Busch
2017-02-13 10:25 ` Johannes Thumshirn [this message]
2017-02-13 13:51 ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 3/5] nvme/core: Fix race kicking freed request_queue Keith Busch
2017-02-13 10:33 ` Johannes Thumshirn
2017-02-13 13:53 ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 4/5] nvme/pci: No special case for queue busy on IO Keith Busch
2017-02-13 13:53 ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 5/5] nvme/pci: Complete all stuck requests Keith Busch
2017-02-15 9:50 ` Sagi Grimberg
2017-02-15 15:46 ` Keith Busch
2017-02-15 16:04 ` Marc MERLIN
2017-02-15 17:36 ` J Freyensee
2017-02-16 9:12 ` Sagi Grimberg
2017-02-16 22:51 ` Keith Busch
2017-02-17 8:25 ` Christoph Hellwig
2017-02-15 18:14 ` Marc MERLIN
2017-12-14 3:36 ` Marc MERLIN
2018-02-28 2:22 ` Marc MERLIN
2017-02-17 15:27 ` Christoph Hellwig
2017-02-17 16:33 ` Keith Busch
2017-02-20 10:05 ` Christoph Hellwig
2017-02-21 15:57 ` Keith Busch
2017-02-22 7:17 ` Christoph Hellwig
2017-02-22 14:45 ` Keith Busch
2017-02-23 15:06 ` Christoph Hellwig
2017-02-23 15:21 ` Keith Busch
2017-02-23 15:16 ` Christoph Hellwig
2017-02-21 21:55 ` Sagi Grimberg
2017-02-21 23:26 ` Keith Busch
2017-02-15 9:40 ` [PATCH 0/5] NVMe pci fixes, for-4.11 Sagi Grimberg
[not found] <20170313153319.fmy6ww72fjtx74xq@merlins.org>
[not found] ` <20170313143649.GC6994@localhost.localdomain>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b0706c-a1f4-fcc3-034d-7f03bd1f90cb@suse.de \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.