All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: DTS: add img directory to Makefile
@ 2017-02-16 12:33 ` Ian Pozella
  0 siblings, 0 replies; 5+ messages in thread
From: Ian Pozella @ 2017-02-16 12:33 UTC (permalink / raw)
  To: ralf, James.Hogan; +Cc: linux-mips, Ian Pozella

An img directory exists for the Pistchio Soc but the directory
itself isn't in the dts Makefile meaning the dtbs never get built.

Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
---
 arch/mips/boot/dts/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
index fc7a0a9..b9db492 100644
--- a/arch/mips/boot/dts/Makefile
+++ b/arch/mips/boot/dts/Makefile
@@ -1,5 +1,6 @@
 dts-dirs	+= brcm
 dts-dirs	+= cavium-octeon
+dts-dirs	+= img
 dts-dirs	+= ingenic
 dts-dirs	+= lantiq
 dts-dirs	+= mti
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] MIPS: DTS: add img directory to Makefile
@ 2017-02-16 12:33 ` Ian Pozella
  0 siblings, 0 replies; 5+ messages in thread
From: Ian Pozella @ 2017-02-16 12:33 UTC (permalink / raw)
  To: ralf, James.Hogan; +Cc: linux-mips, Ian Pozella

An img directory exists for the Pistchio Soc but the directory
itself isn't in the dts Makefile meaning the dtbs never get built.

Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
---
 arch/mips/boot/dts/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
index fc7a0a9..b9db492 100644
--- a/arch/mips/boot/dts/Makefile
+++ b/arch/mips/boot/dts/Makefile
@@ -1,5 +1,6 @@
 dts-dirs	+= brcm
 dts-dirs	+= cavium-octeon
+dts-dirs	+= img
 dts-dirs	+= ingenic
 dts-dirs	+= lantiq
 dts-dirs	+= mti
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: DTS: add img directory to Makefile
@ 2017-02-17  7:22   ` Rahul Bedarkar
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul Bedarkar @ 2017-02-17  7:22 UTC (permalink / raw)
  To: Ian Pozella; +Cc: ralf, James.Hogan, linux-mips

Hello,

On Thursday 16 February 2017 06:03 PM, Ian Pozella wrote:
> An img directory exists for the Pistchio Soc but the directory
> itself isn't in the dts Makefile meaning the dtbs never get built.
>
> Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
> ---
>  arch/mips/boot/dts/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
> index fc7a0a9..b9db492 100644
> --- a/arch/mips/boot/dts/Makefile
> +++ b/arch/mips/boot/dts/Makefile
> @@ -1,5 +1,6 @@
>  dts-dirs	+= brcm
>  dts-dirs	+= cavium-octeon
> +dts-dirs	+= img
>  dts-dirs	+= ingenic
>  dts-dirs	+= lantiq
>  dts-dirs	+= mti
>

Thanks for fixing this. You might want to consider adding 'Fixes' tag to 
refer to original commit that this patch fixes.

Fixes: daa10170da27 ("MIPS: DTS: img: add device tree for Marduk board")

I had tested original change with Buildroot configuration that builds 
DTS out of the tree, so failed to notice that 'img' directory needs to 
be added to Makefile.

Thanks,
Rahul

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: DTS: add img directory to Makefile
@ 2017-02-17  7:22   ` Rahul Bedarkar
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul Bedarkar @ 2017-02-17  7:22 UTC (permalink / raw)
  To: Ian Pozella; +Cc: ralf, James.Hogan, linux-mips

Hello,

On Thursday 16 February 2017 06:03 PM, Ian Pozella wrote:
> An img directory exists for the Pistchio Soc but the directory
> itself isn't in the dts Makefile meaning the dtbs never get built.
>
> Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
> ---
>  arch/mips/boot/dts/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
> index fc7a0a9..b9db492 100644
> --- a/arch/mips/boot/dts/Makefile
> +++ b/arch/mips/boot/dts/Makefile
> @@ -1,5 +1,6 @@
>  dts-dirs	+= brcm
>  dts-dirs	+= cavium-octeon
> +dts-dirs	+= img
>  dts-dirs	+= ingenic
>  dts-dirs	+= lantiq
>  dts-dirs	+= mti
>

Thanks for fixing this. You might want to consider adding 'Fixes' tag to 
refer to original commit that this patch fixes.

Fixes: daa10170da27 ("MIPS: DTS: img: add device tree for Marduk board")

I had tested original change with Buildroot configuration that builds 
DTS out of the tree, so failed to notice that 'img' directory needs to 
be added to Makefile.

Thanks,
Rahul

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: DTS: add img directory to Makefile
  2017-02-16 12:33 ` Ian Pozella
  (?)
  (?)
@ 2017-02-17 10:03 ` James Hogan
  -1 siblings, 0 replies; 5+ messages in thread
From: James Hogan @ 2017-02-17 10:03 UTC (permalink / raw)
  To: Ian Pozella; +Cc: ralf, linux-mips

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Thu, Feb 16, 2017 at 12:33:30PM +0000, Ian Pozella wrote:
> An img directory exists for the Pistchio Soc but the directory
> itself isn't in the dts Makefile meaning the dtbs never get built.
> 
> Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>

Applied

Thanks
James

> ---
>  arch/mips/boot/dts/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
> index fc7a0a9..b9db492 100644
> --- a/arch/mips/boot/dts/Makefile
> +++ b/arch/mips/boot/dts/Makefile
> @@ -1,5 +1,6 @@
>  dts-dirs	+= brcm
>  dts-dirs	+= cavium-octeon
> +dts-dirs	+= img
>  dts-dirs	+= ingenic
>  dts-dirs	+= lantiq
>  dts-dirs	+= mti
> -- 
> 2.7.4
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-17 10:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 12:33 [PATCH] MIPS: DTS: add img directory to Makefile Ian Pozella
2017-02-16 12:33 ` Ian Pozella
2017-02-17  7:22 ` Rahul Bedarkar
2017-02-17  7:22   ` Rahul Bedarkar
2017-02-17 10:03 ` James Hogan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.