From: Christoph Hellwig <hch@lst.de> To: scott.bauer@intel.com, keith.busch@intel.com, jonathan.derrick@intel.com, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: [PATCH 4/4] nvme: re-check security protocol support after reset Date: Fri, 17 Feb 2017 13:59:41 +0100 [thread overview] Message-ID: <20170217125941.14319-5-hch@lst.de> (raw) In-Reply-To: <20170217125941.14319-1-hch@lst.de> A device may change capabilities after each reset, e.g. due to a firmware upgrade. We should thus check for Security Send/Receive and OPAL support after each reset. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index ddc51adb594d..c5986850f88b 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1789,7 +1789,8 @@ static void nvme_reset_work(struct work_struct *work) if (result) goto out; - if ((dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) && !dev->ctrl.opal_dev) { + kfree(dev->ctrl.opal_dev); + if (dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) { dev->ctrl.opal_dev = init_opal_dev(&dev->ctrl, &nvme_sec_submit); } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig) Subject: [PATCH 4/4] nvme: re-check security protocol support after reset Date: Fri, 17 Feb 2017 13:59:41 +0100 [thread overview] Message-ID: <20170217125941.14319-5-hch@lst.de> (raw) In-Reply-To: <20170217125941.14319-1-hch@lst.de> A device may change capabilities after each reset, e.g. due to a firmware upgrade. We should thus check for Security Send/Receive and OPAL support after each reset. Signed-off-by: Christoph Hellwig <hch at lst.de> --- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index ddc51adb594d..c5986850f88b 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1789,7 +1789,8 @@ static void nvme_reset_work(struct work_struct *work) if (result) goto out; - if ((dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) && !dev->ctrl.opal_dev) { + kfree(dev->ctrl.opal_dev); + if (dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) { dev->ctrl.opal_dev = init_opal_dev(&dev->ctrl, &nvme_sec_submit); } -- 2.11.0
next prev parent reply other threads:[~2017-02-17 13:00 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-17 12:59 OPAL fixups Christoph Hellwig 2017-02-17 12:59 ` Christoph Hellwig 2017-02-17 12:59 ` [PATCH 1/4] block/sed-opal: tone down not supported warnings Christoph Hellwig 2017-02-17 12:59 ` Christoph Hellwig 2017-02-17 12:59 ` [PATCH 2/4] block/sed-opal: allocate struct opal_dev dynamically Christoph Hellwig 2017-02-17 12:59 ` Christoph Hellwig 2017-02-17 12:59 ` [PATCH 3/4] nvme: Check for Security send/recv support before issuing commands Christoph Hellwig 2017-02-17 12:59 ` Christoph Hellwig 2017-02-17 12:59 ` Christoph Hellwig [this message] 2017-02-17 12:59 ` [PATCH 4/4] nvme: re-check security protocol support after reset Christoph Hellwig 2017-02-17 15:26 ` Keith Busch 2017-02-17 15:26 ` Keith Busch 2017-02-17 15:41 ` Scott Bauer 2017-02-17 15:41 ` Scott Bauer 2017-02-17 17:01 ` Christoph Hellwig 2017-02-17 17:01 ` Christoph Hellwig 2017-02-17 16:55 ` Scott Bauer 2017-02-17 16:55 ` Scott Bauer 2017-02-17 17:16 ` Christoph Hellwig 2017-02-17 17:16 ` Christoph Hellwig 2017-02-17 15:27 ` OPAL fixups Keith Busch 2017-02-17 15:27 ` Keith Busch 2017-02-17 19:42 ` Jens Axboe 2017-02-17 19:42 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170217125941.14319-5-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@fb.com \ --cc=jonathan.derrick@intel.com \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=scott.bauer@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.