All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v7 0/2] staging: wlan-ng: align else if statement to coding standard
@ 2017-02-15 15:08 Maksymilian Piechota
  2017-02-15 15:11 ` [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line Maksymilian Piechota
  2017-02-15 15:14 ` [PATCH v7 2/2] staging: wlan-ng: move logical continuation at the end of line Maksymilian Piechota
  0 siblings, 2 replies; 6+ messages in thread
From: Maksymilian Piechota @ 2017-02-15 15:08 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: devel, linux-kernel

PATCHv0:

  - Spaces replaced with tabs

Maksymilian Piechota (1):
  staging: wlan-ng: This patch fixes the checkpatch.pl warning:

else if statement still did not fulfill coding standard requirements.


PATCHv2:

  - else if statement moved to single line

Maksymilian Piechota (1):
  staging: wlan-ng: This patch fixes the checkpatch.pl warning:

Subject was not precise.

PATCHv3:

  - Subject is more precise
  - Changelog text describe every change  

Maksymilian Piechota (1):
  staging: lustre: align else if statement to coding standard

Too much changes for one patch.

PATCHv4:
  
  - Previous patch breaked up to particular patches for every change

Maksymilian Piechota (2):
  staging: lustre: move logical continuations at the end of line
  staging: lustre: move else if statement to a single line

Continuation of the statement should be realigned

PATCHv5:

  - Wrong prefixes in commits and patches titles changed
  - Else if continuation realigned 

Maksymilian Piechota (3):
  staging: wlan-ng: move logical continuations at the end of line
  staging: wlan-ng: move else if statement to a single line
  staging: wlan-ng: realign else if continuation

Lack of patches history. No changelog text for particular patches

PATCHv6:

  - changelog text for patches added
  - patches history added

Maksymilian Piechota (3):
  staging: wlan-ng: move logical continuations at the end of line
  staging: wlan-ng: move else if statement to a single line
  staging: wlan-ng: realign else if continuation

Checkpatch errors appears between patches.

PATCHv7:

  - Changes made from scratch
  - else if statement moved to a single line
  - logical continuation moved at the end of line

Maksymilian Piechota (2):
  staging: wlan-ng: move else if statement to a single line
  staging: wlan-ng: move logical continuation at the end of line

 drivers/staging/wlan-ng/prism2mgmt.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
  2017-02-15 15:08 [PATCH v7 0/2] staging: wlan-ng: align else if statement to coding standard Maksymilian Piechota
@ 2017-02-15 15:11 ` Maksymilian Piechota
  2017-02-16 18:27   ` Greg Kroah-Hartman
  2017-02-15 15:14 ` [PATCH v7 2/2] staging: wlan-ng: move logical continuation at the end of line Maksymilian Piechota
  1 sibling, 1 reply; 6+ messages in thread
From: Maksymilian Piechota @ 2017-02-15 15:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Maksymilian Piechota, devel, linux-kernel

move else if statement to a single line

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 16fb2d3..a45ff00 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
-		} else
-		    if ((msg->wlanheader.status ==
+		} else if ((msg->wlanheader.status ==
 			 P80211ENUM_msgitem_status_data_ok)
 			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v7 2/2] staging: wlan-ng: move logical continuation at the end of line
  2017-02-15 15:08 [PATCH v7 0/2] staging: wlan-ng: align else if statement to coding standard Maksymilian Piechota
  2017-02-15 15:11 ` [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line Maksymilian Piechota
@ 2017-02-15 15:14 ` Maksymilian Piechota
  1 sibling, 0 replies; 6+ messages in thread
From: Maksymilian Piechota @ 2017-02-15 15:14 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Maksymilian Piechota

move logical continuations at the end of line

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index a45ff00..1cc6c9a 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1308,8 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else if ((msg->wlanheader.status ==
-			 P80211ENUM_msgitem_status_data_ok)
-			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
+			   P80211ENUM_msgitem_status_data_ok) &&
+			   (msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
  2017-02-15 15:11 ` [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line Maksymilian Piechota
@ 2017-02-16 18:27   ` Greg Kroah-Hartman
  2017-02-17 14:33     ` Maksymilian Piechota
  0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-16 18:27 UTC (permalink / raw)
  To: Maksymilian Piechota; +Cc: devel, linux-kernel

On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote:
> move else if statement to a single line
> 
> Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 16fb2d3..a45ff00 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
>  			hw->sniffhdr = 0;
>  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> -		} else
> -		    if ((msg->wlanheader.status ==
> +		} else if ((msg->wlanheader.status ==
>  			 P80211ENUM_msgitem_status_data_ok)
>  			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
>  			hw->sniffhdr = 1;

This patch does not apply to my tree at all :(

Please rebase and resend the series.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
  2017-02-16 18:27   ` Greg Kroah-Hartman
@ 2017-02-17 14:33     ` Maksymilian Piechota
  2017-02-24 16:33       ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Maksymilian Piechota @ 2017-02-17 14:33 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Maksymilian Piechota, devel, linux-kernel

On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote:
> > move else if statement to a single line
> > 
> > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > index 16fb2d3..a45ff00 100644
> > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> >  		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
> >  			hw->sniffhdr = 0;
> >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > -		} else
> > -		    if ((msg->wlanheader.status ==
> > +		} else if ((msg->wlanheader.status ==
> >  			 P80211ENUM_msgitem_status_data_ok)
> >  			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> >  			hw->sniffhdr = 1;
> 
> This patch does not apply to my tree at all :(
> 
> Please rebase and resend the series.
> 
> thanks,
> 
> greg k-h

ok, I've got newest sources and this change is already applied. So what
are the next steps suggested? I've heard there is a possibility to
obtain mentor, right?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
  2017-02-17 14:33     ` Maksymilian Piechota
@ 2017-02-24 16:33       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-24 16:33 UTC (permalink / raw)
  To: Maksymilian Piechota; +Cc: devel, linux-kernel

On Fri, Feb 17, 2017 at 09:33:01AM -0500, Maksymilian Piechota wrote:
> On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote:
> > > move else if statement to a single line
> > > 
> > > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > > ---
> > >  drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > > index 16fb2d3..a45ff00 100644
> > > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > > @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> > >  		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 0;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > > -		} else
> > > -		    if ((msg->wlanheader.status ==
> > > +		} else if ((msg->wlanheader.status ==
> > >  			 P80211ENUM_msgitem_status_data_ok)
> > >  			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 1;
> > 
> > This patch does not apply to my tree at all :(
> > 
> > Please rebase and resend the series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> ok, I've got newest sources and this change is already applied. So what
> are the next steps suggested?

Suggested for what?

> I've heard there is a possibility to obtain mentor, right?

Mentor for what?

confused,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-24 16:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-15 15:08 [PATCH v7 0/2] staging: wlan-ng: align else if statement to coding standard Maksymilian Piechota
2017-02-15 15:11 ` [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line Maksymilian Piechota
2017-02-16 18:27   ` Greg Kroah-Hartman
2017-02-17 14:33     ` Maksymilian Piechota
2017-02-24 16:33       ` Greg Kroah-Hartman
2017-02-15 15:14 ` [PATCH v7 2/2] staging: wlan-ng: move logical continuation at the end of line Maksymilian Piechota

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.