* [PATCH] staging: ks7010: Block comments use * on subsequent lines
@ 2017-02-18 15:32 Arushi Singhal
2017-02-24 17:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Arushi Singhal @ 2017-02-18 15:32 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, outreachy-kernel
Some of the block comments styles are not encouraged:
for example:
/*
block comment without introductory *
*/
and
/*
* block comment with line terminating */
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/ks7010/ks7010_sdio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index a604c83c957e..2c263f98bdbb 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work)
/* wiat after WAKEUP */
while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
DPRINTK(4, "wait after WAKEUP\n");
-/* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
- (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
+/*
+ * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
+ * (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
+ */
dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
"wake: %lu %lu\n",
priv->last_wakeup + (30 * HZ) / 1000,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: ks7010: Block comments use * on subsequent lines
2017-02-18 15:32 [PATCH] staging: ks7010: Block comments use * on subsequent lines Arushi Singhal
@ 2017-02-24 17:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-24 17:08 UTC (permalink / raw)
To: Arushi Singhal; +Cc: devel, linux-kernel, outreachy-kernel
On Sat, Feb 18, 2017 at 09:02:33PM +0530, Arushi Singhal wrote:
> Some of the block comments styles are not encouraged:
> for example:
> /*
> block comment without introductory *
> */
> and
> /*
> * block comment with line terminating */
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index a604c83c957e..2c263f98bdbb 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work)
> /* wiat after WAKEUP */
> while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
> DPRINTK(4, "wait after WAKEUP\n");
> -/* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> - (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
> +/*
> + * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> + * (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
> + */
Why did you loose the correct indentation here when you commented this
out?
If it's commented out, why not just delete the code instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-24 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-18 15:32 [PATCH] staging: ks7010: Block comments use * on subsequent lines Arushi Singhal
2017-02-24 17:08 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.