[PATCH nf-next] netfilter: nfnetlink: remove static declaration from err_list

[PATCH nf-next] netfilter: nfnetlink: remove static declaration from err_list

[Liping Zhang]

From: Liping Zhang <zlpnobody@gmail.com>

Otherwise, different subsys will race to access the err_list, with holding
the different nfnl_lock(subsys_id).

But this will not happen now, since ->call_batch is only implemented by
nftables, so the err_list is protected by nfnl_lock(NFNL_SUBSYS_NFTABLES).

Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
---
 net/netfilter/nfnetlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index a2148d0..68eda920 100644
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -279,7 +279,7 @@ static void nfnetlink_rcv_batch(struct sk_buff *skb, struct nlmsghdr *nlh,
 	struct net *net = sock_net(skb->sk);
 	const struct nfnetlink_subsystem *ss;
 	const struct nfnl_callback *nc;
-	static LIST_HEAD(err_list);
+	LIST_HEAD(err_list);
 	u32 status;
 	int err;
 
-- 
2.5.5

Re: [PATCH nf-next] netfilter: nfnetlink: remove static declaration from err_list

[Pablo Neira Ayuso]

On Sat, Feb 18, 2017 at 10:35:47AM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
> 
> Otherwise, different subsys will race to access the err_list, with holding
> the different nfnl_lock(subsys_id).
> 
> But this will not happen now, since ->call_batch is only implemented by
> nftables, so the err_list is protected by nfnl_lock(NFNL_SUBSYS_NFTABLES).

Good catch, applied, thanks.