[PATCH] powerpc/powernv: Make PCI non-optional

[PATCH] powerpc/powernv: Make PCI non-optional

[Michael Ellerman]

Bare metal systems without PCI don't exist, so there's no real point in
making PCI optional, it just breaks the build from time to time. In fact
the build is broken now if you turn off PCI_MSI but enable KVM.

Using select for PCI is OK because we (powerpc) define config PCI, and it
has no dependencies. Selecting PCI_MSI is slightly fishy, because it's
in drivers/pci and it is user-visible, but its only dependency is PCI,
so selecting it can't actually lead to breakage.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/platforms/powernv/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
index 604190cab522..3a07e4dcf97c 100644
--- a/arch/powerpc/platforms/powernv/Kconfig
+++ b/arch/powerpc/platforms/powernv/Kconfig
@@ -5,7 +5,8 @@ config PPC_POWERNV
 	select PPC_XICS
 	select PPC_ICP_NATIVE
 	select PPC_P7_NAP
-	select PPC_PCI_CHOICE if EMBEDDED
+	select PCI
+	select PCI_MSI
 	select EPAPR_BOOT
 	select PPC_INDIRECT_PIO
 	select PPC_UDBG_16550
-- 
2.7.4

Re: [PATCH] powerpc/powernv: Make PCI non-optional

[Gavin Shan]

On Fri, Feb 17, 2017 at 05:34:13PM +1100, Michael Ellerman wrote:
>Bare metal systems without PCI don't exist, so there's no real point in
>making PCI optional, it just breaks the build from time to time. In fact
>the build is broken now if you turn off PCI_MSI but enable KVM.
>
>Using select for PCI is OK because we (powerpc) define config PCI, and it
>has no dependencies. Selecting PCI_MSI is slightly fishy, because it's
>in drivers/pci and it is user-visible, but its only dependency is PCI,
>so selecting it can't actually lead to breakage.
>
>Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

Re: powerpc/powernv: Make PCI non-optional

[Michael Ellerman]

On Fri, 2017-02-17 at 06:34:13 UTC, Michael Ellerman wrote:
> Bare metal systems without PCI don't exist, so there's no real point in
> making PCI optional, it just breaks the build from time to time. In fact
> the build is broken now if you turn off PCI_MSI but enable KVM.
> 
> Using select for PCI is OK because we (powerpc) define config PCI, and it
> has no dependencies. Selecting PCI_MSI is slightly fishy, because it's
> in drivers/pci and it is user-visible, but its only dependency is PCI,
> so selecting it can't actually lead to breakage.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/a311e738b6d81febae21f0447c5b31

cheers