All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Elena Reshetova <elena.reshetova@intel.com>,
	linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	x86@kernel.org, sparclinux@vger.kernel.org,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	gregkh@linuxfoundation.org, davem@davemloft.net,
	tglx@linutronix.de, mingo@redhat.com, tony.luck@intel.com,
	hpa@zytor.com, Hans Liljestrand <ishkamiel@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t
Date: Mon, 20 Feb 2017 14:39:14 +0100	[thread overview]
Message-ID: <20170220133914.GQ6500@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170220132424.GA5656@osiris>

On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote:
> On Mon, Feb 20, 2017 at 01:06:18PM +0200, Elena Reshetova wrote:

> > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, int nr_areas,
> >          debug_area_last = rc;
> >          rc->next = NULL;
> >  
> > -	debug_info_get(rc);
> > +	refcount_set(&rc->ref_count, 1);
> 
> This is not wrong, but I will remove this hunk before applying your patch,
> since this doesn't look like an obvious correct change at first glance.

I suspect; but have not looked at the code; that this would otherwise
attempt to do a 0 -> 1 increment, which refcount_inc() will refuse (and
WARN) over.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Elena Reshetova <elena.reshetova@intel.com>,
	linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	x86@kernel.org, sparclinux@vger.kernel.org,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	gregkh@linuxfoundation.org, davem@davemloft.net,
	tglx@linutronix.de, mingo@redhat.com, tony.luck@intel.com,
	hpa@zytor.com, Hans Liljestrand <ishkamiel@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t
Date: Mon, 20 Feb 2017 13:39:14 +0000	[thread overview]
Message-ID: <20170220133914.GQ6500@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170220132424.GA5656@osiris>

On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote:
> On Mon, Feb 20, 2017 at 01:06:18PM +0200, Elena Reshetova wrote:

> > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, int nr_areas,
> >          debug_area_last = rc;
> >          rc->next = NULL;
> >  
> > -	debug_info_get(rc);
> > +	refcount_set(&rc->ref_count, 1);
> 
> This is not wrong, but I will remove this hunk before applying your patch,
> since this doesn't look like an obvious correct change at first glance.

I suspect; but have not looked at the code; that this would otherwise
attempt to do a 0 -> 1 increment, which refcount_inc() will refuse (and
WARN) over.



  parent reply	other threads:[~2017-02-20 13:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 11:06 [PATCH 0/4] arch subsystem refcounter conversions Elena Reshetova
2017-02-20 11:06 ` Elena Reshetova
2017-02-20 11:06 ` [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t Elena Reshetova
2017-02-20 11:06   ` Elena Reshetova
2017-02-20 13:24   ` Heiko Carstens
2017-02-20 13:24     ` Heiko Carstens
2017-02-20 13:34     ` Heiko Carstens
2017-02-20 13:34       ` Heiko Carstens
2017-02-20 13:35     ` Reshetova, Elena
2017-02-20 13:39     ` Peter Zijlstra [this message]
2017-02-20 13:39       ` Peter Zijlstra
2017-02-20 11:06 ` [PATCH 2/4] x86: convert threshold_bank.cpus " Elena Reshetova
2017-02-20 11:06   ` Elena Reshetova
2017-02-20 11:17   ` Borislav Petkov
2017-02-20 11:17     ` Borislav Petkov
2017-02-20 12:20     ` Reshetova, Elena
2017-02-20 12:20       ` Reshetova, Elena
2017-02-20 12:30       ` Borislav Petkov
2017-02-20 12:30         ` Borislav Petkov
2017-02-21 20:45     ` Kees Cook
2017-02-21 20:45       ` Kees Cook
2017-02-22  9:27       ` Borislav Petkov
2017-02-22  9:27         ` Borislav Petkov
2017-02-20 11:06 ` [PATCH 3/4] sparc: convert mdesc_handle.refcnt " Elena Reshetova
2017-02-20 11:06   ` Elena Reshetova
2017-02-20 14:56   ` David Miller
2017-02-20 14:56     ` David Miller
2017-04-03  7:28     ` Reshetova, Elena
2017-04-03  7:28       ` Reshetova, Elena
2017-04-03 13:12       ` David Miller
2017-04-03 13:12         ` David Miller
2017-04-03 16:06         ` Reshetova, Elena
2017-04-03 16:06           ` Reshetova, Elena
2017-04-03 16:16           ` David Miller
2017-04-03 16:16             ` David Miller
2017-02-20 11:06 ` [PATCH 4/4] kvm: convert kvm.users_count " Elena Reshetova
2017-02-20 11:06   ` Elena Reshetova
2017-02-20 11:37   ` Paolo Bonzini
2017-02-20 11:37     ` Paolo Bonzini
2017-02-20 12:22     ` Reshetova, Elena
2017-02-20 12:22       ` Reshetova, Elena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220133914.GQ6500@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=davem@davemloft.net \
    --cc=dwindsor@gmail.com \
    --cc=elena.reshetova@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=ishkamiel@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.