* [PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec
@ 2017-02-20 16:20 ` codekipper at gmail.com
0 siblings, 0 replies; 4+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2017-02-20 16:20 UTC (permalink / raw)
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper
From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
The Orange Pi 2 routes the LINEOUT pins through a SGM8900 PA which
needs to be enabled. The onboard microphone is routed to MIC1, with
MBIAS providing power.
Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
index 047e9e1c6093..b0d2b99990cc 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
@@ -105,6 +105,16 @@
};
};
+&codec {
+ pinctrl-0 = <&codec_pa_pin>;
+ allwinner,pa-gpios = <&pio 0 16 GPIO_ACTIVE_HIGH>; /* PA16 */
+ allwinner,audio-routing =
+ "Speaker", "LINEOUT",
+ "MIC1", "Mic",
+ "Mic", "MBIAS";
+ status = "okay";
+};
+
&ehci1 {
status = "okay";
};
@@ -144,6 +154,11 @@
};
&pio {
+ codec_pa_pin: codec_pa_pin@0 {
+ pins = "PA16";
+ function = "gpio_out";
+ };
+
leds_opc: led_pins@0 {
pins = "PA15";
function = "gpio_out";
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec
@ 2017-02-20 16:20 ` codekipper at gmail.com
0 siblings, 0 replies; 4+ messages in thread
From: codekipper at gmail.com @ 2017-02-20 16:20 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcus Cooper <codekipper@gmail.com>
The Orange Pi 2 routes the LINEOUT pins through a SGM8900 PA which
needs to be enabled. The onboard microphone is routed to MIC1, with
MBIAS providing power.
Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
index 047e9e1c6093..b0d2b99990cc 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
@@ -105,6 +105,16 @@
};
};
+&codec {
+ pinctrl-0 = <&codec_pa_pin>;
+ allwinner,pa-gpios = <&pio 0 16 GPIO_ACTIVE_HIGH>; /* PA16 */
+ allwinner,audio-routing =
+ "Speaker", "LINEOUT",
+ "MIC1", "Mic",
+ "Mic", "MBIAS";
+ status = "okay";
+};
+
&ehci1 {
status = "okay";
};
@@ -144,6 +154,11 @@
};
&pio {
+ codec_pa_pin: codec_pa_pin at 0 {
+ pins = "PA16";
+ function = "gpio_out";
+ };
+
leds_opc: led_pins at 0 {
pins = "PA15";
function = "gpio_out";
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [linux-sunxi][PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec
2017-02-20 16:20 ` [linux-sunxi][PATCH] " codekipper at gmail.com
@ 2017-02-20 21:57 ` Rask Ingemann Lambertsen
-1 siblings, 0 replies; 4+ messages in thread
From: Rask Ingemann Lambertsen @ 2017-02-20 21:57 UTC (permalink / raw)
To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Feb 20, 2017 at 05:20:52PM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> The Orange Pi 2 routes the LINEOUT pins through a SGM8900 PA which
> needs to be enabled. The onboard microphone is routed to MIC1, with
> MBIAS providing power.
>
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> index 047e9e1c6093..b0d2b99990cc 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> @@ -105,6 +105,16 @@
> };
> };
>
> +&codec {
> + pinctrl-0 = <&codec_pa_pin>;
> + allwinner,pa-gpios = <&pio 0 16 GPIO_ACTIVE_HIGH>; /* PA16 */
> + allwinner,audio-routing =
> + "Speaker", "LINEOUT",
> + "MIC1", "Mic",
> + "Mic", "MBIAS";
> + status = "okay";
> +};
> +
> &ehci1 {
> status = "okay";
> };
> @@ -144,6 +154,11 @@
> };
>
> &pio {
> + codec_pa_pin: codec_pa_pin@0 {
> + pins = "PA16";
> + function = "gpio_out";
> + };
> +
There should not be underscores in node names. See e.g.:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html
Pinmux nodes for GPIO usage are considered unnecessary or even harmful
these days, so you should just drop the node in this case (as well as the
reference to it). As a bonus, you avoid a duplicate definition.
--
Rask Ingemann Lambertsen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec
@ 2017-02-20 21:57 ` Rask Ingemann Lambertsen
0 siblings, 0 replies; 4+ messages in thread
From: Rask Ingemann Lambertsen @ 2017-02-20 21:57 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 20, 2017 at 05:20:52PM +0100, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> The Orange Pi 2 routes the LINEOUT pins through a SGM8900 PA which
> needs to be enabled. The onboard microphone is routed to MIC1, with
> MBIAS providing power.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> index 047e9e1c6093..b0d2b99990cc 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
> @@ -105,6 +105,16 @@
> };
> };
>
> +&codec {
> + pinctrl-0 = <&codec_pa_pin>;
> + allwinner,pa-gpios = <&pio 0 16 GPIO_ACTIVE_HIGH>; /* PA16 */
> + allwinner,audio-routing =
> + "Speaker", "LINEOUT",
> + "MIC1", "Mic",
> + "Mic", "MBIAS";
> + status = "okay";
> +};
> +
> &ehci1 {
> status = "okay";
> };
> @@ -144,6 +154,11 @@
> };
>
> &pio {
> + codec_pa_pin: codec_pa_pin at 0 {
> + pins = "PA16";
> + function = "gpio_out";
> + };
> +
There should not be underscores in node names. See e.g.:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html
Pinmux nodes for GPIO usage are considered unnecessary or even harmful
these days, so you should just drop the node in this case (as well as the
reference to it). As a bonus, you avoid a duplicate definition.
--
Rask Ingemann Lambertsen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-20 21:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-20 16:20 [PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-02-20 16:20 ` [linux-sunxi][PATCH] " codekipper at gmail.com
[not found] ` <20170220162052.21932-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-20 21:57 ` Rask Ingemann Lambertsen
2017-02-20 21:57 ` Rask Ingemann Lambertsen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.