All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Jiri Olsa <jolsa@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCHv2 4/5] perf stat: Add -a as a default target
Date: Mon, 20 Feb 2017 18:22:54 -0300	[thread overview]
Message-ID: <20170220212254.GC4071@kernel.org> (raw)
In-Reply-To: <20170220203149.yxietgdzi5lxdk5n@pd.tnic>

Em Mon, Feb 20, 2017 at 09:31:49PM +0100, Borislav Petkov escreveu:
> Btw, I received your mail just now - probably greylisting...
> 
> On Mon, Feb 20, 2017 at 10:44:33AM -0300, Arnaldo Carvalho de Melo wrote:
> > Isn't this confusing, i.e. people runnin 'tool workload' can be lead to
> > think that the events reported took place just when the workload was
> > running, i.e. on the same cpu and while it was being scheduled?
> 
> That's a good point.
> 
> > I understand the desire to avoid asking people to use -a, i.e. if it
> > only makes sense as system wide, hey, do it as system wide, but can't
> > this be confusing?
> 
> Well, I did
> 
> tool workload
> 
> and it said <not supported>. Now, if I'm the only one to stare puzzled

Well, this one should be read (and written in the tool output as):

<not supported in workload only mode, try system wide, using -a>

> at this and wonder why it says "not supported", then sure, I know now
> that I should use -a.
> 
> But if other users are as confused as me, you probably want to tell them
> to try -a too, no?
> 
> IOW, we probably could extend my other patch which says that people
> should try to disable the HW NMI watchdog to say "try using -a for
> uncore-only events" when it detects <not supported>.

Right, the ENOTSUPP in this case needs to be properly expanded into
something meaningful, as suggested above.

> 
> Thoughts?
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2017-02-20 21:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 14:00 [PATCH 0/5] perf tools: Few fixes Jiri Olsa
2017-02-17 14:00 ` [PATCH 1/5] perf build: Add special fixdep cleaning rule Jiri Olsa
2017-02-21  8:13   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 2/5] perf tools: Move new_term arguments into struct parse_events_term template Jiri Olsa
2017-02-21  8:13   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 3/5] perf tools: Fail on using multiple bits long terms without value Jiri Olsa
2017-02-21  8:14   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 4/5] perf stat: Add -a as a default target Jiri Olsa
2017-02-17 14:27   ` Arnaldo Carvalho de Melo
2017-02-17 14:33     ` Jiri Olsa
2017-02-17 14:41       ` Arnaldo Carvalho de Melo
2017-02-17 14:43         ` Jiri Olsa
2017-02-17 17:00         ` [PATCHv2 " Jiri Olsa
2017-02-17 17:48           ` Boris Petkov
2017-02-18 17:52             ` Borislav Petkov
2017-02-20  7:13               ` Jiri Olsa
     [not found]                 ` <20170220134433.GI4109@kernel.org>
2017-02-20 20:31                   ` Borislav Petkov
2017-02-20 21:22                     ` Arnaldo Carvalho de Melo [this message]
2017-02-20 22:47                       ` Borislav Petkov
2017-02-21  7:54                         ` Jiri Olsa
2017-02-21 11:04                           ` Jiri Olsa
2017-02-21 11:20                             ` Borislav Petkov
2017-02-21 13:34                               ` Arnaldo Carvalho de Melo
2017-02-21 14:05                                 ` Borislav Petkov
2017-02-21 14:20                                   ` Arnaldo Carvalho de Melo
2017-02-21  8:14           ` [tip:perf/urgent] perf stat: Add -a as " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 5/5] perf record: Add -a as a " Jiri Olsa
2017-02-17 14:28   ` Arnaldo Carvalho de Melo
2017-02-17 17:00     ` Jiri Olsa
2017-02-21  8:15       ` [tip:perf/urgent] perf record: Add -a as " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220212254.GC4071@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bp@alien8.de \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.