From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Jiri Olsa <jolsa@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCHv2 4/5] perf stat: Add -a as a default target
Date: Tue, 21 Feb 2017 11:20:16 -0300 [thread overview]
Message-ID: <20170221142016.GD5052@kernel.org> (raw)
In-Reply-To: <20170221140544.mg7dbymp5w6lq7o7@pd.tnic>
Em Tue, Feb 21, 2017 at 03:05:44PM +0100, Borislav Petkov escreveu:
> On Tue, Feb 21, 2017 at 10:34:26AM -0300, Arnaldo Carvalho de Melo wrote:
> > It _is_ supported by the kernel, and by the hardware, its just that it
> > is not supported in system wide mode, that BTW, in the case above, the
> > user doesn't even asked for (-a wasn't in the command line).
>
> Well, that warning is issued for a bunch of errno's. Lumping them all
> together is probably not what you want.
>
> Also, EINVAL for example, as I noted earlier, can be issued for a
> variety of conditions...
That is well understood, but it doesn't prevents us from trying to, with
the context in mind, disambiguate that value into meaningful messages,
that ends up being possible to a great degree, see, for instance:
perf_evsel__open_strerror()
It will take the errno and internal evsel state to try to provide a
better error message. So, if it is a uncore event and it the error
when trying to open it is EINVAL and it evsel->system_wide is not set...
- Arnaldo
next prev parent reply other threads:[~2017-02-21 14:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 14:00 [PATCH 0/5] perf tools: Few fixes Jiri Olsa
2017-02-17 14:00 ` [PATCH 1/5] perf build: Add special fixdep cleaning rule Jiri Olsa
2017-02-21 8:13 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 2/5] perf tools: Move new_term arguments into struct parse_events_term template Jiri Olsa
2017-02-21 8:13 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 3/5] perf tools: Fail on using multiple bits long terms without value Jiri Olsa
2017-02-21 8:14 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 4/5] perf stat: Add -a as a default target Jiri Olsa
2017-02-17 14:27 ` Arnaldo Carvalho de Melo
2017-02-17 14:33 ` Jiri Olsa
2017-02-17 14:41 ` Arnaldo Carvalho de Melo
2017-02-17 14:43 ` Jiri Olsa
2017-02-17 17:00 ` [PATCHv2 " Jiri Olsa
2017-02-17 17:48 ` Boris Petkov
2017-02-18 17:52 ` Borislav Petkov
2017-02-20 7:13 ` Jiri Olsa
[not found] ` <20170220134433.GI4109@kernel.org>
2017-02-20 20:31 ` Borislav Petkov
2017-02-20 21:22 ` Arnaldo Carvalho de Melo
2017-02-20 22:47 ` Borislav Petkov
2017-02-21 7:54 ` Jiri Olsa
2017-02-21 11:04 ` Jiri Olsa
2017-02-21 11:20 ` Borislav Petkov
2017-02-21 13:34 ` Arnaldo Carvalho de Melo
2017-02-21 14:05 ` Borislav Petkov
2017-02-21 14:20 ` Arnaldo Carvalho de Melo [this message]
2017-02-21 8:14 ` [tip:perf/urgent] perf stat: Add -a as " tip-bot for Jiri Olsa
2017-02-17 14:00 ` [PATCH 5/5] perf record: Add -a as a " Jiri Olsa
2017-02-17 14:28 ` Arnaldo Carvalho de Melo
2017-02-17 17:00 ` Jiri Olsa
2017-02-21 8:15 ` [tip:perf/urgent] perf record: Add -a as " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221142016.GD5052@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.