* [Buildroot] [git commit] package/sunxi-mali: reorder select/depends
@ 2017-02-20 21:47 Thomas Petazzoni
0 siblings, 0 replies; only message in thread
From: Thomas Petazzoni @ 2017-02-20 21:47 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=2e19aad44adb6951932446bda007d76af2227e04
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."
Also, the Config.in example in the manual suggests to use this coding
style [2].
[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] https://buildroot.org/downloads/manual/manual.html#writing-rules-config-in
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/sunxi-mali/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/sunxi-mali/Config.in b/package/sunxi-mali/Config.in
index 5e3ae4c..c6754c2 100644
--- a/package/sunxi-mali/Config.in
+++ b/package/sunxi-mali/Config.in
@@ -1,10 +1,10 @@
config BR2_PACKAGE_SUNXI_MALI
bool "sunxi-mali"
+ depends on BR2_arm
+ depends on BR2_TOOLCHAIN_USES_GLIBC
select BR2_PACKAGE_HAS_LIBEGL
select BR2_PACKAGE_HAS_LIBGLES
select BR2_PACKAGE_LIBUMP
- depends on BR2_TOOLCHAIN_USES_GLIBC
- depends on BR2_arm
help
Install the ARM Mali drivers for sunxi based systems (i.e
systems based on ARM Allwinner SoCs). This driver requires
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-20 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-20 21:47 [Buildroot] [git commit] package/sunxi-mali: reorder select/depends Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.