All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH iproute2] tc: flower: Fix parsing ip address
@ 2017-02-22 14:05 Roi Dayan
  2017-02-22 15:16 ` Simon Horman
  2017-02-23 17:01 ` Stephen Hemminger
  0 siblings, 2 replies; 3+ messages in thread
From: Roi Dayan @ 2017-02-22 14:05 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: netdev, Paul Blakey, Or Gerlitz, Hadar Hen Zion, Shahar Klein,
	Mark Bloch, Simon Horman, Jiri Pirko, Roi Dayan

Fix order of arguments when passed to __flower_parse_ip_addr.

Fixes: ("f888f4e20534 tc: flower: Support matching ARP")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
---
 tc/f_flower.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tc/f_flower.c b/tc/f_flower.c
index 6bd03f2..5aac4a0 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -289,8 +289,8 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type,
 		return -1;
 	}
 
-	return __flower_parse_ip_addr(str, family, addr4_type, addr6_type,
-				      mask4_type, mask6_type, n);
+	return __flower_parse_ip_addr(str, family, addr4_type, mask4_type,
+				      addr6_type, mask6_type, n);
 }
 
 static bool flower_eth_type_arp(__be16 eth_type)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] tc: flower: Fix parsing ip address
  2017-02-22 14:05 [PATCH iproute2] tc: flower: Fix parsing ip address Roi Dayan
@ 2017-02-22 15:16 ` Simon Horman
  2017-02-23 17:01 ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2017-02-22 15:16 UTC (permalink / raw)
  To: Roi Dayan
  Cc: Stephen Hemminger, netdev, Paul Blakey, Or Gerlitz,
	Hadar Hen Zion, Shahar Klein, Mark Bloch, Jiri Pirko

On Wed, Feb 22, 2017 at 04:05:01PM +0200, Roi Dayan wrote:
> Fix order of arguments when passed to __flower_parse_ip_addr.
> 
> Fixes: ("f888f4e20534 tc: flower: Support matching ARP")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Reviewed-by: Paul Blakey <paulb@mellanox.com>

Reviewed-by: Simon Horman <simon.horman@netronome.com>

> ---
>  tc/f_flower.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 6bd03f2..5aac4a0 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -289,8 +289,8 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type,
>  		return -1;
>  	}
>  
> -	return __flower_parse_ip_addr(str, family, addr4_type, addr6_type,
> -				      mask4_type, mask6_type, n);
> +	return __flower_parse_ip_addr(str, family, addr4_type, mask4_type,
> +				      addr6_type, mask6_type, n);
>  }
>  
>  static bool flower_eth_type_arp(__be16 eth_type)
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] tc: flower: Fix parsing ip address
  2017-02-22 14:05 [PATCH iproute2] tc: flower: Fix parsing ip address Roi Dayan
  2017-02-22 15:16 ` Simon Horman
@ 2017-02-23 17:01 ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-02-23 17:01 UTC (permalink / raw)
  To: Roi Dayan
  Cc: netdev, Paul Blakey, Or Gerlitz, Hadar Hen Zion, Shahar Klein,
	Mark Bloch, Simon Horman, Jiri Pirko

On Wed, 22 Feb 2017 16:05:01 +0200
Roi Dayan <roid@mellanox.com> wrote:

> Fix order of arguments when passed to __flower_parse_ip_addr.
> 
> Fixes: ("f888f4e20534 tc: flower: Support matching ARP")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Reviewed-by: Paul Blakey <paulb@mellanox.com>

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-23 17:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 14:05 [PATCH iproute2] tc: flower: Fix parsing ip address Roi Dayan
2017-02-22 15:16 ` Simon Horman
2017-02-23 17:01 ` Stephen Hemminger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.