From: Eva Rachel Retuya <eraretuya@gmail.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Michael Hennerich <michael.hennerich@analog.com>, Daniel Baluta <daniel.baluta@gmail.com>, Alison Schofield <amsfield22@gmail.com>, Florian Vaussard <florian.vaussard@heig-vd.ch>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org> Subject: Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C Date: Fri, 24 Feb 2017 17:06:13 +0800 [thread overview] Message-ID: <20170224090611.GB5012@Socrates-UM> (raw) In-Reply-To: <CAHp75VcWethtVW4Q6Q7Y+E9b6s32mf9YFT8wecXV7dDUS3asLQ@mail.gmail.com> On Thu, Feb 23, 2017 at 06:36:42PM +0200, Andy Shevchenko wrote: > On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote: > > Move I2C-specific code into its own file and rely on regmap to access > > registers. The core code provides access to x, y, z and scale readings. > > Like Lars already pointed to possibility of use of this in ACPI based > platforms, I would add a reference to > commit 01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment"). > > Please fix your patches accordingly. > Ack. Thank you for pointing this out. I'm not aware of the said commit. Eva > > > +static const struct i2c_device_id adxl345_i2c_id[] = { > > + { "adxl345", 0 }, > > + { } > > +}; > > + > > +MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id); > > + > > +#ifdef CONFIG_OF > > +static const struct of_device_id adxl345_of_match[] = { > > + { .compatible = "adi,adxl345" }, > > + { }, > > +}; > > + > > +MODULE_DEVICE_TABLE(of, adxl345_of_match); > > +#endif > > + > > +static struct i2c_driver adxl345_i2c_driver = { > > + .driver = { > > + .name = "adxl345_i2c", > > + .of_match_table = of_match_ptr(adxl345_of_match), > > + }, > > + .probe = adxl345_i2c_probe, > > + .remove = adxl345_i2c_remove, > > + .id_table = adxl345_i2c_id, > > +}; > > + > > +module_i2c_driver(adxl345_i2c_driver); > > + > > +MODULE_AUTHOR("Eva Rachel Retuya <eraretuya@gmail.com>"); > > +MODULE_DESCRIPTION("ADXL345 3-Axis Digital Accelerometer I2C driver"); > > +MODULE_LICENSE("GPL v2"); > > > -- > With Best Regards, > Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Eva Rachel Retuya <eraretuya-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>, Daniel Baluta <daniel.baluta-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C Date: Fri, 24 Feb 2017 17:06:13 +0800 [thread overview] Message-ID: <20170224090611.GB5012@Socrates-UM> (raw) In-Reply-To: <CAHp75VcWethtVW4Q6Q7Y+E9b6s32mf9YFT8wecXV7dDUS3asLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Thu, Feb 23, 2017 at 06:36:42PM +0200, Andy Shevchenko wrote: > On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > Move I2C-specific code into its own file and rely on regmap to access > > registers. The core code provides access to x, y, z and scale readings. > > Like Lars already pointed to possibility of use of this in ACPI based > platforms, I would add a reference to > commit 01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment"). > > Please fix your patches accordingly. > Ack. Thank you for pointing this out. I'm not aware of the said commit. Eva > > > +static const struct i2c_device_id adxl345_i2c_id[] = { > > + { "adxl345", 0 }, > > + { } > > +}; > > + > > +MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id); > > + > > +#ifdef CONFIG_OF > > +static const struct of_device_id adxl345_of_match[] = { > > + { .compatible = "adi,adxl345" }, > > + { }, > > +}; > > + > > +MODULE_DEVICE_TABLE(of, adxl345_of_match); > > +#endif > > + > > +static struct i2c_driver adxl345_i2c_driver = { > > + .driver = { > > + .name = "adxl345_i2c", > > + .of_match_table = of_match_ptr(adxl345_of_match), > > + }, > > + .probe = adxl345_i2c_probe, > > + .remove = adxl345_i2c_remove, > > + .id_table = adxl345_i2c_id, > > +}; > > + > > +module_i2c_driver(adxl345_i2c_driver); > > + > > +MODULE_AUTHOR("Eva Rachel Retuya <eraretuya-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>"); > > +MODULE_DESCRIPTION("ADXL345 3-Axis Digital Accelerometer I2C driver"); > > +MODULE_LICENSE("GPL v2"); > > > -- > With Best Regards, > Andy Shevchenko
next prev parent reply other threads:[~2017-02-24 9:10 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-22 10:22 [PATCH v3 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Eva Rachel Retuya 2017-02-22 10:22 ` Eva Rachel Retuya 2017-02-22 10:22 ` [PATCH v3 1/4] Documentation: dt-bindings: Document ADXL345 accelerometer binding Eva Rachel Retuya 2017-02-22 10:22 ` Eva Rachel Retuya 2017-02-22 10:22 ` [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access Eva Rachel Retuya 2017-02-23 16:27 ` Andy Shevchenko 2017-02-23 16:27 ` Andy Shevchenko 2017-02-24 9:02 ` Eva Rachel Retuya 2017-02-24 9:02 ` Eva Rachel Retuya 2017-02-22 10:23 ` [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya 2017-02-22 10:23 ` Eva Rachel Retuya 2017-02-23 16:36 ` Andy Shevchenko 2017-02-23 16:36 ` Andy Shevchenko 2017-02-24 9:06 ` Eva Rachel Retuya [this message] 2017-02-24 9:06 ` Eva Rachel Retuya 2017-02-22 10:23 ` [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya 2017-02-22 10:23 ` Eva Rachel Retuya 2017-02-23 16:43 ` Andy Shevchenko 2017-02-23 16:43 ` Andy Shevchenko 2017-02-23 16:47 ` Lars-Peter Clausen 2017-02-23 16:58 ` Andy Shevchenko 2017-02-23 16:58 ` Andy Shevchenko 2017-02-24 9:12 ` Eva Rachel Retuya 2017-02-24 9:12 ` Eva Rachel Retuya 2017-02-24 9:22 ` Lars-Peter Clausen 2017-02-24 9:22 ` Lars-Peter Clausen 2017-02-24 11:48 ` Andy Shevchenko 2017-02-24 11:48 ` Andy Shevchenko 2017-02-24 14:30 ` Eva Rachel Retuya 2017-02-24 14:30 ` Eva Rachel Retuya 2017-02-24 19:46 ` Jonathan Cameron 2017-02-25 15:09 ` Jonathan Cameron 2017-02-25 15:09 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170224090611.GB5012@Socrates-UM \ --to=eraretuya@gmail.com \ --cc=amsfield22@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=daniel.baluta@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=florian.vaussard@heig-vd.ch \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=michael.hennerich@analog.com \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.