From: Daniel Lezcano <daniel.lezcano@linaro.org> To: "Andreas Färber" <afaerber@suse.de> Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, support@lemaker.org, linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH v2 04/17] clocksource: Add Owl timer Date: Sat, 25 Feb 2017 22:59:41 +0100 [thread overview] Message-ID: <20170225215941.GA30601@mai> (raw) In-Reply-To: <ab18d509-9fb2-1b4c-bdee-e2ce5d4273a3@suse.de> On Sat, Feb 25, 2017 at 12:25:32AM +0100, Andreas Färber wrote: > Am 24.02.2017 um 23:29 schrieb Daniel Lezcano: > > On Fri, Feb 24, 2017 at 04:40:42AM +0100, Andreas Färber wrote: > >> Implement clocksource and clockevents for Actions Semi S500. > >> > >> Based on LeMaker linux-actions tree. > >> > >> Signed-off-by: Andreas Färber <afaerber@suse.de> > > > > As this is a new driver, please give some technical information about the > > driver itself and a pointer to documentation if it is publicly available. > > What technical information would that be? Which of the timers we use as > clock source vs. clock events? Have a look at commit 07862c1 and e4a6b37 as reference. > The only public documentation beyond the source tree mentioned is here: > > http://www.lemaker.org/product-guitar-download-29.html (section 3.4) > > >> +#define OWL_Tx_CTL_INTEN (1 << 1) > >> +#define OWL_Tx_CTL_EN (1 << 2) > > > > s/(1 << 1)/BIT(1)/ > > s/(1 << 2)/BIT(2)/ > > OK > [ ... ] > >> +static struct clock_event_device owl_clockevent = { > >> + .name = "owl_tick", > >> + .rating = 200, > >> + .features = CLOCK_EVT_FEAT_ONESHOT, > > > > Did you consider adding CLOCK_EVT_FEAT_DYNIRQ ? > > No, it was not present downstream. Got a good example? https://lwn.net/Articles/541000/ > >> + .set_state_shutdown = owl_timer_set_state_shutdown, > >> + .set_state_oneshot = owl_timer_set_state_oneshot, > >> + .tick_resume = owl_timer_tick_resume, > >> + .set_next_event = owl_timer_set_next_event, > >> +}; > >> + > >> +static irqreturn_t owl_timer_interrupt(int irq, void *dev_id) > >> +{ > >> + struct clock_event_device *evt = (struct clock_event_device *)dev_id; > >> + > >> + evt->event_handler(evt); > >> + > >> + return IRQ_HANDLED; > >> +} > >> + > >> +static struct irqaction owl_timer_irq = { > >> + .name = "owl-timer", > >> + .flags = IRQF_TIMER, > >> + .handler = owl_timer_interrupt, > >> + .dev_id = &owl_clockevent, > >> +}; > >> + > >> +static int __init owl_timer_init(struct device_node *node) > >> +{ > >> + const unsigned long rate = 24000000; > > > > Use DT, either use clock-frequency or a clock ref. > > Are clk drivers really available at this point? clock-frequency sounds > more promising. Yes they are. Have a look at the other drivers. > >> + int irq1, ret; > >> + > >> + owl_timer_base = of_io_request_and_map(node, 0, "owl-timer"); > >> + if (IS_ERR(owl_timer_base)) { > >> + pr_err("Can't map timer registers"); > >> + return -ENXIO; > > > > Why not PTR_ERR(owl_timer_base) ? > > Only one in-tree driver (sun5i) matches such an expression. Will change. [ ... ] > > Please factor out these calls into a function. > > Do you have something in particular in mind? Maybe ..._reset() for the > first three? Yes. > >> + > >> + sched_clock_register(owl_timer_sched_read, 32, rate); > >> + clocksource_mmio_init(owl_timer_base + OWL_T0_VAL, node->name, > >> + rate, 200, 32, clocksource_mmio_readl_up); > >> + > >> + writel(0, owl_timer_base + OWL_T1_CTL); > >> + writel(0, owl_timer_base + OWL_T1_VAL); > >> + writel(0, owl_timer_base + OWL_T1_CMP); > >> + > >> + ret = setup_irq(irq1, &owl_timer_irq); > >> + if (ret) { > >> + pr_warn("failed to setup irq %d\n", irq1); > >> + return ret; > >> + } > > > > s/setup_irq/request_irq/ > > Care to explain? setup_irq has 32 hits vs. 28 for request_irq. The function setup_irq takes an irqaction as parameter. That forces all the drivers to declare a structure, so for a multiple platforms support (aka single kernel image), there are multiple structures declaration for nothing. The function request_irq allocates the structure and then call setup_irq. So now, request_irq is used in place of setup_irq. > >> + > >> + owl_clockevent.cpumask = cpumask_of(0); > >> + owl_clockevent.irq = irq1; > >> + > >> + clockevents_config_and_register(&owl_clockevent, rate, > >> + 0xf, 0xffffffff); > >> + > >> + return 0; > >> +} > >> +CLOCKSOURCE_OF_DECLARE(owl, "actions,owl-timer", owl_timer_init); > > Do you spot anything functionally wrong in this driver? Despite adding > this new driver, I am only getting the following additional earlycon output: > > [ 0.000029] sched_clock: 32 bits at 24MHz, resolution 41ns, wraps > every 89478484971ns > [ 0.007888] clocksource: timer: mask: 0xffffffff max_cycles: > 0xffffffff, max_idle_ns: 79635851949 ns > [ 0.017748] Console: colour dummy device 80x30 > [ 0.022243] Calibrating delay loop... > [ 0.030895] random: fast init done > [ 0.231021] random: crng init done > > For S900 I'm using the generic timer instead. I don't get the issue, can you elaborate ? Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 04/17] clocksource: Add Owl timer Date: Sat, 25 Feb 2017 22:59:41 +0100 [thread overview] Message-ID: <20170225215941.GA30601@mai> (raw) In-Reply-To: <ab18d509-9fb2-1b4c-bdee-e2ce5d4273a3@suse.de> On Sat, Feb 25, 2017 at 12:25:32AM +0100, Andreas F?rber wrote: > Am 24.02.2017 um 23:29 schrieb Daniel Lezcano: > > On Fri, Feb 24, 2017 at 04:40:42AM +0100, Andreas F?rber wrote: > >> Implement clocksource and clockevents for Actions Semi S500. > >> > >> Based on LeMaker linux-actions tree. > >> > >> Signed-off-by: Andreas F?rber <afaerber@suse.de> > > > > As this is a new driver, please give some technical information about the > > driver itself and a pointer to documentation if it is publicly available. > > What technical information would that be? Which of the timers we use as > clock source vs. clock events? Have a look at commit 07862c1 and e4a6b37 as reference. > The only public documentation beyond the source tree mentioned is here: > > http://www.lemaker.org/product-guitar-download-29.html (section 3.4) > > >> +#define OWL_Tx_CTL_INTEN (1 << 1) > >> +#define OWL_Tx_CTL_EN (1 << 2) > > > > s/(1 << 1)/BIT(1)/ > > s/(1 << 2)/BIT(2)/ > > OK > [ ... ] > >> +static struct clock_event_device owl_clockevent = { > >> + .name = "owl_tick", > >> + .rating = 200, > >> + .features = CLOCK_EVT_FEAT_ONESHOT, > > > > Did you consider adding CLOCK_EVT_FEAT_DYNIRQ ? > > No, it was not present downstream. Got a good example? https://lwn.net/Articles/541000/ > >> + .set_state_shutdown = owl_timer_set_state_shutdown, > >> + .set_state_oneshot = owl_timer_set_state_oneshot, > >> + .tick_resume = owl_timer_tick_resume, > >> + .set_next_event = owl_timer_set_next_event, > >> +}; > >> + > >> +static irqreturn_t owl_timer_interrupt(int irq, void *dev_id) > >> +{ > >> + struct clock_event_device *evt = (struct clock_event_device *)dev_id; > >> + > >> + evt->event_handler(evt); > >> + > >> + return IRQ_HANDLED; > >> +} > >> + > >> +static struct irqaction owl_timer_irq = { > >> + .name = "owl-timer", > >> + .flags = IRQF_TIMER, > >> + .handler = owl_timer_interrupt, > >> + .dev_id = &owl_clockevent, > >> +}; > >> + > >> +static int __init owl_timer_init(struct device_node *node) > >> +{ > >> + const unsigned long rate = 24000000; > > > > Use DT, either use clock-frequency or a clock ref. > > Are clk drivers really available at this point? clock-frequency sounds > more promising. Yes they are. Have a look at the other drivers. > >> + int irq1, ret; > >> + > >> + owl_timer_base = of_io_request_and_map(node, 0, "owl-timer"); > >> + if (IS_ERR(owl_timer_base)) { > >> + pr_err("Can't map timer registers"); > >> + return -ENXIO; > > > > Why not PTR_ERR(owl_timer_base) ? > > Only one in-tree driver (sun5i) matches such an expression. Will change. [ ... ] > > Please factor out these calls into a function. > > Do you have something in particular in mind? Maybe ..._reset() for the > first three? Yes. > >> + > >> + sched_clock_register(owl_timer_sched_read, 32, rate); > >> + clocksource_mmio_init(owl_timer_base + OWL_T0_VAL, node->name, > >> + rate, 200, 32, clocksource_mmio_readl_up); > >> + > >> + writel(0, owl_timer_base + OWL_T1_CTL); > >> + writel(0, owl_timer_base + OWL_T1_VAL); > >> + writel(0, owl_timer_base + OWL_T1_CMP); > >> + > >> + ret = setup_irq(irq1, &owl_timer_irq); > >> + if (ret) { > >> + pr_warn("failed to setup irq %d\n", irq1); > >> + return ret; > >> + } > > > > s/setup_irq/request_irq/ > > Care to explain? setup_irq has 32 hits vs. 28 for request_irq. The function setup_irq takes an irqaction as parameter. That forces all the drivers to declare a structure, so for a multiple platforms support (aka single kernel image), there are multiple structures declaration for nothing. The function request_irq allocates the structure and then call setup_irq. So now, request_irq is used in place of setup_irq. > >> + > >> + owl_clockevent.cpumask = cpumask_of(0); > >> + owl_clockevent.irq = irq1; > >> + > >> + clockevents_config_and_register(&owl_clockevent, rate, > >> + 0xf, 0xffffffff); > >> + > >> + return 0; > >> +} > >> +CLOCKSOURCE_OF_DECLARE(owl, "actions,owl-timer", owl_timer_init); > > Do you spot anything functionally wrong in this driver? Despite adding > this new driver, I am only getting the following additional earlycon output: > > [ 0.000029] sched_clock: 32 bits at 24MHz, resolution 41ns, wraps > every 89478484971ns > [ 0.007888] clocksource: timer: mask: 0xffffffff max_cycles: > 0xffffffff, max_idle_ns: 79635851949 ns > [ 0.017748] Console: colour dummy device 80x30 > [ 0.022243] Calibrating delay loop... > [ 0.030895] random: fast init done > [ 0.231021] random: crng init done > > For S900 I'm using the generic timer instead. I don't get the issue, can you elaborate ? Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-02-25 21:59 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-24 3:40 [PATCH v2 00/17] ARM: Initial Actions Semi S500 and S900 enablement Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 01/17] dt-bindings: Add vendor prefix for Actions Semi Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-27 14:57 ` Andreas Färber 2017-02-27 14:57 ` Andreas Färber 2017-02-27 14:57 ` Andreas Färber 2017-02-28 0:11 ` Rob Herring 2017-02-28 0:11 ` Rob Herring 2017-02-28 0:11 ` Rob Herring 2017-02-24 3:40 ` [PATCH v2 02/17] dt-bindings: arm: Document Actions Semi S500 Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-28 0:12 ` Rob Herring 2017-02-28 0:12 ` Rob Herring 2017-02-28 0:12 ` Rob Herring 2017-02-24 3:40 ` [RFC v2 03/17] dt-bindings: timer: Document Owl timer Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:45 ` Andreas Färber 2017-02-24 3:45 ` Andreas Färber 2017-02-27 14:40 ` Andreas Färber 2017-02-27 14:40 ` Andreas Färber 2017-02-27 14:40 ` Andreas Färber 2017-02-28 0:15 ` Rob Herring 2017-02-28 0:15 ` Rob Herring 2017-02-28 0:15 ` Rob Herring 2017-02-24 3:40 ` [PATCH v2 04/17] clocksource: Add " Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 22:29 ` Daniel Lezcano 2017-02-24 22:29 ` Daniel Lezcano 2017-02-24 23:25 ` Andreas Färber 2017-02-24 23:25 ` Andreas Färber 2017-02-25 21:59 ` Daniel Lezcano [this message] 2017-02-25 21:59 ` Daniel Lezcano 2017-02-26 14:40 ` Andreas Färber 2017-02-26 14:40 ` Andreas Färber 2017-02-26 14:56 ` Daniel Lezcano 2017-02-26 14:56 ` Daniel Lezcano 2017-02-24 3:40 ` [PATCH v2 05/17] ARM: Prepare Actions Semi S500 Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 06/17] ARM64: Prepare Actions Semi S900 Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 07/17] dt-bindings: serial: Document Actions Semi Owl UARTs Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-28 0:16 ` Rob Herring 2017-02-28 0:16 ` Rob Herring 2017-02-28 0:16 ` Rob Herring 2017-02-24 3:40 ` [PATCH v2 08/17] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 09/17] Documentation: kernel-parameters: Document owl earlycon Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-03-03 22:46 ` Jonathan Corbet 2017-03-03 22:46 ` Jonathan Corbet 2017-03-03 23:28 ` Andreas Färber 2017-03-03 23:28 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 10/17] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 23:36 ` Andreas Färber 2017-02-24 23:36 ` Andreas Färber 2017-02-24 23:36 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 11/17] dt-bindings: Add vendor prefix for uCRobotics Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-28 0:16 ` Rob Herring 2017-02-28 0:16 ` Rob Herring 2017-02-24 3:40 ` [PATCH v2 12/17] dt-bindings: arm: Document Actions Semi S900 Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-28 0:17 ` Rob Herring 2017-02-28 0:17 ` Rob Herring 2017-02-28 0:17 ` Rob Herring 2017-02-24 3:40 ` [RFC v2 13/17] ARM64: dts: Add Actions Semi S900 and Bubblegum-96 Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:49 ` Andreas Färber 2017-02-24 3:49 ` Andreas Färber 2017-02-24 3:49 ` Andreas Färber 2017-02-24 3:40 ` [RFC v2 14/17] MAINTAINERS: Add Actions Semi Owl section Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 15/17] tty: serial: owl: Implement console driver Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 16/17] ARM64: dts: actions: s900-bubblegum-96: Add fake uart5 clk Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` [PATCH v2 17/17] ARM: dts: s500-guitar-bb-rev-b: Add fake uart3 clock Andreas Färber 2017-02-24 3:40 ` Andreas Färber 2017-02-24 3:40 ` Andreas Färber
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170225215941.GA30601@mai \ --to=daniel.lezcano@linaro.org \ --cc=96boards@ucrobotics.com \ --cc=afaerber@suse.de \ --cc=arm@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mp-cs@actions-semi.com \ --cc=support@lemaker.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.