From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1668103] Re: Possible off-by-one error in priority handling of hw/PL190.c
Date: Sun, 26 Feb 2017 22:41:43 -0000 [thread overview]
Message-ID: <20170226224143.23033.97730.malone@chaenomeles.canonical.com> (raw)
In-Reply-To: 20170226205013.23267.77116.malonedeb@chaenomeles.canonical.com
"Fix committed" doesn't seem right -- that's only when a patch is
actually committed to QEMU's git tree...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1668103
Title:
Possible off-by-one error in priority handling of hw/PL190.c
Status in QEMU:
Fix Committed
Bug description:
I have a problem when reading back VECTADDR in my proprietary OS's
interrupt handler.
Example client code:
1) Write INTENCLEAR to clear all interrupt enable bits
2) Set all 16 vector control registers to zero
3) Set vector address #2 to value 2
4) Set vector control #2 to 0x21 (vector_interrupt_enable(0x20) | vector_interrupt_source(0x1) )
5) Enable interrupt 1 by writing 0x2 to INTENABLE
6) In interrupt handler: read VECTADDR [should read 0x2 (active IRQs vector address as set in step 3), reads 0x0 (active vector address index 3 instead of index 2)]
Problem:
So, for me, the block commented with /* Read vector address at the
start of an ISR... */ in hw/pl190.c has an off by-one error and does
not return the vector address of the pending interrupt, but of the
next one in the list of priorities (i.e. vector address 3).
Solution:
In pl190_update_vectors(), also set the priority bit for the current
priority (1<<i) interrupt (if enabled) in s->prio_mask[i] in addition
to those of higher priority enabled interrupts. This will cause the
loop in the read handling of VECTADDR to terminate an iteration
earlier and will deliver the correct interrupt priority as iteration
variable i subsequently used for addressing.
I'll try to provide a patch for this.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1668103/+subscriptions
next prev parent reply other threads:[~2017-02-26 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 20:50 [Qemu-devel] [Bug 1668103] [NEW] Possible off-by-one error in priority handling of hw/PL190.c Marc Bommert
2017-02-26 20:59 ` [Qemu-devel] [Bug 1668103] " Marc Bommert
2017-02-26 21:18 ` Marc Bommert
2017-02-26 21:21 ` Marc Bommert
2017-02-26 22:41 ` Peter Maydell [this message]
2017-02-27 7:38 ` Thomas Huth
2017-02-27 10:01 ` Peter Maydell
2017-02-27 16:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226224143.23033.97730.malone@chaenomeles.canonical.com \
--to=peter.maydell@linaro.org \
--cc=1668103@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.