* phy deadlock -stable backport request
@ 2017-02-27 13:56 Niklas Cassel
2017-02-27 16:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2017-02-27 13:56 UTC (permalink / raw)
To: netdev
Hello
I would like to request that
commit eab127717a6af54401ba534790c793ec143cd1fc
Author: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri Jan 20 15:31:52 2017 -0800
net: phy: Avoid deadlock during phy_error()
phy_error() is called in the PHY state machine workqueue context, and
calls phy_trigger_machine() which does a cancel_delayed_work_sync() of
the workqueue we execute from, causing a deadlock situation.
Augment phy_trigger_machine() machine with a sync boolean indicating
whether we should use cancel_*_sync() or just cancel_*_work().
Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
would be backported to stable branch v4.9.
I've seen this deadlock happen on v4.9.x
Regards,
Niklas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: phy deadlock -stable backport request
2017-02-27 13:56 phy deadlock -stable backport request Niklas Cassel
@ 2017-02-27 16:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-27 16:38 UTC (permalink / raw)
To: niklas.cassel; +Cc: netdev
From: Niklas Cassel <niklas.cassel@axis.com>
Date: Mon, 27 Feb 2017 14:56:31 +0100
> I would like to request that
>
> commit eab127717a6af54401ba534790c793ec143cd1fc
> Author: Florian Fainelli <f.fainelli@gmail.com>
> Date: Fri Jan 20 15:31:52 2017 -0800
>
> net: phy: Avoid deadlock during phy_error()
...
> would be backported to stable branch v4.9.
>
> I've seen this deadlock happen on v4.9.x
Ok, queued up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-27 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 13:56 phy deadlock -stable backport request Niklas Cassel
2017-02-27 16:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.