* [PATCH 1/2] staging: speakup: Align with open parentheses
@ 2017-02-27 15:11 Sreya Mittal
2017-02-27 15:15 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Sreya Mittal @ 2017-02-27 15:11 UTC (permalink / raw)
To: outreachy-kernel
Cc: Sreya Mittal, William Hubbs, Chris Brannon, Kirk Reiser,
Samuel Thibault, Greg Kroah-Hartman
Align next line of print statements
to the right of open parentheses.
Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
---
drivers/staging/speakup/keyhelp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
index ce94cb1..f5156bb 100644
--- a/drivers/staging/speakup/keyhelp.c
+++ b/drivers/staging/speakup/keyhelp.c
@@ -117,7 +117,7 @@ static void say_key(int key)
}
if ((key > 0) && (key <= num_key_names))
synth_printf(" %s\n",
- spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
+ spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
}
static int help_init(void)
@@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
name = NULL;
if ((type != KT_SPKUP) && (key > 0) && (key <= num_key_names)) {
synth_printf("%s\n",
- spk_msg_get(MSG_KEYNAMES_START + key - 1));
+ spk_msg_get(MSG_KEYNAMES_START + key - 1));
return 1;
}
for (i = 0; funcvals[i] != 0 && !name; i++) {
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: Align with open parentheses
2017-02-27 15:11 [PATCH 1/2] staging: speakup: Align with open parentheses Sreya Mittal
@ 2017-02-27 15:15 ` Julia Lawall
2017-02-27 15:19 ` Sreya Mittal
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2017-02-27 15:15 UTC (permalink / raw)
To: Sreya Mittal
Cc: outreachy-kernel, William Hubbs, Chris Brannon, Kirk Reiser,
Samuel Thibault, Greg Kroah-Hartman
On Mon, 27 Feb 2017, Sreya Mittal wrote:
> Align next line of print statements
> to the right of open parentheses.
>
> Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
> ---
> drivers/staging/speakup/keyhelp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
> index ce94cb1..f5156bb 100644
> --- a/drivers/staging/speakup/keyhelp.c
> +++ b/drivers/staging/speakup/keyhelp.c
> @@ -117,7 +117,7 @@ static void say_key(int key)
> }
> if ((key > 0) && (key <= num_key_names))
It's not related to this change, but there are a lot of parentheses in
the if tests that can be dropped.
julia
> synth_printf(" %s\n",
> - spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
> + spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
> }
>
> static int help_init(void)
> @@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
> name = NULL;
> if ((type != KT_SPKUP) && (key > 0) && (key <= num_key_names)) {
> synth_printf("%s\n",
> - spk_msg_get(MSG_KEYNAMES_START + key - 1));
> + spk_msg_get(MSG_KEYNAMES_START + key - 1));
> return 1;
> }
> for (i = 0; funcvals[i] != 0 && !name; i++) {
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-sreyamittal5%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: Align with open parentheses
2017-02-27 15:15 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-27 15:19 ` Sreya Mittal
2017-02-27 15:23 ` Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Sreya Mittal @ 2017-02-27 15:19 UTC (permalink / raw)
To: outreachy-kernel
Cc: sreyamittal5, w.d.hubbs, chris, kirk, samuel.thibault, gregkh
[-- Attachment #1.1: Type: text/plain, Size: 2364 bytes --]
On Monday, February 27, 2017 at 8:45:31 PM UTC+5:30, Julia Lawall wrote:
>
>
>
> On Mon, 27 Feb 2017, Sreya Mittal wrote:
>
> > Align next line of print statements
> > to the right of open parentheses.
> >
> > Signed-off-by: Sreya Mittal <sreyam...@gmail.com <javascript:>>
> > ---
> > drivers/staging/speakup/keyhelp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/keyhelp.c
> b/drivers/staging/speakup/keyhelp.c
> > index ce94cb1..f5156bb 100644
> > --- a/drivers/staging/speakup/keyhelp.c
> > +++ b/drivers/staging/speakup/keyhelp.c
> > @@ -117,7 +117,7 @@ static void say_key(int key)
> > }
> > if ((key > 0) && (key <= num_key_names))
>
> It's not related to this change, but there are a lot of parentheses in
> the if tests that can be dropped.
>
> julia
>
Ok. I will make the changes and send again.
Sreya
>
> > synth_printf(" %s\n",
> > - spk_msg_get(MSG_KEYNAMES_START + (key -
> 1)));
> > + spk_msg_get(MSG_KEYNAMES_START + (key -
> 1)));
> > }
> >
> > static int help_init(void)
> > @@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type,
> u_char ch, u_short key)
> > name = NULL;
> > if ((type != KT_SPKUP) && (key > 0) && (key <=
> num_key_names)) {
> > synth_printf("%s\n",
> > - spk_msg_get(MSG_KEYNAMES_START + key -
> 1));
> > + spk_msg_get(MSG_KEYNAMES_START +
> key - 1));
> > return 1;
> > }
> > for (i = 0; funcvals[i] != 0 && !name; i++) {
> > --
> > 2.9.3
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-sreyamittal5%40gmail.com.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 4575 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: Align with open parentheses
2017-02-27 15:19 ` Sreya Mittal
@ 2017-02-27 15:23 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2017-02-27 15:23 UTC (permalink / raw)
To: Sreya Mittal
Cc: outreachy-kernel, w.d.hubbs, chris, kirk, samuel.thibault, gregkh
[-- Attachment #1: Type: text/plain, Size: 3559 bytes --]
On Mon, 27 Feb 2017, Sreya Mittal wrote:
>
>
> On Monday, February 27, 2017 at 8:45:31 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Mon, 27 Feb 2017, Sreya Mittal wrote:
>
> > Align next line of print statements
> > to the right of open parentheses.
> >
> > Signed-off-by: Sreya Mittal <sreyam...@gmail.com>
> > ---
> > drivers/staging/speakup/keyhelp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/keyhelp.c
> b/drivers/staging/speakup/keyhelp.c
> > index ce94cb1..f5156bb 100644
> > --- a/drivers/staging/speakup/keyhelp.c
> > +++ b/drivers/staging/speakup/keyhelp.c
> > @@ -117,7 +117,7 @@ static void say_key(int key)
> > }
> > if ((key > 0) && (key <= num_key_names))
>
> It's not related to this change, but there are a lot of
> parentheses in
> the if tests that can be dropped.
>
> julia
>
>
> Ok. I will make the changes and send again.
It's not for the same patch. You can make a series, though.
julia
>
> Sreya
>
>
> > synth_printf(" %s\n",
> >
> - spk_msg_get(MSG_KEYNAMES_START
> + (key - 1)));
> > + spk_msg_get(MSG_KEYNAMES_START +
> (key - 1)));
> > }
> >
> > static int help_init(void)
> > @@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc,
> u_char type, u_char ch, u_short key)
> > name = NULL;
> > if ((type != KT_SPKUP) && (key > 0) && (key
> <= num_key_names)) {
> > synth_printf("%s\n",
> >
> - spk_msg_get(MSG_KEYNAMES_START
> + key - 1));
> > +
> spk_msg_get(MSG_KEYNAMES_START + key - 1));
> > return 1;
> > }
> > for (i = 0; funcvals[i] != 0 && !name; i++) {
> > --
> > 2.9.3
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@googlegroups.com.
> > To post to this group, send email to
> outreach...@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170227151124.18063-1-s
> reyamittal5%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/9955a49f-05fa-4a47-8999-
> 175c54069811%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging: speakup: Align with open parentheses
@ 2017-02-24 20:50 Sreya Mittal
0 siblings, 0 replies; 5+ messages in thread
From: Sreya Mittal @ 2017-02-24 20:50 UTC (permalink / raw)
To: outreachy-kernel
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman
Align next line of print statements
to the right of open parentheses
Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
---
drivers/staging/speakup/keyhelp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
index ce94cb1..f5156bb 100644
--- a/drivers/staging/speakup/keyhelp.c
+++ b/drivers/staging/speakup/keyhelp.c
@@ -117,7 +117,7 @@ static void say_key(int key)
}
if ((key > 0) && (key <= num_key_names))
synth_printf(" %s\n",
- spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
+ spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
}
static int help_init(void)
@@ -182,7 +182,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
name = NULL;
if ((type != KT_SPKUP) && (key > 0) && (key <= num_key_names)) {
synth_printf("%s\n",
- spk_msg_get(MSG_KEYNAMES_START + key - 1));
+ spk_msg_get(MSG_KEYNAMES_START + key - 1));
return 1;
}
for (i = 0; funcvals[i] != 0 && !name; i++) {
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-27 15:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 15:11 [PATCH 1/2] staging: speakup: Align with open parentheses Sreya Mittal
2017-02-27 15:15 ` [Outreachy kernel] " Julia Lawall
2017-02-27 15:19 ` Sreya Mittal
2017-02-27 15:23 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2017-02-24 20:50 Sreya Mittal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.