All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5] staging: dgnc: replace udelay with usleep_range
@ 2017-02-27 17:01 Aishwarya Pant
  0 siblings, 0 replies; only message in thread
From: Aishwarya Pant @ 2017-02-27 17:01 UTC (permalink / raw)
  To: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman; +Cc: outreachy-kernel

Fix checkpatch warning on dgnc_cls.c: CHECK usleep_range is preferred
over udelay. udelay(t) in function cls_uart_init is within non-atomic
context and can be safely replaced by usleep_range(t, t + delta) where
delta is t (as t is between 10 and 20 microseconds).

Signed-off-by: Aishwarya Pant <aishpant@gmail.com>

---
Changes in v5:
	- Breakup the patch to handle one cleanup
Changes in v4:
	- Fix commit message formatting
Changes in v3:
	- Replace usleep_range by udelay in cls_flush_uart_write
	- Fix diff in commit message
Changes in v2:
	- Revert usage of usleep_range in atomic context
	- Cleanup the commit message

 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index c20ffdd..28a3e16 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1096,7 +1096,7 @@ static void cls_uart_init(struct channel_t *ch)
 
 	writeb(UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
 	       &ch->ch_cls_uart->isr_fcr);
-	udelay(10);
+	usleep_range(10, 20);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-27 17:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 17:01 [PATCH v5] staging: dgnc: replace udelay with usleep_range Aishwarya Pant

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.