From: kbuild test robot <lkp@intel.com>
To: Iyappan Subramanian <isubramanian@apm.com>
Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org,
andrew@lunn.ch, f.fainelli@gmail.com, David.Laight@aculab.com,
linux-arm-kernel@lists.infradead.org, patches@apm.com,
kchudgar@apm.com, Iyappan Subramanian <isubramanian@apm.com>
Subject: Re: [PATCH v2 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive
Date: Mon, 27 Feb 2017 20:21:02 +0800 [thread overview]
Message-ID: <201702272053.fL0xZ22g%fengguang.wu@intel.com> (raw)
In-Reply-To: <1488172706-29577-6-git-send-email-isubramanian@apm.com>
[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]
Hi Iyappan,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-v2-Add-RGMII-based-1G-driver/20170227-182414
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/net/ethernet/apm/xgene-v2/main.c: In function 'is_tx_slot_available':
>> drivers/net/ethernet/apm/xgene-v2/main.c:182:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
^~
drivers/net/ethernet/apm/xgene-v2/main.c:186:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return false;
^~~~~~
drivers/net/ethernet/apm/xgene-v2/main.c: In function 'is_tx_hw_done':
drivers/net/ethernet/apm/xgene-v2/main.c:246:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
^~
drivers/net/ethernet/apm/xgene-v2/main.c:250:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return false;
^~~~~~
vim +/if +182 drivers/net/ethernet/apm/xgene-v2/main.c
166 if (ret)
167 netdev_err(ndev, "Failed to request irq %s\n", pdata->irq_name);
168
169 return ret;
170 }
171
172 static void xge_free_irq(struct net_device *ndev)
173 {
174 struct xge_pdata *pdata = netdev_priv(ndev);
175 struct device *dev = &pdata->pdev->dev;
176
177 devm_free_irq(dev, pdata->resources.irq, pdata);
178 }
179
180 static bool is_tx_slot_available(struct xge_raw_desc *raw_desc)
181 {
> 182 if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
183 (GET_BITS(PKT_SIZE, le64_to_cpu(raw_desc->m0)) == SLOT_EMPTY))
184 return true;
185
186 return false;
187 }
188
189 static netdev_tx_t xge_start_xmit(struct sk_buff *skb, struct net_device *ndev)
190 {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58535 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive
Date: Mon, 27 Feb 2017 20:21:02 +0800 [thread overview]
Message-ID: <201702272053.fL0xZ22g%fengguang.wu@intel.com> (raw)
In-Reply-To: <1488172706-29577-6-git-send-email-isubramanian@apm.com>
Hi Iyappan,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-v2-Add-RGMII-based-1G-driver/20170227-182414
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/net/ethernet/apm/xgene-v2/main.c: In function 'is_tx_slot_available':
>> drivers/net/ethernet/apm/xgene-v2/main.c:182:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
^~
drivers/net/ethernet/apm/xgene-v2/main.c:186:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return false;
^~~~~~
drivers/net/ethernet/apm/xgene-v2/main.c: In function 'is_tx_hw_done':
drivers/net/ethernet/apm/xgene-v2/main.c:246:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
^~
drivers/net/ethernet/apm/xgene-v2/main.c:250:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return false;
^~~~~~
vim +/if +182 drivers/net/ethernet/apm/xgene-v2/main.c
166 if (ret)
167 netdev_err(ndev, "Failed to request irq %s\n", pdata->irq_name);
168
169 return ret;
170 }
171
172 static void xge_free_irq(struct net_device *ndev)
173 {
174 struct xge_pdata *pdata = netdev_priv(ndev);
175 struct device *dev = &pdata->pdev->dev;
176
177 devm_free_irq(dev, pdata->resources.irq, pdata);
178 }
179
180 static bool is_tx_slot_available(struct xge_raw_desc *raw_desc)
181 {
> 182 if (GET_BITS(E, le64_to_cpu(raw_desc->m0)) &&
183 (GET_BITS(PKT_SIZE, le64_to_cpu(raw_desc->m0)) == SLOT_EMPTY))
184 return true;
185
186 return false;
187 }
188
189 static netdev_tx_t xge_start_xmit(struct sk_buff *skb, struct net_device *ndev)
190 {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 58535 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170227/e620ab63/attachment-0001.gz>
next prev parent reply other threads:[~2017-02-27 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 5:18 [PATCH v2 net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 5:18 ` [PATCH v2 net-next 1/6] drivers: net: xgene-v2: Add DMA descriptor Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 5:18 ` [PATCH v2 net-next 2/6] drivers: net: xgene-v2: Add mac configuration Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 5:18 ` [PATCH v2 net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 5:18 ` [PATCH v2 net-next 4/6] drivers: net: xgene-v2: Add base driver Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 5:18 ` [PATCH v2 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
2017-02-27 12:21 ` kbuild test robot [this message]
2017-02-27 12:21 ` kbuild test robot
2017-02-27 5:18 ` [PATCH v2 net-next 6/6] MAINTAINERS: Add entry for APM X-Gene SoC Ethernet (v2) driver Iyappan Subramanian
2017-02-27 5:18 ` Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201702272053.fL0xZ22g%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=isubramanian@apm.com \
--cc=kbuild-all@01.org \
--cc=kchudgar@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.