From: Rob Herring <robh@kernel.org> To: Bartosz Golaszewski <bgolaszewski@baylibre.com> Cc: Sekhar Nori <nsekhar@ti.com>, David Lechner <david@lechnology.com>, Kevin Hilman <khilman@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Patrick Titiano <ptitiano@baylibre.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mark Rutland <mark.rutland@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Date: Mon, 27 Feb 2017 16:52:09 -0600 [thread overview] Message-ID: <20170227225209.26oieqwbafqjga2a@rob-hp-laptop> (raw) In-Reply-To: <1487771027-7763-4-git-send-email-bgolaszewski@baylibre.com> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: > Add an optional property - enable-gpios - which can be used to specify > the GPIOs that must be requested to select the vpif functionality. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > index df7182a..23c5405 100644 > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > @@ -13,6 +13,9 @@ Required properties: > - reg: physical base address and length of the registers set for the device; > - interrupts: should contain IRQ line for the VPIF > > +Optional properties: > +- enable-gpios: phandle of the GPIOs used to select the vpif functionality What does this control exactly? The GPIOs belong in the node they are connected to and having GPIOs routed to this block seems strange. There are inputs or outputs? > + > Video Capture: > > VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a > @@ -30,6 +33,10 @@ I2C-connected TVP5147 decoder: > reg = <0x217000 0x1000>; > interrupts = <92>; > > + enable-gpios = <&tca6416 7 GPIO_ACTIVE_HIGH > + &tca6416 6 GPIO_ACTIVE_HIGH > + &tca6416 5 GPIO_ACTIVE_LOW>; > + > port@0 { > vpif_input_ch0: endpoint@0 { > reg = <0>; > -- > 2.9.3 >
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Date: Mon, 27 Feb 2017 16:52:09 -0600 [thread overview] Message-ID: <20170227225209.26oieqwbafqjga2a@rob-hp-laptop> (raw) In-Reply-To: <1487771027-7763-4-git-send-email-bgolaszewski@baylibre.com> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: > Add an optional property - enable-gpios - which can be used to specify > the GPIOs that must be requested to select the vpif functionality. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > index df7182a..23c5405 100644 > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > @@ -13,6 +13,9 @@ Required properties: > - reg: physical base address and length of the registers set for the device; > - interrupts: should contain IRQ line for the VPIF > > +Optional properties: > +- enable-gpios: phandle of the GPIOs used to select the vpif functionality What does this control exactly? The GPIOs belong in the node they are connected to and having GPIOs routed to this block seems strange. There are inputs or outputs? > + > Video Capture: > > VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a > @@ -30,6 +33,10 @@ I2C-connected TVP5147 decoder: > reg = <0x217000 0x1000>; > interrupts = <92>; > > + enable-gpios = <&tca6416 7 GPIO_ACTIVE_HIGH > + &tca6416 6 GPIO_ACTIVE_HIGH > + &tca6416 5 GPIO_ACTIVE_LOW>; > + > port at 0 { > vpif_input_ch0: endpoint at 0 { > reg = <0>; > -- > 2.9.3 >
next prev parent reply other threads:[~2017-02-27 22:52 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-22 13:43 [PATCH v2 0/3] media: dt-bindings: extend the vpif bindings Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` [PATCH v2 1/3] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` [PATCH v2 2/3] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-27 22:46 ` Rob Herring 2017-02-27 22:46 ` Rob Herring 2017-02-27 22:46 ` Rob Herring 2017-02-22 13:43 ` [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-22 13:43 ` Bartosz Golaszewski 2017-02-27 22:52 ` Rob Herring [this message] 2017-02-27 22:52 ` Rob Herring 2017-02-28 5:36 ` Sekhar Nori 2017-02-28 5:36 ` Sekhar Nori 2017-02-28 5:36 ` Sekhar Nori 2017-02-28 11:00 ` Bartosz Golaszewski 2017-02-28 11:00 ` Bartosz Golaszewski 2017-02-28 11:00 ` Bartosz Golaszewski 2017-03-01 13:16 ` Sekhar Nori 2017-03-01 13:16 ` Sekhar Nori 2017-03-01 13:16 ` Sekhar Nori 2017-02-28 14:26 ` Rob Herring 2017-02-28 14:26 ` Rob Herring 2017-02-28 14:26 ` Rob Herring 2017-03-01 12:56 ` Sekhar Nori 2017-03-01 12:56 ` Sekhar Nori 2017-03-01 12:56 ` Sekhar Nori 2017-02-28 9:01 ` [PATCH v2 0/3] media: dt-bindings: extend the vpif bindings Sekhar Nori 2017-02-28 9:01 ` Sekhar Nori 2017-02-28 9:01 ` Sekhar Nori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170227225209.26oieqwbafqjga2a@rob-hp-laptop \ --to=robh@kernel.org \ --cc=bgolaszewski@baylibre.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@baylibre.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nsekhar@ti.com \ --cc=ptitiano@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.