* [Qemu-devel] [PATCH] linux-user: Fix fork() and vfork()
@ 2017-02-28 2:51 Tim Hentenaar
2017-02-28 13:46 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Tim Hentenaar @ 2017-02-28 2:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Tim Hentenaar
A check was introduced in 5ea2fc84da1bffce749c9d0848f5336def2818bb which
causes fork() and vfork() to fail if TARGET_SIGCHLD != SIGCHLD.
Signed-off-by: Tim Hentenaar <tim@hentenaar.com>
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f569f82..ac4106a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7680,7 +7680,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
break;
#ifdef TARGET_NR_fork
case TARGET_NR_fork:
- ret = get_errno(do_fork(cpu_env, SIGCHLD, 0, 0, 0, 0));
+ ret = get_errno(do_fork(cpu_env, TARGET_SIGCHLD, 0, 0, 0, 0));
break;
#endif
#ifdef TARGET_NR_waitpid
@@ -10490,7 +10490,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
#endif
#ifdef TARGET_NR_vfork
case TARGET_NR_vfork:
- ret = get_errno(do_fork(cpu_env, CLONE_VFORK | CLONE_VM | SIGCHLD,
+ ret = get_errno(do_fork(cpu_env, CLONE_VFORK | CLONE_VM | TARGET_SIGCHLD,
0, 0, 0, 0));
break;
#endif
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Fix fork() and vfork()
2017-02-28 2:51 [Qemu-devel] [PATCH] linux-user: Fix fork() and vfork() Tim Hentenaar
@ 2017-02-28 13:46 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2017-02-28 13:46 UTC (permalink / raw)
To: Tim Hentenaar; +Cc: QEMU Developers, Riku Voipio
On 28 February 2017 at 02:51, Tim Hentenaar <tim@hentenaar.com> wrote:
> A check was introduced in 5ea2fc84da1bffce749c9d0848f5336def2818bb which
> causes fork() and vfork() to fail if TARGET_SIGCHLD != SIGCHLD.
>
> Signed-off-by: Tim Hentenaar <tim@hentenaar.com>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for this patch. In fact the equivalent bugfix has just
hit QEMU git master, as commit 7eddb5ddacb783ba.
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-28 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 2:51 [Qemu-devel] [PATCH] linux-user: Fix fork() and vfork() Tim Hentenaar
2017-02-28 13:46 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.