All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] md: don't impose the MD_SB_DISKS limit on arrays without metadata.
@ 2017-02-28 20:31 NeilBrown
  2017-02-28 21:15 ` Shaohua Li
  0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2017-02-28 20:31 UTC (permalink / raw)
  To: Shaohua Li; +Cc: linux-raid, ian_bruce

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]


These arrays, created with "mdadm --build" don't benefit from a limit.
The default will be used, which is '0' and is interpreted as "don't
impose a limit".

Reported-by: ian_bruce@mail.ru
Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/md/md.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ba485dcf1064..e0ac7f5a8e68 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6464,9 +6464,8 @@ static int set_array_info(struct mddev *mddev, mdu_array_info_t *info)
 	mddev->layout        = info->layout;
 	mddev->chunk_sectors = info->chunk_size >> 9;
 
-	mddev->max_disks     = MD_SB_DISKS;
-
 	if (mddev->persistent) {
+		mddev->max_disks     = MD_SB_DISKS;
 		mddev->flags         = 0;
 		mddev->sb_flags         = 0;
 	}
-- 
2.11.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] md: don't impose the MD_SB_DISKS limit on arrays without metadata.
  2017-02-28 20:31 [PATCH] md: don't impose the MD_SB_DISKS limit on arrays without metadata NeilBrown
@ 2017-02-28 21:15 ` Shaohua Li
  0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2017-02-28 21:15 UTC (permalink / raw)
  To: NeilBrown; +Cc: linux-raid, ian_bruce

On Wed, Mar 01, 2017 at 07:31:28AM +1100, Neil Brown wrote:
> 
> These arrays, created with "mdadm --build" don't benefit from a limit.
> The default will be used, which is '0' and is interpreted as "don't
> impose a limit".
> 
> Reported-by: ian_bruce@mail.ru
> Signed-off-by: NeilBrown <neilb@suse.com>

applied, thanks!

> ---
>  drivers/md/md.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index ba485dcf1064..e0ac7f5a8e68 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6464,9 +6464,8 @@ static int set_array_info(struct mddev *mddev, mdu_array_info_t *info)
>  	mddev->layout        = info->layout;
>  	mddev->chunk_sectors = info->chunk_size >> 9;
>  
> -	mddev->max_disks     = MD_SB_DISKS;
> -
>  	if (mddev->persistent) {
> +		mddev->max_disks     = MD_SB_DISKS;
>  		mddev->flags         = 0;
>  		mddev->sb_flags         = 0;
>  	}
> -- 
> 2.11.0
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-28 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 20:31 [PATCH] md: don't impose the MD_SB_DISKS limit on arrays without metadata NeilBrown
2017-02-28 21:15 ` Shaohua Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.