[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/ap1302.c:1250:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ap1302.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/ap1302.c
+++ b/drivers/staging/media/atomisp/i2c/ap1302.c
@@ -1247,7 +1247,6 @@ MODULE_DEVICE_TABLE(i2c, ap1302_id);
 
 static struct i2c_driver ap1302_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = AP1302_NAME,
 	},
 	.probe = ap1302_probe,

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 imx.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/imx/imx.c
+++ b/drivers/staging/media/atomisp/i2c/imx/imx.c
@@ -2483,7 +2483,6 @@ MODULE_DEVICE_TABLE(i2c, imx_ids);
 
 static struct i2c_driver imx_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = IMX_DRIVER,
 	},
 	.probe = imx_probe,

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/gc2235.c:1208:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gc2235.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -1205,7 +1205,6 @@ MODULE_DEVICE_TABLE(acpi, gc2235_acpi_ma
 MODULE_DEVICE_TABLE(i2c, gc2235_id);
 static struct i2c_driver gc2235_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = GC2235_NAME,
 		.acpi_match_table = ACPI_PTR(gc2235_acpi_match),
 	},

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/gc0310.c:1470:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gc0310.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -1467,7 +1467,6 @@ MODULE_DEVICE_TABLE(acpi, gc0310_acpi_ma
 MODULE_DEVICE_TABLE(i2c, gc0310_id);
 static struct i2c_driver gc0310_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = GC0310_NAME,
 		.acpi_match_table = ACPI_PTR(gc0310_acpi_match),
 	},

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/ov2722.c:1352:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ov2722.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/ov2722.c
@@ -1349,7 +1349,6 @@ MODULE_DEVICE_TABLE(acpi, ov2722_acpi_ma
 
 static struct i2c_driver ov2722_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = OV2722_NAME,
 		.acpi_match_table = ACPI_PTR(ov2722_acpi_match),
 	},

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/lm3554.c:986:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 lm3554.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/lm3554.c
+++ b/drivers/staging/media/atomisp/i2c/lm3554.c
@@ -983,7 +983,6 @@ MODULE_DEVICE_TABLE(acpi, lm3554_acpi_ma
 
 static struct i2c_driver lm3554_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = LM3554_NAME,
 		.pm   = &lm3554_pm_ops,
 		.acpi_match_table = ACPI_PTR(lm3554_acpi_match),

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/mt9m114.c:1946:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 mt9m114.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/mt9m114.c
+++ b/drivers/staging/media/atomisp/i2c/mt9m114.c
@@ -1943,7 +1943,6 @@ MODULE_DEVICE_TABLE(acpi, mt9m114_acpi_m
 
 static struct i2c_driver mt9m114_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = "mt9m114",
 		.acpi_match_table = ACPI_PTR(mt9m114_acpi_match),
 	},

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:2066:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ov5693.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
@@ -2063,7 +2063,6 @@ MODULE_DEVICE_TABLE(acpi, ov5693_acpi_ma
 
 static struct i2c_driver ov5693_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = OV5693_NAME,
 		.acpi_match_table = ACPI_PTR(ov5693_acpi_match),
 	},

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/ov2680.c:1535:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ov2680.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/ov2680.c
@@ -1532,7 +1532,6 @@ MODULE_DEVICE_TABLE(acpi, ov2680_acpi_ma
 MODULE_DEVICE_TABLE(i2c, ov2680_id);
 static struct i2c_driver ov2680_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = OV2680_NAME,
 		.acpi_match_table = ACPI_PTR(ov2680_acpi_match),
 

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/i2c/imx/../ov8858.c:2199:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ov8858.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/i2c/imx/../ov8858.c
+++ b/drivers/staging/media/atomisp/i2c/imx/../ov8858.c
@@ -2196,7 +2196,6 @@ static struct acpi_device_id ov8858_acpi
 
 static struct i2c_driver ov8858_driver = {
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = OV8858_NAME,
 		.acpi_match_table = ACPI_PTR(ov8858_acpi_match),
 	},

[PATCH] staging/atomisp: fix returnvar.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c:560:5-8: Unneeded variable: "ret". Return "0" on line 577


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 atomisp_ioctl.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c
@@ -557,8 +557,6 @@ const struct atomisp_format_bridge *atom
 static int atomisp_querycap(struct file *file, void *fh,
 			    struct v4l2_capability *cap)
 {
-	int ret = 0;
-
 	memset(cap, 0, sizeof(struct v4l2_capability));
 
 	WARN_ON(sizeof(DRIVER) > sizeof(cap->driver) ||
@@ -574,7 +572,7 @@ static int atomisp_querycap(struct file
 	cap->device_caps = V4L2_CAP_VIDEO_CAPTURE |
 	    V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_OUTPUT;
 	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
-	return ret;
+	return 0;
 }
 
 /*

[PATCH] staging/atomisp: fix returnvar.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/pci/atomisp2/./atomisp_subdev.c:161:5-8: Unneeded variable: "ret". Return "0" on line 163


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 atomisp_subdev.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_subdev.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_subdev.c
@@ -158,9 +158,7 @@ uint16_t atomisp_subdev_source_pad(struc
 static long isp_subdev_ioctl(struct v4l2_subdev *sd,
 	unsigned int cmd, void *arg)
 {
-	int ret = 0;
-
-	return ret;
+	return 0;
 }
 
 /*

[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c:248:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 vlv2_plat_clock.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c
+++ b/drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c
@@ -245,7 +245,6 @@ static struct platform_driver vlv2_plat_
 	.driver = {
 		.name = "vlv2_plat_clk",
 		.pm = &vlv2_pm_ops,
-		.owner = THIS_MODULE,
 	},
 };
 

[PATCH] staging/atomisp: fix semicolon.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c:465:2-3: Unneeded semicolon
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c:511:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 atomisp_v4l2.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c
@@ -462,7 +462,7 @@ int atomisp_mrfld_power_down(struct atom
 		}
 		/* FIXME: experienced value for delay */
 		usleep_range(100, 150);
-	};
+	}
 }
 
 
@@ -508,7 +508,7 @@ int atomisp_mrfld_power_up(struct atomis
 		}
 		/* FIXME: experienced value for delay */
 		usleep_range(100, 150);
-	};
+	}
 }
 
 int atomisp_runtime_suspend(struct device *dev)

[PATCH] staging/atomisp: fix semicolon.cocci warnings

[kbuild test robot]

drivers/staging/media/atomisp/pci/atomisp2/./atomisp_compat_css20.c:551:3-4: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 atomisp_compat_css20.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_compat_css20.c
@@ -548,7 +548,7 @@ static int __destroy_stream(struct atomi
 			}
 
 			usleep_range(100, 200);
-		};
+		}
 	}
 
 	stream_env->stream_state = CSS_STREAM_STOPPED;

Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[Daniel Glöckner]

On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>


May I ask which repository this patch is based on?
Does Intel finally attempt to upstream the atomisp driver?

Best regards,

  Daniel

Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[Alan Cox]

On Wed, 2017-03-01 at 22:58 +0100, Daniel Glöckner wrote:
> On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
> > 
> > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to
> > set .owner here. The core will do it.
> > 
> >  Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > CC: Alan Cox <alan@linux.intel.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> 
> May I ask which repository this patch is based on?

It's a major clean up from internal code. For various reasons the
previous history of the code can't be exposed (the internal repository
we have contains code that can't go out of Intel for example).

> Does Intel finally attempt to upstream the atomisp driver?

That's the goal for the ISP 2 driver (Baytrail/T and later
Cherrytrail). I can't speak for longer term plans with ISP 3 and later
devices which currently don't have upstream drivers. There are some
bits of support in ISP2 for some of the odder phone platforms as well
but I don't have a way to test them or think anyone cares so plan to
drop those.

Alan

Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

[Fengguang Wu]

On Wed, Mar 01, 2017 at 10:58:59PM +0100, Daniel Glöckner wrote:
>On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
>> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
>>
>>  Remove .owner field if calls are used which set it automatically
>>
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> CC: Alan Cox <alan@linux.intel.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
>
>May I ask which repository this patch is based on?

The email is replying to this one, which shows Greg's staging tree.

  Date: Wed, 1 Mar 2017 18:30:16 +0800
  From: kbuild test robot <fengguang.wu@intel.com>
  To: Alan Cox <alan@linux.intel.com>
  Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kbuild-all@01.org
  Subject: [kbuild-all] [staging:staging-testing 209/209] drivers/staging/media/atomisp/i2c/gc2235.c:37:41: fatal error:
          linux/atomisp_gmin_platform.h: No such file or directory
  
  tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
  head:   628b2b91d50c74e2475a11a0db5978d9a36d2026
  commit: 628b2b91d50c74e2475a11a0db5978d9a36d2026 [209/209] staging/atomisp: Add support for the Intel IPU v2
  config: i386-allmodconfig (attached as .config)
  compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
  reproduce:
          git checkout 628b2b91d50c74e2475a11a0db5978d9a36d2026
          # save the attached .config to linux build tree
          make ARCH=i386

>Does Intel finally attempt to upstream the atomisp driver?

It looks so.

Thanks,
Fengguang