From: Xiong Zhou <xzhou@redhat.com> To: Dan Williams <dan.j.williams@intel.com> Cc: akpm@linux-foundation.org, x86@kernel.org, Xiong Zhou <xzhou@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, torvalds@linux-foundation.org, Ross Zwisler <ross.zwisler@linux.intel.com> Subject: Re: [PATCH 0/2] fix for direct-I/O to DAX mappings Date: Thu, 2 Mar 2017 21:45:13 +0800 [thread overview] Message-ID: <20170302134513.zwkfse3j3vjhzy55@XZHOUW.usersys.redhat.com> (raw) In-Reply-To: <148804250784.36605.12832323062093584440.stgit@dwillia2-desk3.amr.corp.intel.com> On Sat, Feb 25, 2017 at 09:08:28AM -0800, Dan Williams wrote: > Hi Andrew, > > While Ross was doing a review of a new mmap+DAX direct-I/O test case for > xfstests, from Xiong, he noticed occasions where it failed to trigger a > page dirty event. Dave then spotted the problem fixed by patch1. The > pte_devmap() check is precluding pte_allows_gup(), i.e. bypassing > permission checks and dirty tracking. This mmap-dax-dio case still fails with this patchset, while it makes sense. It's the test case that need to be fixed. BTW, this patchset fixes another xfsrestore issue, which i hit now and then, xfs/301 w/ or wo/ DAX only on nvdimms. xfsrestore never return but killable. Thanks, > > Patch2 is a cleanup and clarifies that pte_unmap() only needs to be done > once per page-worth of ptes. It unifies the exit paths similar to the > generic gup_pte_range() in the __HAVE_ARCH_PTE_SPECIAL case. > > I'm sending this through the -mm tree for a double-check from memory > management folks. It has a build success notification from the kbuild > robot. > > --- > > Dan Williams (2): > x86, mm: fix gup_pte_range() vs DAX mappings > x86, mm: unify exit paths in gup_pte_range() > > > arch/x86/mm/gup.c | 37 +++++++++++++++++++++---------------- > 1 file changed, 21 insertions(+), 16 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Xiong Zhou <xzhou@redhat.com> To: Dan Williams <dan.j.williams@intel.com> Cc: akpm@linux-foundation.org, x86@kernel.org, Xiong Zhou <xzhou@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, torvalds@linux-foundation.org, Ross Zwisler <ross.zwisler@linux.intel.com> Subject: Re: [PATCH 0/2] fix for direct-I/O to DAX mappings Date: Thu, 2 Mar 2017 21:45:13 +0800 [thread overview] Message-ID: <20170302134513.zwkfse3j3vjhzy55@XZHOUW.usersys.redhat.com> (raw) In-Reply-To: <148804250784.36605.12832323062093584440.stgit@dwillia2-desk3.amr.corp.intel.com> On Sat, Feb 25, 2017 at 09:08:28AM -0800, Dan Williams wrote: > Hi Andrew, > > While Ross was doing a review of a new mmap+DAX direct-I/O test case for > xfstests, from Xiong, he noticed occasions where it failed to trigger a > page dirty event. Dave then spotted the problem fixed by patch1. The > pte_devmap() check is precluding pte_allows_gup(), i.e. bypassing > permission checks and dirty tracking. This mmap-dax-dio case still fails with this patchset, while it makes sense. It's the test case that need to be fixed. BTW, this patchset fixes another xfsrestore issue, which i hit now and then, xfs/301 w/ or wo/ DAX only on nvdimms. xfsrestore never return but killable. Thanks, > > Patch2 is a cleanup and clarifies that pte_unmap() only needs to be done > once per page-worth of ptes. It unifies the exit paths similar to the > generic gup_pte_range() in the __HAVE_ARCH_PTE_SPECIAL case. > > I'm sending this through the -mm tree for a double-check from memory > management folks. It has a build success notification from the kbuild > robot. > > --- > > Dan Williams (2): > x86, mm: fix gup_pte_range() vs DAX mappings > x86, mm: unify exit paths in gup_pte_range() > > > arch/x86/mm/gup.c | 37 +++++++++++++++++++++---------------- > 1 file changed, 21 insertions(+), 16 deletions(-) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-02 13:54 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-25 17:08 [PATCH 0/2] fix for direct-I/O to DAX mappings Dan Williams 2017-02-25 17:08 ` Dan Williams 2017-02-25 17:08 ` [PATCH 1/2] x86, mm: fix gup_pte_range() vs " Dan Williams 2017-02-25 17:08 ` Dan Williams 2017-02-25 17:08 ` [PATCH 2/2] x86, mm: unify exit paths in gup_pte_range() Dan Williams 2017-02-25 17:08 ` Dan Williams 2017-02-28 17:10 ` [PATCH 0/2] fix for direct-I/O to DAX mappings Linus Torvalds 2017-02-28 17:10 ` Linus Torvalds 2017-02-28 22:09 ` Andrew Morton 2017-02-28 22:09 ` Andrew Morton 2017-03-02 13:45 ` Xiong Zhou [this message] 2017-03-02 13:45 ` Xiong Zhou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170302134513.zwkfse3j3vjhzy55@XZHOUW.usersys.redhat.com \ --to=xzhou@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=dan.j.williams@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@redhat.com \ --cc=ross.zwisler@linux.intel.com \ --cc=stable@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.