All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: Correct NVMF enum values to match NVMe-oF rev 1.0
Date: Thu, 2 Mar 2017 07:52:42 -0800	[thread overview]
Message-ID: <20170302155242.GA31807@infradead.org> (raw)
In-Reply-To: <20170302022201.2946-1-roland@kernel.org>

On Wed, Mar 01, 2017@06:22:01PM -0800, Roland Dreier wrote:
> From: Roland Dreier <roland at purestorage.com>
> 
> The enum values for QPTYPE, PRTYPE and CMS are off by 1 from the
> values defined in figure 42 of the NVM Express over Fabrics 1.0:
> 
>     http://www.nvmexpress.org/wp-content/uploads/NVMe_over_Fabrics_1_0_Gold_20160605-1.pdf
> 
> Fix our enums to match the final spec.

So this basically affects the discovery information, which at least
in the Linux world is not used anywhere except for printing it in
nvme-cli.  So this looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>

But can you also send an update for nvme-cli, please?

  reply	other threads:[~2017-03-02 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  2:22 [PATCH] nvme: Correct NVMF enum values to match NVMe-oF rev 1.0 Roland Dreier
2017-03-02 15:52 ` Christoph Hellwig [this message]
2017-03-02 16:02   ` Keith Busch
2017-03-02 15:56     ` Christoph Hellwig
2017-03-02 18:08       ` Roland Dreier
2017-03-02 18:34         ` Keith Busch
2017-03-02 19:04           ` Roland Dreier
2017-03-03 15:52 ` Schremmer, Steven
2017-03-06 11:43 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302155242.GA31807@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.