All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve.Schremmer@netapp.com (Schremmer, Steven)
Subject: [PATCH] nvme: Correct NVMF enum values to match NVMe-oF rev 1.0
Date: Fri, 3 Mar 2017 15:52:12 +0000	[thread overview]
Message-ID: <BN6PR06MB24815F01F65E488A429F966A8C2B0@BN6PR06MB2481.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20170302022201.2946-1-roland@kernel.org>

> From: Roland Dreier <roland at purestorage.com>
> 
> The enum values for QPTYPE, PRTYPE and CMS are off by 1 from the
> values defined in figure 42 of the NVM Express over Fabrics 1.0:
> 
>     http://www.nvmexpress.org/wp-content/uploads/NVMe_over_Fabrics_1_0_Gold_20160605-1.pdf
> 
> Fix our enums to match the final spec.
> 
> Signed-off-by: Roland Dreier <roland at purestorage.com>
> ---
>  include/linux/nvme.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index c43d435d4225..9061780b141f 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -64,26 +64,26 @@ enum {
>   * RDMA_QPTYPE field
>   */
>  enum {
> -	NVMF_RDMA_QPTYPE_CONNECTED	= 0, /* Reliable Connected */
> -	NVMF_RDMA_QPTYPE_DATAGRAM	= 1, /* Reliable Datagram */
> +	NVMF_RDMA_QPTYPE_CONNECTED	= 1, /* Reliable Connected */
> +	NVMF_RDMA_QPTYPE_DATAGRAM	= 2, /* Reliable Datagram */
>  };
> 
>  /* RDMA QP Service Type codes for Discovery Log Page entry TSAS
>   * RDMA_QPTYPE field
>   */
>  enum {
> -	NVMF_RDMA_PRTYPE_NOT_SPECIFIED	= 0, /* No Provider Specified */
> -	NVMF_RDMA_PRTYPE_IB		= 1, /* InfiniBand */
> -	NVMF_RDMA_PRTYPE_ROCE		= 2, /* InfiniBand RoCE */
> -	NVMF_RDMA_PRTYPE_ROCEV2		= 3, /* InfiniBand RoCEV2 */
> -	NVMF_RDMA_PRTYPE_IWARP		= 4, /* IWARP */
> +	NVMF_RDMA_PRTYPE_NOT_SPECIFIED	= 1, /* No Provider Specified */
> +	NVMF_RDMA_PRTYPE_IB		= 2, /* InfiniBand */
> +	NVMF_RDMA_PRTYPE_ROCE		= 3, /* InfiniBand RoCE */
> +	NVMF_RDMA_PRTYPE_ROCEV2		= 4, /* InfiniBand RoCEV2 */
> +	NVMF_RDMA_PRTYPE_IWARP		= 5, /* IWARP */
>  };
> 
>  /* RDMA Connection Management Service Type codes for Discovery Log Page
>   * entry TSAS RDMA_CMS field
>   */
>  enum {
> -	NVMF_RDMA_CMS_RDMA_CM	= 0, /* Sockets based enpoint addressing */
> +	NVMF_RDMA_CMS_RDMA_CM	= 1, /* Sockets based endpoint addressing */
>  };
> 
>  #define NVMF_AQ_DEPTH		32
> --
> 2.10.2

Thanks. I was preparing a to send a patch for this. 
You might want to fix the comment above the NVMF_RDMA_PRTYPE_ enum, as it's just a copy of the one above it.
Reviewed-by: Steve Schremmer <steve.schremmer at netapp.com>

  parent reply	other threads:[~2017-03-03 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  2:22 [PATCH] nvme: Correct NVMF enum values to match NVMe-oF rev 1.0 Roland Dreier
2017-03-02 15:52 ` Christoph Hellwig
2017-03-02 16:02   ` Keith Busch
2017-03-02 15:56     ` Christoph Hellwig
2017-03-02 18:08       ` Roland Dreier
2017-03-02 18:34         ` Keith Busch
2017-03-02 19:04           ` Roland Dreier
2017-03-03 15:52 ` Schremmer, Steven [this message]
2017-03-06 11:43 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR06MB24815F01F65E488A429F966A8C2B0@BN6PR06MB2481.namprd06.prod.outlook.com \
    --to=steve.schremmer@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.