* [Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump
@ 2017-03-02 23:01 Alexander Duyck
2017-03-07 19:21 ` Bowers, AndrewX
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Duyck @ 2017-03-02 23:01 UTC (permalink / raw)
To: intel-wired-lan
From: Alexander Duyck <alexander.h.duyck@intel.com>
I just found that when we had changed the Rx path to check for length
instead of the DD bit we introduced an issue in ixgbe_dump since we were no
longer clearing the status bits.
To correct this I am updating ixgbe_dump to look for the length bits in the
descriptor since that is what we are using in the Rx path.
Fixes: c3630cc40b4f ("ixgbe: Use length to determine if descriptor is done")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index a922a2c2e4b6..b58f4b255e4e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -601,7 +601,6 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)
struct ixgbe_ring *rx_ring;
union ixgbe_adv_rx_desc *rx_desc;
struct ixgbe_rx_buffer *rx_buffer_info;
- u32 staterr;
int i = 0;
if (!netif_msg_hw(adapter))
@@ -810,8 +809,7 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)
rx_buffer_info = &rx_ring->rx_buffer_info[i];
rx_desc = IXGBE_RX_DESC(rx_ring, i);
u0 = (struct my_u0 *)rx_desc;
- staterr = le32_to_cpu(rx_desc->wb.upper.status_error);
- if (staterr & IXGBE_RXD_STAT_DD) {
+ if (rx_desc->wb.upper.length) {
/* Descriptor Done */
pr_info("RWB[0x%03X] %016llX "
"%016llX ---------------- %p", i,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump
2017-03-02 23:01 [Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump Alexander Duyck
@ 2017-03-07 19:21 ` Bowers, AndrewX
0 siblings, 0 replies; 2+ messages in thread
From: Bowers, AndrewX @ 2017-03-07 19:21 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Thursday, March 2, 2017 3:02 PM
> To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@intel.com>
> Subject: [Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump
>
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> I just found that when we had changed the Rx path to check for length
> instead of the DD bit we introduced an issue in ixgbe_dump since we were
> no longer clearing the status bits.
>
> To correct this I am updating ixgbe_dump to look for the length bits in the
> descriptor since that is what we are using in the Rx path.
>
> Fixes: c3630cc40b4f ("ixgbe: Use length to determine if descriptor is done")
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-07 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 23:01 [Intel-wired-lan] [net PATCH] ixgbe: Fix output from ixgbe_dump Alexander Duyck
2017-03-07 19:21 ` Bowers, AndrewX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.