All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] igt/gem_bad_address: Remove test
@ 2017-03-02 23:54 Antonio Argenziano
  2017-03-03  9:38 ` Michał Winiarski
  0 siblings, 1 reply; 2+ messages in thread
From: Antonio Argenziano @ 2017-03-02 23:54 UTC (permalink / raw)
  To: intel-gfx

The intent of the test is to provide an incorrect input to a command.
Since the driver doesn't do any command validation, this test is removed
as non applicable.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/Makefile.sources  |  1 -
 tests/gem_bad_address.c | 75 -------------------------------------------------
 2 files changed, 76 deletions(-)
 delete mode 100644 tests/gem_bad_address.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 6e07d938..01a13090 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -300,7 +300,6 @@ HANG = \
 	gem_bad_batch \
 	gem_hang \
 	gem_bad_blit \
-	gem_bad_address \
 	gem_non_secure_batch \
 	$(NULL)
 
diff --git a/tests/gem_bad_address.c b/tests/gem_bad_address.c
deleted file mode 100644
index a970dfa4..00000000
--- a/tests/gem_bad_address.c
+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Copyright © 2009 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- * Authors:
- *    Eric Anholt <eric@anholt.net>
- *    Jesse Barnes <jbarnes@virtuousgeek.org> (based on gem_bad_blit.c)
- *
- */
-
-#include "igt.h"
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/time.h>
-#include "drm.h"
-#include "intel_bufmgr.h"
-
-static drm_intel_bufmgr *bufmgr;
-struct intel_batchbuffer *batch;
-
-#define BAD_GTT_DEST ((512*1024*1024)) /* past end of aperture */
-
-static void
-bad_store(void)
-{
-	BEGIN_BATCH(4, 0);
-	OUT_BATCH(MI_STORE_DWORD_IMM | MI_MEM_VIRTUAL | 1 << 21);
-	OUT_BATCH(0);
-	OUT_BATCH(BAD_GTT_DEST);
-	OUT_BATCH(0xdeadbeef);
-	ADVANCE_BATCH();
-
-	intel_batchbuffer_flush(batch);
-}
-
-igt_simple_main
-{
-	int fd;
-
-	fd = drm_open_driver(DRIVER_INTEL);
-
-	bufmgr = drm_intel_bufmgr_gem_init(fd, 4096);
-	drm_intel_bufmgr_gem_enable_reuse(bufmgr);
-	batch = intel_batchbuffer_alloc(bufmgr, intel_get_drm_devid(fd));
-
-	bad_store();
-
-	intel_batchbuffer_free(batch);
-	drm_intel_bufmgr_destroy(bufmgr);
-
-	close(fd);
-}
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH i-g-t] igt/gem_bad_address: Remove test
  2017-03-02 23:54 [PATCH i-g-t] igt/gem_bad_address: Remove test Antonio Argenziano
@ 2017-03-03  9:38 ` Michał Winiarski
  0 siblings, 0 replies; 2+ messages in thread
From: Michał Winiarski @ 2017-03-03  9:38 UTC (permalink / raw)
  To: Antonio Argenziano; +Cc: intel-gfx

On Thu, Mar 02, 2017 at 03:54:57PM -0800, Antonio Argenziano wrote:
> The intent of the test is to provide an incorrect input to a command.
> Since the driver doesn't do any command validation, this test is removed
> as non applicable.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał

> ---
>  tests/Makefile.sources  |  1 -
>  tests/gem_bad_address.c | 75 -------------------------------------------------
>  2 files changed, 76 deletions(-)
>  delete mode 100644 tests/gem_bad_address.c
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-03  9:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 23:54 [PATCH i-g-t] igt/gem_bad_address: Remove test Antonio Argenziano
2017-03-03  9:38 ` Michał Winiarski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.