* [PATCH] http: release strbuf on disabled alternates
@ 2017-03-04 1:50 Eric Wong
2017-03-04 3:42 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2017-03-04 1:50 UTC (permalink / raw)
To: Junio C Hamano, Jeff King; +Cc: git
This likely has no real-world impact on memory usage,
but it is cleaner for future readers.
Fixes: abcbdc03895f ("http: respect protocol.*.allow=user for http-alternates")
Signed-off-by: Eric Wong <e@80x24.org>
---
http-walker.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/http-walker.c b/http-walker.c
index b34b6ace7c..2c85316112 100644
--- a/http-walker.c
+++ b/http-walker.c
@@ -314,6 +314,8 @@ static void process_alternates_response(void *callback_data)
while (tail->next != NULL)
tail = tail->next;
tail->next = newalt;
+ } else {
+ strbuf_release(&target);
}
}
}
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] http: release strbuf on disabled alternates
2017-03-04 1:50 [PATCH] http: release strbuf on disabled alternates Eric Wong
@ 2017-03-04 3:42 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2017-03-04 3:42 UTC (permalink / raw)
To: Eric Wong; +Cc: Junio C Hamano, git
On Sat, Mar 04, 2017 at 01:50:16AM +0000, Eric Wong wrote:
> This likely has no real-world impact on memory usage,
> but it is cleaner for future readers.
Yep, this looks good.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-04 3:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-04 1:50 [PATCH] http: release strbuf on disabled alternates Eric Wong
2017-03-04 3:42 ` Jeff King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.