* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
@ 2017-02-01 13:53 Ignacy Gawędzki
2017-02-06 18:39 ` Romain Naour
2017-03-05 21:48 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Ignacy Gawędzki @ 2017-02-01 13:53 UTC (permalink / raw)
To: buildroot
Include the --disable-dependency-tracking option in
<pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR
is empty. Dependency tracking is very welcome while developing in
order to properly rebuild when calling make <pkg>-rebuild for
instance.
Signed-off-by: Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
---
package/pkg-autotools.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index f7b8488..e8579f4 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
--disable-documentation \
--with-xmlto=no \
--with-fop=no \
- --disable-dependency-tracking \
+ $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+ --disable-dependency-tracking) \
--enable-ipv6 \
$$(DISABLE_NLS) \
$$(SHARED_STATIC_LIBS_OPTS) \
@@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
--disable-debug \
--with-xmlto=no \
--with-fop=no \
- --disable-dependency-tracking \
+ $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+ --disable-dependency-tracking) \
$$(QUIET) $$($$(PKG)_CONF_OPTS) \
)
endef
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
2017-02-01 13:53 [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR Ignacy Gawędzki
@ 2017-02-06 18:39 ` Romain Naour
2017-02-06 19:37 ` Ignacy Gawędzki
2017-03-05 21:48 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Romain Naour @ 2017-02-06 18:39 UTC (permalink / raw)
To: buildroot
Hi Ignacy,
Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :
> Include the --disable-dependency-tracking option in
> <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR
> is empty. Dependency tracking is very welcome while developing in
> order to properly rebuild when calling make <pkg>-rebuild for
> instance.
>
> Signed-off-by: Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
> ---
> package/pkg-autotools.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index f7b8488..e8579f4 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
> --disable-documentation \
> --with-xmlto=no \
> --with-fop=no \
> - --disable-dependency-tracking \
> + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
> + --disable-dependency-tracking) \
> --enable-ipv6 \
> $$(DISABLE_NLS) \
> $$(SHARED_STATIC_LIBS_OPTS) \
> @@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
> --disable-debug \
> --with-xmlto=no \
> --with-fop=no \
> - --disable-dependency-tracking \
> + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
> + --disable-dependency-tracking) \
You're likely working on the target variant, so probably you can let the
dependency tracking enabled for the host?
Best regards,
Romain
> $$(QUIET) $$($$(PKG)_CONF_OPTS) \
> )
> endef
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
2017-02-06 18:39 ` Romain Naour
@ 2017-02-06 19:37 ` Ignacy Gawędzki
2017-02-07 22:14 ` Romain Naour
0 siblings, 1 reply; 6+ messages in thread
From: Ignacy Gawędzki @ 2017-02-06 19:37 UTC (permalink / raw)
To: buildroot
On Mon, Feb 06, 2017 at 07:39:00PM +0100, thus spake Romain Naour:
> Hi Ignacy,
>
> Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :
> > Include the --disable-dependency-tracking option in
> > <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR
> > is empty. Dependency tracking is very welcome while developing in
> > order to properly rebuild when calling make <pkg>-rebuild for
> > instance.
> >
> > Signed-off-by: Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
> > ---
> > package/pkg-autotools.mk | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> > index f7b8488..e8579f4 100644
> > --- a/package/pkg-autotools.mk
> > +++ b/package/pkg-autotools.mk
> > @@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
> > --disable-documentation \
> > --with-xmlto=no \
> > --with-fop=no \
> > - --disable-dependency-tracking \
> > + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
> > + --disable-dependency-tracking) \
> > --enable-ipv6 \
> > $$(DISABLE_NLS) \
> > $$(SHARED_STATIC_LIBS_OPTS) \
> > @@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
> > --disable-debug \
> > --with-xmlto=no \
> > --with-fop=no \
> > - --disable-dependency-tracking \
> > + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
> > + --disable-dependency-tracking) \
>
> You're likely working on the target variant, so probably you can let the
> dependency tracking enabled for the host?
Dependency tracking was initially *disabled* for both target and host.
I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host,
so I don't see why we should leave it disabled for one and not the
other.
Regards,
Ignacy
--
Ignacy Gaw?dzki
R&D Engineer
Green Communications
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
2017-02-06 19:37 ` Ignacy Gawędzki
@ 2017-02-07 22:14 ` Romain Naour
2017-02-08 9:28 ` Nicolas Cavallari
0 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2017-02-07 22:14 UTC (permalink / raw)
To: buildroot
Hi Ignacy,
Le 06/02/2017 ? 20:37, Ignacy Gaw?dzki a ?crit :
> On Mon, Feb 06, 2017 at 07:39:00PM +0100, thus spake Romain Naour:
>> Hi Ignacy,
>>
>> Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :
>>> Include the --disable-dependency-tracking option in
>>> <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR
>>> is empty. Dependency tracking is very welcome while developing in
>>> order to properly rebuild when calling make <pkg>-rebuild for
>>> instance.
>>>
>>> Signed-off-by: Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
>>> ---
>>> package/pkg-autotools.mk | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
>>> index f7b8488..e8579f4 100644
>>> --- a/package/pkg-autotools.mk
>>> +++ b/package/pkg-autotools.mk
>>> @@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
>>> --disable-documentation \
>>> --with-xmlto=no \
>>> --with-fop=no \
>>> - --disable-dependency-tracking \
>>> + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
>>> + --disable-dependency-tracking) \
>>> --enable-ipv6 \
>>> $$(DISABLE_NLS) \
>>> $$(SHARED_STATIC_LIBS_OPTS) \
>>> @@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
>>> --disable-debug \
>>> --with-xmlto=no \
>>> --with-fop=no \
>>> - --disable-dependency-tracking \
>>> + $$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
>>> + --disable-dependency-tracking) \
>>
>> You're likely working on the target variant, so probably you can let the
>> dependency tracking enabled for the host?
>
> Dependency tracking was initially *disabled* for both target and host.
> I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host,
> so I don't see why we should leave it disabled for one and not the
> other.
Indeed <pkg>_OVERRIDE_SRCDIR works for both target and host packages and the
"dependency tracking" was disabled (see [1]) to reduce the build time.
My initial feeling is to allow to enable the "dependency tracking" only when
doing active development on a *target* package using <pkg>_OVERRIDE_SRCDIR.
Buildroot is unlikely used for active development on a *host* package.
But ok, if you're using <pkg>_OVERRIDE_SRCDIR for a host package, you probably
don't really care of the build time...
Lets see other opinion.
Best regards,
Romain
[1]
https://git.busybox.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992
>
> Regards,
>
> Ignacy
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
2017-02-07 22:14 ` Romain Naour
@ 2017-02-08 9:28 ` Nicolas Cavallari
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Cavallari @ 2017-02-08 9:28 UTC (permalink / raw)
To: buildroot
On 07/02/2017 23:14, Romain Naour a ?crit:
> Hi Ignacy,
>
> Le 06/02/2017 ? 20:37, Ignacy Gaw?dzki a ?crit :
>> On Mon, Feb 06, 2017 at 07:39:00PM +0100, parla Romain Naour:
>>>
>>> You're likely working on the target variant, so probably you can let the
>>> dependency tracking enabled for the host?
>>
>> Dependency tracking was initially *disabled* for both target and host.
>> I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host,
>> so I don't see why we should leave it disabled for one and not the
>> other.
>
> Indeed <pkg>_OVERRIDE_SRCDIR works for both target and host packages and the
> "dependency tracking" was disabled (see [1]) to reduce the build time.
>
> My initial feeling is to allow to enable the "dependency tracking" only when
> doing active development on a *target* package using <pkg>_OVERRIDE_SRCDIR.
> Buildroot is unlikely used for active development on a *host* package.
Some hosts packages are a dependency of the target package, because
they are not very friendly to cross-compiling, so the host variant
compiles build tools used by the target variant. Both should be in
sync when building.
So it make sense to enable dependency tracking for hosts packages
during active development for a target package.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.
2017-02-01 13:53 [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR Ignacy Gawędzki
2017-02-06 18:39 ` Romain Naour
@ 2017-03-05 21:48 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-03-05 21:48 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 1 Feb 2017 14:53:10 +0100, Ignacy Gaw?dzki wrote:
> Include the --disable-dependency-tracking option in
> <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR
> is empty. Dependency tracking is very welcome while developing in
> order to properly rebuild when calling make <pkg>-rebuild for
> instance.
>
> Signed-off-by: Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
> ---
> package/pkg-autotools.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to master, with a slight tweak to the commit title, and putting
$$(if $$($$(PKG)_OVERRIDE_SRCDIR),,--disable-dependency-tracking) \
even if it's 83 characters wide. I find that more readable this way.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-05 21:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-01 13:53 [Buildroot] [PATCH] Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR Ignacy Gawędzki
2017-02-06 18:39 ` Romain Naour
2017-02-06 19:37 ` Ignacy Gawędzki
2017-02-07 22:14 ` Romain Naour
2017-02-08 9:28 ` Nicolas Cavallari
2017-03-05 21:48 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.